From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DED5CC07E9D for ; Mon, 26 Sep 2022 16:00:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63D1E8E006D; Mon, 26 Sep 2022 12:00:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EB698E0066; Mon, 26 Sep 2022 12:00:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B3678E006D; Mon, 26 Sep 2022 12:00:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3B87D8E0066 for ; Mon, 26 Sep 2022 12:00:02 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 10002C0C13 for ; Mon, 26 Sep 2022 16:00:02 +0000 (UTC) X-FDA: 79954697844.21.4DF98A3 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf17.hostedemail.com (Postfix) with ESMTP id 97D4A40006 for ; Mon, 26 Sep 2022 16:00:01 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CC2C9B80AF1; Mon, 26 Sep 2022 15:59:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24556C433D6; Mon, 26 Sep 2022 15:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664207998; bh=lCXiO5pkSuuEK+otVIzDciHG2H+yZcwpbuBZsPzrWa8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HgiVK7mlWxF02ggtQ8CCAWjFQap9Zpjtj+0XJ0De6iqH3MkSmfzxxO9L6k1akCCFS 8Pf9uM333SznQrsjGEKuU7PXs3ESYJDNjfao4hJpww3eO1EntSD263zFhTaJ1qxwgb C602ymei1Y6K573DFfnZWSP6Fe03gHrZRjGi83ztEF/7jE+YpHJF5d5g3iVe5JtDF4 x27ffxgVKpmN5AZNqmvy0aTlSSm+3q9ajX4011KfzhS2kLpypDA2rUkQPTOdH8tZj2 aMcwbX7QZoIiWLtgPvaJbaQ+sDjt2S5VWNiTOmvgXNRXUPXYhVjBHf3uE3KBaNpw+F 33RaINjWgiCEA== From: SeongJae Park To: Levi Yun Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH v3] damon/sysfs: Fix possible memleak on damon_sysfs_add_target. Date: Mon, 26 Sep 2022 15:59:54 +0000 Message-Id: <20220926155954.48379-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220925234327.26345-1-ppbuk5246@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HgiVK7ml; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664208001; a=rsa-sha256; cv=none; b=RtgpyLg7htCHihUWFSPkKzPU/uYEbc4YbtEHSmgBCk6K1QeamLDCgi6dFS3IKWFZFLMMvU XTqnBzGrYhVpIhIO0pA895X4WsGRo5SwVvSkPruCreAgDgmd39+q5J9IFQ2kXFyVSRQcDH mkkhiMk1vr/BN1yJR+qaJHsNARsa3SM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664208001; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1obhKx7lz2UfMiuPk2O2T1p9QZd1SmuD8/O94djlKtU=; b=7qX+QKyUfDMNVzKKO8RwEcUFBmPfXPvXPAItxHZHs5/3vDFx4gsE2ZlKO1bNbRirmeDfxW 1JHK0dLM21583rdsiyh3UYU6LXXmDbwJVCsTiAyESIcEhQbSivbeGiAU0ww7JjrvDUXJ2x NEGUPK9Al4KL8oLH7mpf6Kref3b1Nn0= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 97D4A40006 X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HgiVK7ml; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: jg5xe4s698w9jewmyt184jpamrh9ope6 X-HE-Tag: 1664208001-529887 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Levi, On Mon, 26 Sep 2022 08:43:27 +0900 Levi Yun wrote: > When damon_sysfs_add_target couldn't find proper task, > New allocated damon_target structure isn't registered yet, > So, it's impossible to free new allocated one by > damon_sysfs_destroy_targets. > > By calling daemon_add_target as soon as allocating new target, Fix this > possible memory leak. > > Signed-off-by: Levi Yun > Fixes:74bd8b7d2f8e7 The commit is indeed the last one which touched the code, but the bug was introduced earlier than that, by commit a61ea561c871 ("mm/damon/sysfs: link DAMON for virtual address spaces monitoring"). Also, let's add one space before the commit hash, then only 12 characters for the hash, and then one line summary of the commit[1], like below. Fixes: a61ea561c871 ("mm/damon/sysfs: link DAMON for virtual address spaces monitoring") [1] https://www.kernel.org/doc/html/v4.15/process/submitting-patches.html#describe-your-changes > Cc: > --- Also, putting the change log of the patch here would be a good practice. Other than the very minor things, Reviewed-by: SeongJae Park As the changes I'm requesting are very minor, I will revise and post a new version of this patch on my own. Thanks, SJ > mm/damon/sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c > index 7488e27c87c3..bdef9682d0a0 100644 > --- a/mm/damon/sysfs.c > +++ b/mm/damon/sysfs.c > @@ -2182,12 +2182,12 @@ static int damon_sysfs_add_target(struct damon_sysfs_target *sys_target, > > if (!t) > return -ENOMEM; > + damon_add_target(ctx, t); > if (damon_target_has_pid(ctx)) { > t->pid = find_get_pid(sys_target->pid); > if (!t->pid) > goto destroy_targets_out; > } > - damon_add_target(ctx, t); > err = damon_sysfs_set_regions(t, sys_target->regions); > if (err) > goto destroy_targets_out; > -- > 2.35.1 >