From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 217C6C04A95 for ; Mon, 26 Sep 2022 00:38:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 492DA8E0027; Sun, 25 Sep 2022 20:38:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4429C8E0007; Sun, 25 Sep 2022 20:38:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E3D28E0027; Sun, 25 Sep 2022 20:38:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1B29F8E0007 for ; Sun, 25 Sep 2022 20:38:52 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C097C14036C for ; Mon, 26 Sep 2022 00:38:51 +0000 (UTC) X-FDA: 79952376462.26.40254BF Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by imf23.hostedemail.com (Postfix) with ESMTP id 70AD914000A for ; Mon, 26 Sep 2022 00:38:51 +0000 (UTC) Received: by mail-pg1-f175.google.com with SMTP id q9so5165640pgq.8 for ; Sun, 25 Sep 2022 17:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=ZsMZDiPJ05dqPEjOyzQRRCQyAniieUtquk7D7/uc9oo=; b=EloZHChUwOJ+IAK+dqPRjhd24FYS6MkmFqZpedddEJP3NPIP54FWcwg3RKRz6Ai8pZ z2DviABmbm5Ne8x7+vcrgYA1N3bmoOgjdNpOgYz+yaXmcZ9y56Pdoen1P+xANPX4dHu4 HiKqS9DzqPcFKjopFBXMCDEaM898Bv94O7hJQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=ZsMZDiPJ05dqPEjOyzQRRCQyAniieUtquk7D7/uc9oo=; b=Oz6qHJFYyB4D2qIhztFEH09GERYBUL2QvOG6onlaaQlb6sIZ4wUZxe8fihgGLA3NyN Igr/5NOGF2oqR27XsKpLU2nwHX7kgcb1Gkp0Pv9x5mYyv7WzLO57DQs1WAL+PmRioFBi Ce/+1ew4qwyMa3pYtYdV1a/5I+HXp3/7CL6Qowv1e1dYP+oDbx/L2oVZzz+isIYarFfJ VJTnv3DGDOI1XHRERoySqKCklAeIdF+QNQh7fhJSxhUZvVASkTQpLejGznoWS9bpqCUE R3wIVMW9saMotiPF4PEE5CMWvQIBPvDwAyRlzogv0czQw7WeY/ecNMYYSNAP3eVCWweT GS8w== X-Gm-Message-State: ACrzQf2EJELzD7SzRczgG3vTsAvZ+McS26H5SelOWsaJt65itEYJYKl6 AHQo4mZA7yTdB4JuRQsgRPTGsA== X-Google-Smtp-Source: AMsMyM7j48vn8CX614C8f5vlUd1g6FcIEIYyyHHTpwyTo0bx6Hew8gRK92T2JHXk4G8JNUKlDJxOQQ== X-Received: by 2002:a63:4b1d:0:b0:439:e6a4:e902 with SMTP id y29-20020a634b1d000000b00439e6a4e902mr18048148pga.212.1664152730415; Sun, 25 Sep 2022 17:38:50 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t11-20020a17090340cb00b00172951ddb12sm9640855pld.42.2022.09.25.17.38.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Sep 2022 17:38:49 -0700 (PDT) Date: Sun, 25 Sep 2022 17:38:48 -0700 From: Kees Cook To: Dmitry Vyukov Cc: Vlastimil Babka , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Vincenzo Frascino , Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, "Ruhl, Michael J" , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Greg Kroah-Hartman , Nick Desaulniers , Alex Elder , Josef Bacik , David Sterba , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , Jesse Brandeburg , Daniel Micay , Yonghong Song , Marco Elver , Miguel Ojeda , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-fsdevel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, dev@openvswitch.org, x86@kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 14/16] kasan: Remove ksize()-related tests Message-ID: <202209251738.6A453BC008@keescook> References: <20220923202822.2667581-1-keescook@chromium.org> <20220923202822.2667581-15-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664152731; a=rsa-sha256; cv=none; b=8mbiyrSR9U3of8fNRzlnWcj7pKgtcHM8pSodz3SOSiQbcYCArxDeeR37hHZ5wV/ZXqiLHo xOcz6jJep4ph4Vh4hqk9Lv7gcs/gG/NKQ580ibS0sbIZ2lbaPjr2E/aunC4UJbbakr8erY B//Oq9rXC8vyhEI0zhjboy0yICAUy4g= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=EloZHChU; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf23.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.175 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664152731; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZsMZDiPJ05dqPEjOyzQRRCQyAniieUtquk7D7/uc9oo=; b=WvrKUI8y8L0A0l+tUll1S47lnyxb8hSnKAswEXPL02/BRa4lAvx+mpqlMjFx9nEOy6OE8H 9Tdqn+ootdizWGQ+98sHT9Cw7nXL+W4awFb8b5CUPYnOc/JIp161q/08bWUSA42qMnAJWe VQeGu+XLoDnbGLSrZVIgDWiMIIzJPVg= X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: 70AD914000A Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=EloZHChU; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf23.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.175 as permitted sender) smtp.mailfrom=keescook@chromium.org X-Stat-Signature: wcm5u4afgfeuw4okqnnikcthq7ny73g4 X-HE-Tag: 1664152731-705385 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Sep 24, 2022 at 10:15:18AM +0200, Dmitry Vyukov wrote: > On Fri, 23 Sept 2022 at 22:28, Kees Cook wrote: > > > > In preparation for no longer unpoisoning in ksize(), remove the behavioral > > self-tests for ksize(). > > > > [...] > > -/* Check that ksize() makes the whole object accessible. */ > > -static void ksize_unpoisons_memory(struct kunit *test) > > -{ > > - char *ptr; > > - size_t size = 123, real_size; > > - > > - ptr = kmalloc(size, GFP_KERNEL); > > - KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr); > > - real_size = ksize(ptr); > > - > > - OPTIMIZER_HIDE_VAR(ptr); > > - > > - /* This access shouldn't trigger a KASAN report. */ > > - ptr[size] = 'x'; > > I would rather keep the tests and update to the new behavior. We had > bugs in ksize, we need test coverage. > I assume ptr[size] access must now produce an error even after ksize. Good point on all these! I'll respin. -- Kees Cook