From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF405C6FA82 for ; Fri, 23 Sep 2022 13:35:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61B1980009; Fri, 23 Sep 2022 09:35:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CAA180007; Fri, 23 Sep 2022 09:35:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4920E80009; Fri, 23 Sep 2022 09:35:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3706580007 for ; Fri, 23 Sep 2022 09:35:16 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 04577120C08 for ; Fri, 23 Sep 2022 13:35:15 +0000 (UTC) X-FDA: 79943446632.23.F8CA175 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [193.142.43.52]) by imf05.hostedemail.com (Postfix) with ESMTP id 7C94E10001C for ; Fri, 23 Sep 2022 13:35:15 +0000 (UTC) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1obipk-0005LV-7v; Fri, 23 Sep 2022 15:35:12 +0200 Date: Fri, 23 Sep 2022 15:35:12 +0200 From: Florian Westphal To: Michal Hocko Cc: Florian Westphal , linux-mm@kvack.org, linux-kernel@vger.kernel.org, vbabka@suse.cz, akpm@linux-foundation.org, urezki@gmail.com, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Martin Zaharinov Subject: Re: [PATCH mm] mm: fix BUG with kvzalloc+GFP_ATOMIC Message-ID: <20220923133512.GE22541@breakpoint.cc> References: <20220923103858.26729-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663940115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f1ORL77O/dZfnCu8ttWy1zNQrVCiLT9W7753PcfIhFc=; b=O8se71kw9MAkCLsJaxWfa104LzUEW7GUfeaxXdXi5v11ad59B/DQrXrvn2UM/03y+sKAQC m9PAmAmhgl5C+Zoo6kWQYTgUTh4fZvhgb0JQLPZayZXuqMpE9dBj20YCxpUZ9qfDW2KhfG 6L8MGakDi2dWep+ZscCndtQXQjvtmyY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of fw@strlen.de designates 193.142.43.52 as permitted sender) smtp.mailfrom=fw@strlen.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663940115; a=rsa-sha256; cv=none; b=RPRC+UQ0iRq5f0eD4na8CiUEQ2r4eLZYud3mSaX4iflZ4eyXpXwNECpfVblC5xcDDaA0UN QmUfYabKFzbbrLVNbEzw/kJIAk0sEeBavGOBYXO480+Lifwfw5RiMXqKW9AjM5yT9rIjMl xDx6i544CN4IuAYHvZl1SNFxZPPZS7A= X-Stat-Signature: e9qfu896ytg5pgg6pyxt1nbhczath958 X-Rspamd-Queue-Id: 7C94E10001C X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of fw@strlen.de designates 193.142.43.52 as permitted sender) smtp.mailfrom=fw@strlen.de X-Rspamd-Server: rspam03 X-HE-Tag: 1663940115-284933 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Michal Hocko wrote: > On Fri 23-09-22 12:38:58, Florian Westphal wrote: > > Martin Zaharinov reports BUG() in mm land for 5.19.10 kernel: > > kernel BUG at mm/vmalloc.c:2437! > > invalid opcode: 0000 [#1] SMP > > CPU: 28 PID: 0 Comm: swapper/28 Tainted: G W O 5.19.9 #1 > > [..] > > RIP: 0010:__get_vm_area_node+0x120/0x130 > > __vmalloc_node_range+0x96/0x1e0 > > kvmalloc_node+0x92/0xb0 > > bucket_table_alloc.isra.0+0x47/0x140 > > rhashtable_try_insert+0x3a4/0x440 > > rhashtable_insert_slow+0x1b/0x30 > > [..] > > > > bucket_table_alloc uses kvzallocGPF_ATOMIC). If kmalloc fails, this now > > falls through to vmalloc and hits code paths that assume GFP_KERNEL. > > > > Revert the problematic change and stay with slab allocator. > > Why don't you simply fix the caller? Uh, not following? kvzalloc(GFP_ATOMIC) was perfectly fine, is this illegal again? I can revert 93f976b5190df32793908d49165f78e67fcb66cf instead but that change is from 2018.