From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12341C54EE9 for ; Thu, 22 Sep 2022 16:00:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DB37940008; Thu, 22 Sep 2022 12:00:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98AD36B0072; Thu, 22 Sep 2022 12:00:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82CA7940008; Thu, 22 Sep 2022 12:00:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 762336B0071 for ; Thu, 22 Sep 2022 12:00:30 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 539F5A02DC for ; Thu, 22 Sep 2022 16:00:30 +0000 (UTC) X-FDA: 79940183820.28.B6EA775 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf18.hostedemail.com (Postfix) with ESMTP id F065F1C003E for ; Thu, 22 Sep 2022 16:00:29 +0000 (UTC) Received: by mail-pl1-f181.google.com with SMTP id d24so9199313pls.4 for ; Thu, 22 Sep 2022 09:00:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=e+3VYhs+DuwH7bu+QHtV1rjWq3mJNnHisCvMMFS3bAw=; b=XxhEWZKeaIg8g+YPuHc57mvNIPPhpigg738nM9wsLJjiUYpKwjJNzBKKGjefZOhAzi 0KqHQ1P/cHiMmQgsO3z2jt2+D0oCcG8Ck+pj5sopXZOTE33QKhSQ8Lb6DWDYvG77ZJIc GQLx6jVnYAJuMY3HV3uGUN51p3PNgpWkx9A1M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=e+3VYhs+DuwH7bu+QHtV1rjWq3mJNnHisCvMMFS3bAw=; b=dyTpL7uOv6ejy00YGO/swZAsIHwq+04b2cBHZgp5qaP40DmIWszuLCIurpZBuHLe0B WpUAJHSbV/wbR1UxuR8PMKE+pxpIdJRizKiWv/VqSd36OO7WEbMxOL2CUtntLlrHgDRh eUV6UiBJogy+FGJFaJqwSZg1HOBxM9ioVb2kvuX3iLCu8N6+H+4tAs91L+7Jo+VYGOS7 2qyyGQUCEKPmDQjehqYINUIdLrZsCYfDMpZdnjmqDaWJvhTRD7p/3DQOQ+w56egt52JJ wL9C2ocTsZ95MRPFtxB9cPyowuF7kiV/J6Lc61tUQajdARAdBFsA5WnvHUHYiB+PxFo3 37EA== X-Gm-Message-State: ACrzQf3u/aq09mS37UYhArJ7kDBPTQgP8H+q5XZuUlNQvh+GBqdClFKi fncUAfmbUVplz8FyHP6wW5N7LQ== X-Google-Smtp-Source: AMsMyM6q4mhFYq39gGoVyx6Hnh47y8QFV1PKitfWXVTUQGpGwPy/JbIncPBlq3WqciXD78b9y3HP3A== X-Received: by 2002:a17:90b:164d:b0:202:69b3:1002 with SMTP id il13-20020a17090b164d00b0020269b31002mr4362502pjb.86.1663862428935; Thu, 22 Sep 2022 09:00:28 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id ms3-20020a17090b234300b002005c3d4d4fsm4007085pjb.19.2022.09.22.09.00.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Sep 2022 09:00:28 -0700 (PDT) Date: Thu, 22 Sep 2022 09:00:26 -0700 From: Kees Cook To: "Ruhl, Michael J" Cc: Vlastimil Babka , "linux-wireless@vger.kernel.org" , Feng Tang , "llvm@lists.linux.dev" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , Eric Dumazet , "Nguyen, Anthony L" , "linux-hardening@vger.kernel.org" , Sumit Semwal , "dev@openvswitch.org" , "x86@kernel.org" , "Brandeburg, Jesse" , "intel-wired-lan@lists.osuosl.org" , David Rientjes , Miguel Ojeda , Yonghong Song , Paolo Abeni , "linux-media@vger.kernel.org" , Marco Elver , Josef Bacik , "linaro-mm-sig@lists.linaro.org" , Jakub Kicinski , David Sterba , Joonsoo Kim , Alex Elder , Greg Kroah-Hartman , Nick Desaulniers , "linux-kernel@vger.kernel.org" , "David S. Miller" , Pekka Enberg , Daniel Micay , "netdev@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Andrew Morton , Christian =?iso-8859-1?Q?K=F6nig?= , "linux-btrfs@vger.kernel.org" Subject: Re: [PATCH 07/12] igb: Proactively round up to kmalloc bucket size Message-ID: <202209220859.DA21F91EAE@keescook> References: <20220922031013.2150682-1-keescook@chromium.org> <20220922031013.2150682-8-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=XxhEWZKe; spf=pass (imf18.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663862430; a=rsa-sha256; cv=none; b=MjdYGmzX3BOeLIqFJ37Jz5NTahWqK2XJl6mjpWz7rLO/7lQ/a5ygZCam4SVBtfH24VlMsB HgV9l/0xCh5llaxFAcuyaMsF5vJgySFDsiW3+eK13+DU4TLigk0m24BUk2w9AcXZnjHakQ ByjAqjLMpputb3ioSWiXfxtB2uR1Q0g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663862430; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e+3VYhs+DuwH7bu+QHtV1rjWq3mJNnHisCvMMFS3bAw=; b=vhplKKW91BDT2Etn7f+rXDspaGRU8a9n6ENVkW8tH9WzBv2J1x6F4dufQc3TvDsErhDka3 vsWkgafsBIIO57GcufanRS6EnRiGAi7N1OcOq1cQBv5fHD9BQVLAOYW6HHlrM68o6bT4ol 2SBe1ntptSooJd0g183vrbYvwRRi2OI= Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=XxhEWZKe; spf=pass (imf18.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspam-User: X-Stat-Signature: ybbamkj9drup8ef8e39ja5xjj945jbqe X-Rspamd-Queue-Id: F065F1C003E X-Rspamd-Server: rspam09 X-HE-Tag: 1663862429-606914 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 22, 2022 at 03:56:54PM +0000, Ruhl, Michael J wrote: > >From: dri-devel On Behalf Of Kees Cook > [...] > >diff --git a/drivers/net/ethernet/intel/igb/igb_main.c > >b/drivers/net/ethernet/intel/igb/igb_main.c > >index 2796e81d2726..4d70ee5b0f79 100644 > >--- a/drivers/net/ethernet/intel/igb/igb_main.c > >+++ b/drivers/net/ethernet/intel/igb/igb_main.c > >@@ -1196,6 +1196,7 @@ static int igb_alloc_q_vector(struct igb_adapter > >*adapter, > > > > ring_count = txr_count + rxr_count; > > size = struct_size(q_vector, ring, ring_count); > >+ size = kmalloc_size_roundup(size); > > why not: > > size = kmalloc_size_roundup(struct_size(q_vector, ring, ring_count)); > > ? Sure! I though it might be more readable split up. I will change it. :) -- Kees Cook