From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A06BAC6FA8E for ; Thu, 22 Sep 2022 02:46:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F9BC6B0071; Wed, 21 Sep 2022 22:46:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A99A940007; Wed, 21 Sep 2022 22:46:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0718D6B0073; Wed, 21 Sep 2022 22:46:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E918D6B0071 for ; Wed, 21 Sep 2022 22:46:28 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 734CD1A04AF for ; Thu, 22 Sep 2022 02:46:28 +0000 (UTC) X-FDA: 79938182856.19.ED39547 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf19.hostedemail.com (Postfix) with ESMTP id 1F5DF1A000D for ; Thu, 22 Sep 2022 02:46:27 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1E0FDB833F3; Thu, 22 Sep 2022 02:46:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0DBBC433D6; Thu, 22 Sep 2022 02:46:23 +0000 (UTC) Date: Wed, 21 Sep 2022 22:47:25 -0400 From: Steven Rostedt To: Bagas Sanjaya Cc: Jonathan Corbet , Yoann Congal , linux-doc@vger.kernel.org, Masami Hiramatsu , Andrew Morton , Linux-MM Subject: Re: [PATCH RESEND] Documentation: kprobetrace: Improve readability Message-ID: <20220921224725.618283bc@gandalf.local.home> In-Reply-To: <81cae8f1-67e9-37ba-4bfd-566c877944ca@gmail.com> References: <20220915153358.813993-1-yoann.congal@smile.fr> <87r104tr6o.fsf@meer.lwn.net> <81cae8f1-67e9-37ba-4bfd-566c877944ca@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663814788; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fKGuIi9Vsjx4PdGjl6qYnXK4fW6QZHVxp5ynIn2/73E=; b=7131bh9p3dYZL0KtrUGxzHmg6jYuGtSM7ryLjYSOL6enOiNVM5bxjCbwolCohQt7wF2uxg a9xS+DU9lRjFbgNtmXVLaJ7PVjimsR10xHsEJPZEQ3GJIeyHiaxCh3s+/Koc9YdYZ9MWzr 3G26/3fjKLDaGOCCga6HCBDTMU5Vl8E= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of "SRS0=Dvff=ZZ=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=Dvff=ZZ=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663814788; a=rsa-sha256; cv=none; b=3xV+Y8ib0aw74e8MsyC3lT1B42uHF29Gc93uDZf/d9LcDC/vBYrdv7Og3ezprMAQcMKBqM pAx6zwORLowD4OLiwHaJfdzmaxQnLFAA0/HGRLt4AqDo8cr3xF78SEMGjbxSvx7EZSOkSZ fAO8dsJBIEJE3Z20Nxo6iMn73RP+SBc= Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of "SRS0=Dvff=ZZ=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=Dvff=ZZ=goodmis.org=rostedt@kernel.org" X-Stat-Signature: 63hrr46g8px5ry6zz8bxfqa9o31su8mf X-Rspamd-Queue-Id: 1F5DF1A000D X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1663814787-548816 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 22 Sep 2022 09:13:08 +0700 Bagas Sanjaya wrote: > On 9/22/22 03:20, Jonathan Corbet wrote: > > Yoann Congal writes: > > > >> Improve readability of kprobetrace documentation by adding markup > >> (mainly code snippets), fixing some typos and splitting some paragraphs. > >> > >> Signed-off-by: Yoann Congal > >> --- > >> Documentation/trace/kprobetrace.rst | 128 ++++++++++++++-------------- > >> 1 file changed, 66 insertions(+), 62 deletions(-) > > > > A couple of comments here. > > > > - There's enough in this patch that I think one of the relevant > > maintainers should have a look. MAINTAINERS is silent on who is > > responsible for this file, so I've CC'd a couple of likely suspects. > > > > Hi jon, > > I think this is Andrew Morton is also likely candidate for reviewing this > (maintainer of last resort). CC'ing him and linux-mm people. > No. This file belongs to the tracing maintainers (I'll need to update the MAINTAINERS file, thanks Jon for letting me know). And yes, there's too much markup added to it. NACK on that. But there are some other clean ups in that patch that I have no problem with. -- Steve