Re: [PATCH RESEND] Documentation: kprobetrace: Improve readability

Re: [PATCH RESEND] Documentation: kprobetrace: Improve readability

[Bagas Sanjaya]

On 9/22/22 03:20, Jonathan Corbet wrote:
> Yoann Congal <yoann.congal@smile.fr> writes:
> 
>> Improve readability of kprobetrace documentation by adding markup
>> (mainly code snippets), fixing some typos and splitting some paragraphs.
>>
>> Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
>> ---
>>  Documentation/trace/kprobetrace.rst | 128 ++++++++++++++--------------
>>  1 file changed, 66 insertions(+), 62 deletions(-)
> 
> A couple of comments here.
> 
> - There's enough in this patch that I think one of the relevant
>   maintainers should have a look.  MAINTAINERS is silent on who is
>   responsible for this file, so I've CC'd a couple of likely suspects.
> 

Hi jon,

I think this is Andrew Morton is also likely candidate for reviewing this
(maintainer of last resort). CC'ing him and linux-mm people.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Re: [PATCH RESEND] Documentation: kprobetrace: Improve readability

[Steven Rostedt]

On Thu, 22 Sep 2022 09:13:08 +0700
Bagas Sanjaya <bagasdotme@gmail.com> wrote:

> On 9/22/22 03:20, Jonathan Corbet wrote:
> > Yoann Congal <yoann.congal@smile.fr> writes:
> >   
> >> Improve readability of kprobetrace documentation by adding markup
> >> (mainly code snippets), fixing some typos and splitting some paragraphs.
> >>
> >> Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
> >> ---
> >>  Documentation/trace/kprobetrace.rst | 128 ++++++++++++++--------------
> >>  1 file changed, 66 insertions(+), 62 deletions(-)  
> > 
> > A couple of comments here.
> > 
> > - There's enough in this patch that I think one of the relevant
> >   maintainers should have a look.  MAINTAINERS is silent on who is
> >   responsible for this file, so I've CC'd a couple of likely suspects.
> >   
> 
> Hi jon,
> 
> I think this is Andrew Morton is also likely candidate for reviewing this
> (maintainer of last resort). CC'ing him and linux-mm people.
> 

No. This file belongs to the tracing maintainers (I'll need to update the
MAINTAINERS file, thanks Jon for letting me know).

And yes, there's too much markup added to it.

NACK on that.

But there are some other clean ups in that patch that I have no problem
with.

-- Steve