From: Mel Gorman <mgorman@techsingularity.net>
To: Hongchen Zhang <zhanghongchen@loongson.cn>
Cc: Mel Gorman <mgorman@suse.de>,
Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vmscan: don't scan adjust too much if current is not kswapd
Date: Wed, 21 Sep 2022 10:13:03 +0100 [thread overview]
Message-ID: <20220921091303.hihmb3qvfvl3s365@techsingularity.net> (raw)
In-Reply-To: <c3f4d1bb-418c-fbf5-c251-fd448f4d4e86@loongson.cn>
On Tue, Sep 20, 2022 at 10:23:05AM +0800, Hongchen Zhang wrote:
> Hi Mel,
>
> The scan adjust algorithm was originally introduced by you from
> commmit e82e0561dae9 ("mm: vmscan: obey proportional scanning requirements
> for kswapd"), any suggestion about this fix patch?
> In short, proportional scanning is not friendly to processes other than
> kswapd.
>
I suspect that 6eb90d649537 ("mm: vmscan: fix extreme overreclaim and swap
floods") is a more appropriate fix. While it also has a fairness impact,
it's a more general approach that is likely more robust and while
fairness is important, completely thrashing a full LRU is neither fair
nor expected.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2022-09-21 9:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 2:33 Hongchen Zhang
2022-09-14 22:51 ` Andrew Morton
2022-09-14 23:02 ` Matthew Wilcox
2022-09-15 1:19 ` Hongchen Zhang
2022-09-15 7:28 ` Matthew Wilcox
2022-09-15 8:02 ` Hongchen Zhang
2022-09-15 9:00 ` Matthew Wilcox
2022-09-15 9:30 ` Hongchen Zhang
2022-09-16 0:57 ` Hongchen Zhang
2022-09-16 8:40 ` Matthew Wilcox
2022-09-16 10:19 ` Hongchen Zhang
2022-09-19 23:32 ` Yosry Ahmed
2022-09-20 5:53 ` Hongchen Zhang
2022-09-20 2:23 ` Hongchen Zhang
2022-09-21 9:13 ` Mel Gorman [this message]
2022-09-21 10:14 ` Hongchen Zhang
2022-09-15 13:38 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220921091303.hihmb3qvfvl3s365@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=willy@infradead.org \
--cc=zhanghongchen@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox