From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F44C54EE9 for ; Tue, 20 Sep 2022 16:43:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1BA1940008; Tue, 20 Sep 2022 12:43:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCBC2940007; Tue, 20 Sep 2022 12:43:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9296940008; Tue, 20 Sep 2022 12:43:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9B5C3940007 for ; Tue, 20 Sep 2022 12:43:37 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6E546160325 for ; Tue, 20 Sep 2022 16:43:37 +0000 (UTC) X-FDA: 79933034874.22.1E3E2C8 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf20.hostedemail.com (Postfix) with ESMTP id C6D1A1C001F for ; Tue, 20 Sep 2022 16:43:36 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 49F75B82B04; Tue, 20 Sep 2022 16:43:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69005C433D6; Tue, 20 Sep 2022 16:43:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663692214; bh=IplAMBKOu/DwLwd5Y8rhPLP0bAx8c+66+j6Ae10JGuc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fYzQyfrJS3Js0r1ARmXCwLLtM+lRrJ4Pc+tMOjVQNNxH2Y1oSFA2li8Znn+PgvM9x kN/zzUl/3GelMSRbzYVEdcrIhpyipeAbdlsTraitVnpNccvuNf5eWAf9FZpA+yoyVU DpHgpTZLri5jPHBck9KHf20G4+t7hyzk6ToYRDx5exDnKYT61rX9Ucyhdh3EICYGvq ERHfjSXxhnOvfFzaMwkGTRJ+Jxemvs1Ssp4mrljGqB7LEAu/jRHq1HeOR2ga6CLrYB oCUOHAPhpsJ7BeVrT8r+/rntXY3JiaW/enHjaXddvU2YiwFew5LvhQshKYuUgjO6dt rB4Fuk8ct04yg== From: SeongJae Park To: xiakaixu1987@gmail.com Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH v2] mm/damon: deduplicate damon_{reclaim,lru_sort}_apply_parameters() Date: Tue, 20 Sep 2022 16:43:31 +0000 Message-Id: <20220920164331.59056-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1663645461-21084-1-git-send-email-kaixuxia@tencent.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663692217; a=rsa-sha256; cv=none; b=51zHTRQY0oPb9UjdU2d0/F2zJbCjBt6ZmYuacN00goLJeBrb6qnDfRwjn0uv9oyYRaPLdd ThSlv7EbjJQFj8Jv0hs6ODCGTMExHQy3mOAnS4ZP7BJcIqrsNOkI0gdwm9woU0/jfH1gHJ IKbxUx918qs8bIvdcJxhGgdaaqGLL2s= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fYzQyfrJ; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663692217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=okMWwzgzMb1glXt5PdcS2CsPPUN38l3XBJOnp+/a8Rk=; b=DqKe8OiL4A402oWfTbgmE7qIZENllpMo4WCIupGO4RxSF4kJY+uuZ2XDFZnlcRv+ZWBzDR PMI71J4MvIKA2Lp22P3xQ4IdtYNleGhxT1xOxdewOHRxzY/oCjJ9OwR5lhkheIW02oGLHt INxPYZ4IbXIskokeRxk+3Qz1K+K65ok= X-Stat-Signature: hcfbfzibfh88gkg1gecxx63tg15h9859 X-Rspamd-Queue-Id: C6D1A1C001F Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fYzQyfrJ; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1663692216-966542 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kaixu, On Tue, 20 Sep 2022 11:44:21 +0800 xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > The bodies of damon_{reclaim,lru_sort}_apply_parameters() contain > duplicates. This commit add a common function s/add/adds/ > damon_set_region_biggest_system_ram_default() to removes the s/removes/remove/ > duplicates. > > Signed-off-by: Kaixu Xia > Suggested-by: SeongJae Park > --- > v2: > -change the common function name and add kernel comment. Adding a link to the previous version of the patch here would be very helpful for me. Could you please do so from next time? > > include/linux/damon.h | 3 ++- > mm/damon/core.c | 35 ++++++++++++++++++++++++++++++++++- > mm/damon/lru_sort.c | 13 +++---------- > mm/damon/reclaim.c | 13 +++---------- > 4 files changed, 42 insertions(+), 22 deletions(-) > > diff --git a/include/linux/damon.h b/include/linux/damon.h > index e7808a84675f..ed5470f50bab 100644 > --- a/include/linux/damon.h > +++ b/include/linux/damon.h > @@ -557,7 +557,8 @@ static inline bool damon_target_has_pid(const struct damon_ctx *ctx) > int damon_start(struct damon_ctx **ctxs, int nr_ctxs, bool exclusive); > int damon_stop(struct damon_ctx **ctxs, int nr_ctxs); > > -bool damon_find_biggest_system_ram(unsigned long *start, unsigned long *end); > +int damon_set_region_biggest_system_ram_default(struct damon_target *t, > + unsigned long *start, unsigned long *end); > > #endif /* CONFIG_DAMON */ > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index 9c80c6eb00c2..9e96cb9fb5db 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -1245,7 +1245,8 @@ static int walk_system_ram(struct resource *res, void *arg) > * Find biggest 'System RAM' resource and store its start and end address in > * @start and @end, respectively. If no System RAM is found, returns false. > */ > -bool damon_find_biggest_system_ram(unsigned long *start, unsigned long *end) > +static bool damon_find_biggest_system_ram(unsigned long *start, > + unsigned long *end) > > { > struct damon_system_ram_region arg = {}; > @@ -1259,6 +1260,38 @@ bool damon_find_biggest_system_ram(unsigned long *start, unsigned long *end) > return true; > } > > +/* > + * damon_set_region_biggest_system_ram_default() - Set the region of the given > + * monitoring target as requested, or biggest 'System RAM'. > + * @t: The monitoring target to set the region. > + * @start: The pointer to the start address of the region. > + * @end: The pointer to the end address of the region. > + * > + * This function sets the region of @t as requested by @start and @end. If the > + * values of the two pointers are pointing to are zero, however, this function > + * finds the biggest 'System RAM' resource and set the region to cover the s/set/sets/ > + * resource. In the latter case, this function saves the start and end address s/address/addresses/ > + * of the resource in @start and @end, respectively. > + * > + * Return: 0 on success, negative error code otherwise. > + */ > +int damon_set_region_biggest_system_ram_default(struct damon_target *t, > + unsigned long *start, unsigned long *end) > +{ > + struct damon_addr_range addr_range; > + > + if (*start > *end) > + return -EINVAL; > + > + if (!*start && !*end && > + !damon_find_biggest_system_ram(start, end)) > + return -EINVAL; > + > + addr_range.start = *start; > + addr_range.end = *end; > + return damon_set_regions(t, &addr_range, 1); > +} > + > static int __init damon_init(void) > { > damon_region_cache = KMEM_CACHE(damon_region, 0); > diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c > index d7eb72b41cb6..efbc2bda8b9c 100644 > --- a/mm/damon/lru_sort.c > +++ b/mm/damon/lru_sort.c > @@ -188,7 +188,6 @@ static struct damos *damon_lru_sort_new_cold_scheme(unsigned int cold_thres) > static int damon_lru_sort_apply_parameters(void) > { > struct damos *scheme; > - struct damon_addr_range addr_range; > unsigned int hot_thres, cold_thres; > int err = 0; > > @@ -211,15 +210,9 @@ static int damon_lru_sort_apply_parameters(void) > return -ENOMEM; > damon_add_scheme(ctx, scheme); > > - if (monitor_region_start > monitor_region_end) > - return -EINVAL; > - if (!monitor_region_start && !monitor_region_end && > - !damon_find_biggest_system_ram(&monitor_region_start, > - &monitor_region_end)) > - return -EINVAL; > - addr_range.start = monitor_region_start; > - addr_range.end = monitor_region_end; > - return damon_set_regions(target, &addr_range, 1); > + return damon_set_region_biggest_system_ram_default(target, > + &monitor_region_start, > + &monitor_region_end); > } > > static int damon_lru_sort_turn(bool on) > diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c > index 3d59ab11b7b3..162c9b1ca00f 100644 > --- a/mm/damon/reclaim.c > +++ b/mm/damon/reclaim.c > @@ -144,7 +144,6 @@ static struct damos *damon_reclaim_new_scheme(void) > static int damon_reclaim_apply_parameters(void) > { > struct damos *scheme; > - struct damon_addr_range addr_range; > int err = 0; > > err = damon_set_attrs(ctx, &damon_reclaim_mon_attrs); > @@ -157,15 +156,9 @@ static int damon_reclaim_apply_parameters(void) > return -ENOMEM; > damon_set_schemes(ctx, &scheme, 1); > > - if (monitor_region_start > monitor_region_end) > - return -EINVAL; > - if (!monitor_region_start && !monitor_region_end && > - !damon_find_biggest_system_ram(&monitor_region_start, > - &monitor_region_end)) > - return -EINVAL; > - addr_range.start = monitor_region_start; > - addr_range.end = monitor_region_end; > - return damon_set_regions(target, &addr_range, 1); > + return damon_set_region_biggest_system_ram_default(target, > + &monitor_region_start, > + &monitor_region_end); > } > > static int damon_reclaim_turn(bool on) > -- > 2.27.0 Other than above mean and trivial comments, Reviewed-by: SeongJae Park As the comments are only for trivial grammar things, I will revise and post one on my own. Thanks, SJ