From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A18AECAAD8 for ; Tue, 20 Sep 2022 12:31:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15CB0940009; Tue, 20 Sep 2022 08:31:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10D57940007; Tue, 20 Sep 2022 08:31:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1720940009; Tue, 20 Sep 2022 08:31:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DFE7F940007 for ; Tue, 20 Sep 2022 08:31:13 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AF779A0BE1 for ; Tue, 20 Sep 2022 12:31:13 +0000 (UTC) X-FDA: 79932398826.17.F1DB35F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf13.hostedemail.com (Postfix) with ESMTP id 2587920033 for ; Tue, 20 Sep 2022 12:31:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9812E1F388; Tue, 20 Sep 2022 12:31:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1663677071; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2bgwVlc2BkS8D3uLS4rTtGU5/zoc+8gMQg61kDwgsDc=; b=g0bRe7BNpMa58aMEDDvC4k26Rb2K9qG08IMSfkDViwdEcsZ0Y68f1DTFtbGCbfCKtsNt/b qiSHicPF/GJWUFY8e1BbmrvXnEfDk6ker/+9sNWSmptaaHhPSnwG2gb1GALZY3vSd5BWuF t+46lF/a+422QvdiBp5dZlza1stp4cU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1663677071; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2bgwVlc2BkS8D3uLS4rTtGU5/zoc+8gMQg61kDwgsDc=; b=4pZqqZIlDzwdzk5g19i+fqVpOgtmoubnTEFilxEvrQzT5ovOtfV2ImqDiXc/+D3umWM/+J kA2qJgaWAZVfzxDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 667D813ABB; Tue, 20 Sep 2022 12:31:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HulmF4+yKWPyWQAAMHmgww (envelope-from ); Tue, 20 Sep 2022 12:31:11 +0000 Date: Tue, 20 Sep 2022 14:25:40 +0200 From: David Sterba To: Stefan Roesch Cc: kernel-team@fb.com, io-uring@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, axboe@kernel.dk, josef@toxicpanda.com, fdmanana@gmail.com Subject: Re: [PATCH v3 00/12] io-uring/btrfs: support async buffered writes Message-ID: <20220920122540.GY32411@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20220912192752.3785061-1-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220912192752.3785061-1-shr@fb.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663677073; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2bgwVlc2BkS8D3uLS4rTtGU5/zoc+8gMQg61kDwgsDc=; b=rcF8rrBXrmrqhbK6XoqPiqhEtKk7JOvak+6xK7l+acQdfPPOGk3VuW0khkcCMSP+tll8UE 9vx49EHMPjRoJirPG2YBMiDTJs9Ja+aE5v+BDG2yQc9+o2epmigbEjFnaNMad6ARMsjnKz O9QdxBUF+F0CVYnFsianSJYtGDMxFnE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=g0bRe7BN; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=4pZqqZIl; spf=pass (imf13.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=dsterba@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663677073; a=rsa-sha256; cv=none; b=MB5JHIfrb2EGGYSTLbOnccNqvTNIUshxa6MS4aSfBPelpIRi/N4UZJ3C6LYWM9fhsFXRdo DYw8o7rsDDbEOpPPKMMfsqHcgiYD882MoYcK8q5x8D28RdBW9bYjDA56qCCMPVWIg+t6ms 1Y6Ecm2+3ytVGr8ZKDihZohg2B2er9c= X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=g0bRe7BN; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=4pZqqZIl; spf=pass (imf13.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=dsterba@suse.cz; dmarc=none X-Rspamd-Server: rspam04 X-Stat-Signature: senkd4cjf4bjwom3fmtfg1ork6t18qfk X-Rspamd-Queue-Id: 2587920033 X-HE-Tag: 1663677072-63014 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 12, 2022 at 12:27:40PM -0700, Stefan Roesch wrote: > This patch series adds support for async buffered writes when using both > btrfs and io-uring. Currently io-uring only supports buffered writes (for btrfs) > in the slow path, by processing them in the io workers. With this patch series > it is now possible to support buffered writes in the fast path. To be able to use > the fast path, the required pages must be in the page cache, the required locks > in btrfs can be granted immediately and no additional blocks need to be read > form disk. > > This patch series makes use of the changes that have been introduced by a > previous patch series: "io-uring/xfs: support async buffered writes" > > Performance results: > > The new patch improves throughput by over two times (compared to the exiting > behavior, where buffered writes are processed by an io-worker process) and also > the latency is considerably reduced. Detailled results are part of the changelog > of the first commit. Thanks. It's late for including this patches to 6.1 queue but it's now in for-next and will be added to misc-next after rc1, targeting merge to 6.2. I did some minor fixups, so please don't resend full series unless there's a significant change. Incremental changes are fine if needed.