From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68D58C54EE9 for ; Tue, 20 Sep 2022 12:13:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0930294000F; Tue, 20 Sep 2022 08:13:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0438A940009; Tue, 20 Sep 2022 08:13:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E748E94000F; Tue, 20 Sep 2022 08:13:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D788E940009 for ; Tue, 20 Sep 2022 08:13:11 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AA649C0DE5 for ; Tue, 20 Sep 2022 12:13:11 +0000 (UTC) X-FDA: 79932353382.20.F4E2D4A Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf26.hostedemail.com (Postfix) with ESMTP id B11B5140020 for ; Tue, 20 Sep 2022 12:13:10 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 2216D68AA6; Tue, 20 Sep 2022 14:13:06 +0200 (CEST) Date: Tue, 20 Sep 2022 14:13:05 +0200 From: Christoph Hellwig To: Liu Shixin Cc: Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kefeng Wang Subject: Re: [PATCH v5 2/5] Revert "frontswap: simplify frontswap_register_ops" Message-ID: <20220920121305.GA4237@lst.de> References: <20220915035003.3347466-1-liushixin2@huawei.com> <20220915035003.3347466-3-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220915035003.3347466-3-liushixin2@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663675991; a=rsa-sha256; cv=none; b=SMLIrFcX/fJB8Vn8wAjJnmUYytZvZsjRvXkylCadzym6x5JNVg1tfrUZ2Vb00179kAem/p mrSGzQ+kyoMt7ZjeKMO1kWr6jhJbaX82UnC6O4b5TZHn9LChJkeRhjC4M+YZ8gEt6+RBrW 1VP00fzpMPfOuP8ayDiGbvTTTCwzk9I= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=none (imf26.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663675991; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WnF/1Dtk0+9PQvq+aewDI6qbT4DPlncu6uatHYC/kiE=; b=OGrb96tsyvnqsw4xDMPg8EjcFxsBnS7NCrFTPncKTQJlnzn4+zCsmFYdazfAbapWJfBeIc xNEWdWadXjcLJnaBcq3RYOO0gd477k7LUIjU/+w1xIFmLUbwzEwvOKIWb7WMzhpQmZSCMB sd4U17pF2RcGr7rG/ziDX8ofq3PAiXw= X-Rspamd-Server: rspam06 X-Rspam-User: X-Stat-Signature: dy46juhrbwz4cajjwikeq5kohkka8cpk X-Rspamd-Queue-Id: B11B5140020 Authentication-Results: imf26.hostedemail.com; dkim=none; spf=none (imf26.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-HE-Tag: 1663675990-743382 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 15, 2022 at 11:50:00AM +0800, Liu Shixin wrote: > This reverts commit f328c1d16e4c764992895ac9c9425cea861b2ca0. > > Since we are supported to delay zswap initializaton, we need to invoke > ops->init for the swap device which is already online when register > backend. Why do we "have" to do it. Retroactively supporting functionality on previously enabled swap devices seems rather odd, and the amount of cruft added for it here absolutely does not seem to be worth it.