From: Mel Gorman <mgorman@techsingularity.net>
To: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Zhaoyang Huang <huangzhaoyang@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
ke.wang@unisoc.com
Subject: Re: [PATCHv2] mm: check high-order page when free it to pcp
Date: Tue, 20 Sep 2022 09:55:02 +0100 [thread overview]
Message-ID: <20220920085437.ngyrzgxe2uoi7g4a@techsingularity.net> (raw)
In-Reply-To: <1663634940-6515-1-git-send-email-zhaoyang.huang@unisoc.com>
On Tue, Sep 20, 2022 at 08:49:00AM +0800, zhaoyang.huang wrote:
> From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
>
> High-order pcp page escaped from checking when both of DEBUG_VM and debug_pagealloc
> are all disabled if it allocated again from pcp_list without going to global
> free list, which should be introduced by 44042b4498.
>
> fix:44042b4498
>
> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
Why is the order check needed? In this case, I think the comment itself was
wrong and should be corrected. free_pcp_prepare is called when dealing with
a PCP page being freed and these days that may order-0 or high-order pages.
Wieh DEBUG_VM disabled, the pages are checked in by bulkfree_pcp_prepare
when freeing pages from PCP to the core allocator. Why would just
high-order pages be checked in free_pcp_prepare and checked again in
bulkfree_pcp_prepare?
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2022-09-20 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 0:49 zhaoyang.huang
2022-09-20 8:55 ` Mel Gorman [this message]
2022-09-20 9:07 ` Zhaoyang Huang
2022-09-20 10:55 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920085437.ngyrzgxe2uoi7g4a@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=huangzhaoyang@gmail.com \
--cc=ke.wang@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox