* Re: [PATCH 5/9] mm/mm_init.c: use hotplug_memory_notifier() directly
[not found] <20220919083152.1824305-6-liushixin2@huawei.com>
@ 2022-09-19 18:54 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-09-19 18:54 UTC (permalink / raw)
To: Liu Shixin, Andrew Morton
Cc: llvm, kbuild-all, Linux Memory Management List, linux-kernel,
Liu Shixin, Kefeng Wang
Hi Liu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on akpm-mm/mm-everything]
url: https://github.com/intel-lab-lkp/linux/commits/Liu-Shixin/mm-Use-hotplug_memory_notifier-instead-of-register_hotmemory_notifier/20220919-160043
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: arm64-randconfig-r036-20220919 (https://download.01.org/0day-ci/archive/20220920/202209200223.T0pXU4pA-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/33c4e50ed97460db120701f262ae1814509ba982
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Liu-Shixin/mm-Use-hotplug_memory_notifier-instead-of-register_hotmemory_notifier/20220919-160043
git checkout 33c4e50ed97460db120701f262ae1814509ba982
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> mm/mm_init.c:184:26: error: expected identifier or '('
hotplug_memory_notifier(&mm_compute_batch_notifier, IPC_CALLBACK_PRI);
^
>> mm/mm_init.c:184:2: error: use of undeclared identifier 'mm_compute_batch_notifier_mem_nb'
hotplug_memory_notifier(&mm_compute_batch_notifier, IPC_CALLBACK_PRI);
^
include/linux/memory.h:167:28: note: expanded from macro 'hotplug_memory_notifier'
register_memory_notifier(&fn##_mem_nb); \
^
<scratch space>:31:1: note: expanded from here
mm_compute_batch_notifier_mem_nb
^
2 errors generated.
vim +184 mm/mm_init.c
180
181 static int __init mm_compute_batch_init(void)
182 {
183 mm_compute_batch(sysctl_overcommit_memory);
> 184 hotplug_memory_notifier(&mm_compute_batch_notifier, IPC_CALLBACK_PRI);
185 return 0;
186 }
187
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] only message in thread