From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4ED3ECAAA1 for ; Mon, 19 Sep 2022 18:55:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0477F940007; Mon, 19 Sep 2022 14:55:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F37846B0072; Mon, 19 Sep 2022 14:55:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFEED940007; Mon, 19 Sep 2022 14:55:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D021E6B0071 for ; Mon, 19 Sep 2022 14:55:17 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9E7791C5ED2 for ; Mon, 19 Sep 2022 18:55:17 +0000 (UTC) X-FDA: 79929737874.12.05A0654 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf17.hostedemail.com (Postfix) with ESMTP id DBDFC40022 for ; Mon, 19 Sep 2022 18:55:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663613715; x=1695149715; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=i+aEGsVW1WXRn39/yQinuqupanGyjkup5oZc7L/h3Ts=; b=Mym2OJpik5CjIGXCMGZV6jsmm1j5Mc2uErSm+z6KmDCU+a0xZxc9sjG/ oldCGoo9G+4e55nsQaJJKerpS6DkAo2anzEU0R7gDQxBHGWCDjuDipKQm X2TkaWlnZd1z1KodkbFO1OomUwGvfjeThc/F2q90x7f6yWErmIzKy7rJi DUv5VXJ4flC2q8xdWkuFoTFQsEWtMKFgUTw9pvAFk3LBbuevFsCoUUZIN Jq/5v9+hrNxEO4Kr2NVH49Lt3mu3DAZq6wnkEFO35y1G5PvQo8MG4YDVz yAPo7iDx+2NjoqAMiuIGg6FE+xpXfnmczvhKMN0ECPobCelEHm7bhDwvq w==; X-IronPort-AV: E=McAfee;i="6500,9779,10475"; a="297084636" X-IronPort-AV: E=Sophos;i="5.93,328,1654585200"; d="scan'208";a="297084636" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2022 11:55:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,328,1654585200"; d="scan'208";a="651797465" Received: from lkp-server01.sh.intel.com (HELO c0a60f19fe7e) ([10.239.97.150]) by orsmga001.jf.intel.com with ESMTP; 19 Sep 2022 11:55:11 -0700 Received: from kbuild by c0a60f19fe7e with local (Exim 4.96) (envelope-from ) id 1oaLvC-0002BB-0M; Mon, 19 Sep 2022 18:55:10 +0000 Date: Tue, 20 Sep 2022 02:54:50 +0800 From: kernel test robot To: Liu Shixin , Andrew Morton Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List , linux-kernel@vger.kernel.org, Liu Shixin , Kefeng Wang Subject: Re: [PATCH 5/9] mm/mm_init.c: use hotplug_memory_notifier() directly Message-ID: <202209200223.T0pXU4pA-lkp@intel.com> References: <20220919083152.1824305-6-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220919083152.1824305-6-liushixin2@huawei.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663613716; a=rsa-sha256; cv=none; b=ImOaGUW0/KZ2awl9ccvTmtFrqODEbb0jHfhw75j6yL0mFlTKxeq8ucVQvtkdJzO1+I5Sjw 9DCKvuDZuV4VcEU5oniLeJgqbB2aF+bo3juQpC/seWWz1J1D6wj6ZG7cPc2xXcTrvyxBws mLWPV5hz2OIMFnN3GICOe156mOUcIQA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Mym2OJpi; spf=pass (imf17.hostedemail.com: domain of lkp@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663613716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RDPSzb1Nap7EmVwzrkrQ0B6vGIA30pMDykCtWpJpSwo=; b=mT1n45zsP2Scm573SFzxnmpIaqwD0+s4dwxR7IEInfcPjcK0XqqWG6/3ZCnsn1nBZAPivb iyKGaUl1XU9wouwHc/XxnZVQnqli52NPcwmNj/zNNg/k//jSkTqg5LDWXcezieHiFDcTP8 v8LdxebtI0Y8UcYe1/wb9xFN/bBQUgo= X-Stat-Signature: 5y97a3s9a3gnpazbj6cpga33cqzq98jg X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Mym2OJpi; spf=pass (imf17.hostedemail.com: domain of lkp@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: DBDFC40022 X-HE-Tag: 1663613715-432543 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Liu, Thank you for the patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Liu-Shixin/mm-Use-hotplug_memory_notifier-instead-of-register_hotmemory_notifier/20220919-160043 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything config: arm64-randconfig-r036-20220919 (https://download.01.org/0day-ci/archive/20220920/202209200223.T0pXU4pA-lkp@intel.com/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/33c4e50ed97460db120701f262ae1814509ba982 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Liu-Shixin/mm-Use-hotplug_memory_notifier-instead-of-register_hotmemory_notifier/20220919-160043 git checkout 33c4e50ed97460db120701f262ae1814509ba982 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): >> mm/mm_init.c:184:26: error: expected identifier or '(' hotplug_memory_notifier(&mm_compute_batch_notifier, IPC_CALLBACK_PRI); ^ >> mm/mm_init.c:184:2: error: use of undeclared identifier 'mm_compute_batch_notifier_mem_nb' hotplug_memory_notifier(&mm_compute_batch_notifier, IPC_CALLBACK_PRI); ^ include/linux/memory.h:167:28: note: expanded from macro 'hotplug_memory_notifier' register_memory_notifier(&fn##_mem_nb); \ ^ :31:1: note: expanded from here mm_compute_batch_notifier_mem_nb ^ 2 errors generated. vim +184 mm/mm_init.c 180 181 static int __init mm_compute_batch_init(void) 182 { 183 mm_compute_batch(sysctl_overcommit_memory); > 184 hotplug_memory_notifier(&mm_compute_batch_notifier, IPC_CALLBACK_PRI); 185 return 0; 186 } 187 -- 0-DAY CI Kernel Test Service https://01.org/lkp