From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40DFAECAAD3 for ; Mon, 19 Sep 2022 17:03:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA3326B0073; Mon, 19 Sep 2022 13:03:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2BB86B0074; Mon, 19 Sep 2022 13:03:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F3C06B0075; Mon, 19 Sep 2022 13:03:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7D3BE6B0073 for ; Mon, 19 Sep 2022 13:03:09 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3F25CA039D for ; Mon, 19 Sep 2022 17:03:09 +0000 (UTC) X-FDA: 79929455298.28.74B8B82 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id E8927200AB for ; Mon, 19 Sep 2022 17:03:08 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1C88A61E1A; Mon, 19 Sep 2022 17:03:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E557C433D6; Mon, 19 Sep 2022 17:03:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663606987; bh=NUfm1ogzfA53a+kYpQi40Xi8gg99UIL8Bf979QIs08Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RLGM3xcHH6VeNaVsiHjRsajiqehzhbCFNE4XE8Cm9Pp1WA+OroPcxpRm5Rok7flF1 6qA/MRW/NQwdDF8QFg6mzVjsk11tw3XtWoR+nwMKbX1Cs+fVBOT0rOdAHgj70mxML4 wPBlbyIDfuziNhh4jaha9LXQei3QGQRAM+cz39IDHzdmz16oUjoQg7veraJfk6G5oG Rkb9Rgaeh3DSgvKdLa4NPwV0TMYCd5bzAfc8iafWW8o64P3IXbLZ2DHLQrOTRgNZ7f GenpOKPA8mak+9H0ywUEy3Txra4O+eKK0sSj/GEvTP9Xwvm2dBVTpNgC4RviPbnyZu +RCSTpvkKTwEQ== From: SeongJae Park To: Xin Hao Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] mm/damon/sysfs: remove unnecessary variables Date: Mon, 19 Sep 2022 17:03:05 +0000 Message-Id: <20220919170305.61335-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220919151201.66696-1-xhao@linux.alibaba.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663606988; a=rsa-sha256; cv=none; b=pkJJCconELcFU8OHaDneoAvNYGVmZ9tsxksjCrP9bB86qrEO+Lu6UPvoUyPRjdtocaClsj hD+13osRTGstqa7pOP7Zjg1iwt9Gm7igUUCOCPoo0HAXkqupYSX/5npLJjzc8PO0f0xs9e w4eULU/2sXzw9f0mh7HVrqSlsqVpwuI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RLGM3xcH; spf=pass (imf03.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663606988; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aAKzQbpRuc5y/ZX39Zn3Uocc8+yPEFP/DXflI8+azhI=; b=hzpK9cddyDwFl7Fv8k4VEv3YisOPU/DtXOOKdT/kqJbk/Wj/SSn5zgCI0VkhRZWyC6VBU3 Ft2jnAWxox7J7vK7H+mtjw2bnr+xad4YI63DX3q43ej2lSunLjWQ9ocRDquQcvV7xSPbTM UXfP8O25jLj8MtOS+T7UkWZm1gJv3r0= X-Rspamd-Queue-Id: E8927200AB X-Rspamd-Server: rspam05 X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RLGM3xcH; spf=pass (imf03.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: bb6e1n4eonr3dsg76pmrk79esyo617uz X-HE-Tag: 1663606988-763426 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 19 Sep 2022 23:12:00 +0800 Xin Hao wrote: > Just do a little change here, the 'err' variable really no need to stay > here. > > Signed-off-by: Xin Hao > --- > mm/damon/sysfs.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c > index 0cca1909bf67..b852a75b9f39 100644 > --- a/mm/damon/sysfs.c > +++ b/mm/damon/sysfs.c > @@ -1109,9 +1109,8 @@ static ssize_t start_store(struct kobject *kobj, struct kobj_attribute *attr, > { > struct damon_sysfs_region *region = container_of(kobj, > struct damon_sysfs_region, kobj); > - int err = kstrtoul(buf, 0, ®ion->start); > > - if (err) > + if (kstrtoul(buf, 0, ®ion->start)) > return -EINVAL; Good finding. But, I'd like to let the user know why it really fails by giving them the error code that returned by 'kstrtoul()' here. Let's keep the 'err' but return 'err' here. > return count; > } > @@ -1130,9 +1129,8 @@ static ssize_t end_store(struct kobject *kobj, struct kobj_attribute *attr, > { > struct damon_sysfs_region *region = container_of(kobj, > struct damon_sysfs_region, kobj); > - int err = kstrtoul(buf, 0, ®ion->end); > > - if (err) > + if (kstrtoul(buf, 0, ®ion->end)) > return -EINVAL; ditto. > return count; > } > -- > 2.31.0 Thanks, SJ