From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9D56C54EE9 for ; Mon, 19 Sep 2022 15:45:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 640716B0071; Mon, 19 Sep 2022 11:45:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EF076B0072; Mon, 19 Sep 2022 11:45:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 506C2940007; Mon, 19 Sep 2022 11:45:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3D51E6B0071 for ; Mon, 19 Sep 2022 11:45:40 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 149D71406C3 for ; Mon, 19 Sep 2022 15:45:40 +0000 (UTC) X-FDA: 79929260040.12.D55D4AD Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf05.hostedemail.com (Postfix) with ESMTP id 58E2D100019 for ; Mon, 19 Sep 2022 15:45:39 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id DDEA568BEB; Mon, 19 Sep 2022 17:45:33 +0200 (CEST) Date: Mon, 19 Sep 2022 17:45:33 +0200 From: Christoph Hellwig To: David Sterba Cc: Christoph Hellwig , Jens Axboe , Matthew Wilcox , Johannes Weiner , Suren Baghdasaryan , Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-mm@kvack.org Subject: Re: improve pagecache PSI annotations v2 Message-ID: <20220919154533.GA710@lst.de> References: <20220915094200.139713-1-hch@lst.de> <20220915130138.GO32411@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220915130138.GO32411@suse.cz> User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663602339; a=rsa-sha256; cv=none; b=6rjG05jeqiNVOgMOyc2miDlTehvHf18gEgc6uwFfY57kn/Bui9k71euc+z5NSklJml+Der C6gWCziKO5ieYGzbOsBGveLr60imPrEaRVRBfCTEKtdRFaPQVnBHZh1X7qtG0vxgSkJmJo Iabj1PZh7ZzNACBQ/7Al5Q4naqArAgc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=none (imf05.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663602339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d/VWlWsqSUKUkjypQ5lzt8r8rIUoqV86NNPSOu+4NBo=; b=XH4lT0t+zTRjt9/7U/UgbfsNpYLGmKVpMBj68A1KDq0m4DtWED+mpKvgftRfCxn1xCw+pW GnarO6/O5uM7gK1hWFVzgQT6lr9XCTwG+L80z4F9s+aDXhnTGumMT8gKZptJuF2BI3Mkq2 1/32aQkm7X/N/+1TyUTKvvWL5ZnaBgA= X-Rspamd-Queue-Id: 58E2D100019 X-Rspamd-Server: rspam05 X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=none; spf=none (imf05.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Stat-Signature: b7wmo1ctznusb4pqroi86cyjh4dk5bz8 X-HE-Tag: 1663602339-299927 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 15, 2022 at 03:01:38PM +0200, David Sterba wrote: > On Thu, Sep 15, 2022 at 10:41:55AM +0100, Christoph Hellwig wrote: > > > > - spell a comment in the weird way preferred by btrfs maintainers > > What? A comment is a standalone sentence or a full paragraph, so it's > formatted as such. I hope it's not weird to expect literacy either in > the language of comments or the programming language. The same style can > be found in many other kernel parts so please stop the nags at btrfs. That is not what most of the kernel seems to think. The usual style is to have multi-line comments start with a capitalized word and end with a dot and thus form one or more complete sentences, but single line comments most of the time do not form complete sentences and thus do not start with a capitalized word and do not end with a dot.