From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D0DDC54EE9 for ; Mon, 19 Sep 2022 10:42:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66BA9940007; Mon, 19 Sep 2022 06:42:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 61B046B0073; Mon, 19 Sep 2022 06:42:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BB68940007; Mon, 19 Sep 2022 06:42:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 38A4C6B0072 for ; Mon, 19 Sep 2022 06:42:23 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0BE10808F6 for ; Mon, 19 Sep 2022 10:42:23 +0000 (UTC) X-FDA: 79928495766.26.ECE267D Received: from outbound-smtp23.blacknight.com (outbound-smtp23.blacknight.com [81.17.249.191]) by imf07.hostedemail.com (Postfix) with ESMTP id 7214940015 for ; Mon, 19 Sep 2022 10:42:22 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail02.blacknight.ie [81.17.254.11]) by outbound-smtp23.blacknight.com (Postfix) with ESMTPS id 171F1BECF3 for ; Mon, 19 Sep 2022 11:42:21 +0100 (IST) Received: (qmail 11852 invoked from network); 19 Sep 2022 10:42:20 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 19 Sep 2022 10:42:20 -0000 Date: Mon, 19 Sep 2022 11:42:14 +0100 From: Mel Gorman To: "zhaoyang.huang" Cc: Andrew Morton , Zhaoyang Huang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Subject: Re: [PATCH] mm: check high-order page when free it to pcp Message-ID: <20220919104158.6vbzmzxk2dy6tu6w@techsingularity.net> References: <1663559238-22918-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1663559238-22918-1-git-send-email-zhaoyang.huang@unisoc.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663584142; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0PYbdglgTDEHj6N4b7YVGqncgauXNIm0qwGJaBgXzVk=; b=OMS9mRnSmGHr5RVHMHuOImsH0Tjtnh5ELyAM4l7JJU7BOm3aagjdj51Tc4ERKstIpXJpik eRwl8DBL9gMQjEkDRBvHmEF5/OCZN4t+a7h+ID2DXGlrhtbvQCMUMphLt7w2KN8dC3we6O /InqKsLYJ//U6rPow/HVGIsvq2ClDIc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.191 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663584142; a=rsa-sha256; cv=none; b=x9+fzTgITFzG+k9HTSJQmYeDJcKw/vdrR9To/8SQC3aUcymxhqTISDt24g+3YcKEQCUROS 4D2u4Pg3uAXyoXW8mz1DEMsaidAo69c1dwTg7ubGzpJU27o2fm90EjZ79Bqm8NxnYqFmGz 8oc0ifFf+OYn6xM7zBmdSHiIHpgi9SQ= Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.191 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net X-Rspam-User: X-Stat-Signature: uckicxge8bt1an5y5841birnptis9eu7 X-Rspamd-Queue-Id: 7214940015 X-Rspamd-Server: rspam12 X-HE-Tag: 1663584142-808680 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 19, 2022 at 11:47:18AM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > High-order pcp page escaped from checking when both of DEBUG_VM and debug_pagealloc > are all disabled if it allocated again from pcp_list without going to global > free list, which should be introduced by 44042b4498. > > fix:44042b4498 > > Signed-off-by: Zhaoyang Huang Is this based on the comment mentioning order-0 pages above free_pcp_prepare()? I ask because the comment is wrong and in both instances should have s/order-0// -- Mel Gorman SUSE Labs