From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43A9CC6FA91 for ; Mon, 19 Sep 2022 10:22:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 357086B0072; Mon, 19 Sep 2022 06:22:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 306466B0073; Mon, 19 Sep 2022 06:22:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21CA0940007; Mon, 19 Sep 2022 06:22:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 13E846B0072 for ; Mon, 19 Sep 2022 06:22:29 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DD7DA1C6573 for ; Mon, 19 Sep 2022 10:22:28 +0000 (UTC) X-FDA: 79928445576.24.148C528 Received: from outbound-smtp43.blacknight.com (outbound-smtp43.blacknight.com [46.22.139.229]) by imf19.hostedemail.com (Postfix) with ESMTP id 709631A000E for ; Mon, 19 Sep 2022 10:22:28 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail02.blacknight.ie [81.17.254.11]) by outbound-smtp43.blacknight.com (Postfix) with ESMTPS id E1FFA20A3 for ; Mon, 19 Sep 2022 11:22:26 +0100 (IST) Received: (qmail 20035 invoked from network); 19 Sep 2022 10:22:26 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 19 Sep 2022 10:22:26 -0000 Date: Mon, 19 Sep 2022 11:16:29 +0100 From: Mel Gorman To: "zhaoyang.huang" Cc: Andrew Morton , Zhaoyang Huang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Subject: Re: [RFC PATCH] mm: check global free_list if there is ongoing reclaiming when pcp fail Message-ID: <20220919101629.xlafi2y2dk357wk3@techsingularity.net> References: <1663325892-9825-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1663325892-9825-1-git-send-email-zhaoyang.huang@unisoc.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663582948; a=rsa-sha256; cv=none; b=gJ+PSRge1tP9ApWcTGpGZ9T1p0+gUeNiFzaMO2Ip5uICV3z2L4fi5uxfn7/n1IwvEZk+23 QNQTFkj4rekXQXfyi553NPl6btDbBV7txUcZWdmf679ww5cMaGsneqK8PFQ772ZeKg7GqY xFSKQRPabQ6+0csmm26YwMXIir0+pac= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.229 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663582948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cABuqXI6y9Nv9kFAvUbHVnhDnfKYCMQl34jhtxnV3zk=; b=bv9Ysh+AOFxt2cz1UMECnHznFuf5SSOsFu+kBNwlw/cbUvpcqA5HuGlb3rYoXa75u57GCY QNyeGi1ttgz6lvWettZ8yzMrYu5x+SaNSsvp3ZK8NJ+4SV1Pe7EzEO4nl9ugNveh3UyBzJ QnQIT7SKTubAG01dv/u40DbQwL9HY6A= Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.229 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none X-Stat-Signature: ebsaa5owrfpc9dmxaireq53fg8yamw7z X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 709631A000E X-HE-Tag: 1663582948-176285 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 16, 2022 at 06:58:12PM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > Check the global free list again even if rmqueue_bulk failed for pcp pages when > there is ongoing reclaiming, which could eliminate potential direct reclaim by > chance. > > Signed-off-by: Zhaoyang Huang Patch does not apply and may be based on a custom kernel that introduced a problem. There is no description of what problem this is trying to fix. Checking the status of reclaim for a specific zone in this path would be a little unexpected. If allocation pressure is exceeding the ability of reclaim to make progress then the caller likely needs to take action like direct reclaim. If the allocation failure is due to a high-order failure then it may need to enter direct compaction etc. -- Mel Gorman SUSE Labs