From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5818FECAAD8 for ; Sun, 18 Sep 2022 23:48:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6DB86B0073; Sun, 18 Sep 2022 19:48:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1D236B0074; Sun, 18 Sep 2022 19:48:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BD7B940007; Sun, 18 Sep 2022 19:48:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8D9E56B0073 for ; Sun, 18 Sep 2022 19:48:02 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5685A4131C for ; Sun, 18 Sep 2022 23:48:02 +0000 (UTC) X-FDA: 79926846804.01.608FFFC Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf18.hostedemail.com (Postfix) with ESMTP id EED861C0006 for ; Sun, 18 Sep 2022 23:48:01 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C8F96B81440; Sun, 18 Sep 2022 23:48:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72798C433D7; Sun, 18 Sep 2022 23:47:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1663544879; bh=vY67OG8eoR8YdkGqIzr2pzMf7eruVoDzLFxpWUVunLU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mWLzwdGPavJaRCPBuB0ig6uWmtcWWLgk2fanliTf4AOlcCPERe4AKC0CuGfdbVl+7 ++FGW3LLrPONgjpM2Ex1SWTniu/dzrynNneb2WncNPA3D4PU1KN42PiLBxs07TLa8P R5CUTiHBpICG6SUNfWh8SJCC7GgpLvqFyXyCj5OM= Date: Sun, 18 Sep 2022 16:47:58 -0700 From: Andrew Morton To: Yu Zhao Cc: linux-mm@kvack.org, Nadav Amit Subject: Re: [PATCH v14-fix 03/11] mm: multi-gen LRU: warn on !ptep_test_and_clear_young() Message-Id: <20220918164758.33759617e769197ea70a2870@linux-foundation.org> In-Reply-To: <20220918204755.3135720-3-yuzhao@google.com> References: <20220918204755.3135720-1-yuzhao@google.com> <20220918204755.3135720-3-yuzhao@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663544882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cdxxm8+AbJP5vQwdjgBoaBXxNQGEH2LEkvPOHa6nSZ4=; b=k9wQRtM9OX6MXdEyAkPjChVg9lLizPdasky6XE1+wmJI7JfD4Ju6f6Tse/Tai28d9gFNVx MCub6Pa4v2G12cI9oWSDznUVWKn3rSVVcQRo/+zB2B0NGaCr+6YWWDQcp10aGvYxYsxWrJ c3xFk4EIc6S2okT/wb1atDLIX41yKZo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=mWLzwdGP; dmarc=none; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663544882; a=rsa-sha256; cv=none; b=W7Tf+ZepfNhEOET4RjAJYWI+OR53+H/xFEVnI7mwrm68d9J41TFCr+z+AwNLdiX0Ph8Red 2kaaZgEhjH+IEGTRZXN+ysU2e8mTAtVxleFsPjvLHsykwGSYZasFz1ewZLy0VcyqIFyoKe pjzUNpZ49g/tGJEzt6evvQNAY1UQrPM= X-Stat-Signature: m39nx96drxns75am579fhza6c1ikxi5p X-Rspamd-Queue-Id: EED861C0006 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=mWLzwdGP; dmarc=none; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1663544881-66713 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 18 Sep 2022 14:47:47 -0600 Yu Zhao wrote: > Link: https://lore.kernel.org/r/0F7CF2A7-F671-4196-B8FD-F35E9556391B@gmail.com/ > Suggested-by: Nadav Amit > Signed-off-by: Yu Zhao > --- > mm/vmscan.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 5c4d9d0867ec..629518813b59 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -3904,7 +3904,7 @@ static bool walk_pte_range(pmd_t *pmd, unsigned long start, unsigned long end, > continue; > > if (!ptep_test_and_clear_young(args->vma, addr, pte + i)) > - continue; > + VM_WARN_ON_ONCE(true); > > young++; > walk->mm_stats[MM_LEAF_YOUNG]++; > @@ -4637,7 +4637,7 @@ void lru_gen_look_around(struct page_vma_mapped_walk *pvmw) > continue; > > if (!ptep_test_and_clear_young(pvmw->vma, addr, pte + i)) > - continue; > + VM_WARN_ON_ONCE(true); > This is a functional change? More than the Subject: describes.