From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3D56C6FA82 for ; Sat, 17 Sep 2022 04:16:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA33A8D0002; Sat, 17 Sep 2022 00:16:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2BEC8D0001; Sat, 17 Sep 2022 00:16:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CDB48D0002; Sat, 17 Sep 2022 00:16:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7E7EC8D0001 for ; Sat, 17 Sep 2022 00:16:00 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4ADB8AB3EE for ; Sat, 17 Sep 2022 04:16:00 +0000 (UTC) X-FDA: 79920264480.25.9710177 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf13.hostedemail.com (Postfix) with ESMTP id F3AD5200B0 for ; Sat, 17 Sep 2022 04:15:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663388159; x=1694924159; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=dQDpK8w0a7wlRSYg04W1GIu8E15asfGUgzZTlQ9DWXc=; b=ZEotB1snrMAS4Csqwyyp+iHymaYH+n3U3+wNTcO4ZTUcFXooYHHfVwpW s1F6OG3tmIrmy90GxqDRfwjj9GpxwL5j9r6KdKWctD0bvVHk1fYOJeDXK Y7+24sf0QYkQUz8Y0a0oxy4tCF6K52DUxgmAdK93Hw0MDAmp7CNsPmFj/ bgT8GuN6JajpkFMU8bblmTuXRCADwEmFl1D11fHjDOoiTmStVtg/zH7Oz kAV/hbhsxp173hfW+M6fv1R1+R5UgDL7sMlGcM4arNr9z8jH2+IqviGZI 6OtN24pzo2bk1e45a7d2UnINwULWIZKKFvBtZBucZLrzVL3S1IKpN+/WL A==; X-IronPort-AV: E=McAfee;i="6500,9779,10472"; a="297850234" X-IronPort-AV: E=Sophos;i="5.93,322,1654585200"; d="scan'208";a="297850234" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2022 21:15:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,322,1654585200"; d="scan'208";a="648494343" Received: from lkp-server02.sh.intel.com (HELO 41300c7200ea) ([10.239.97.151]) by orsmga008.jf.intel.com with ESMTP; 16 Sep 2022 21:15:55 -0700 Received: from kbuild by 41300c7200ea with local (Exim 4.96) (envelope-from ) id 1oZPFC-0002TK-17; Sat, 17 Sep 2022 04:15:54 +0000 Date: Sat, 17 Sep 2022 12:15:19 +0800 From: kernel test robot To: Li Zhong , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, akpm@linux-foundation.org, Li Zhong Subject: Re: [PATCH v1] mm/vmscan: check the return value of migrate_pages() Message-ID: <202209171239.jS3610fm-lkp@intel.com> References: <20220917021257.3840548-1-floridsleeves@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220917021257.3840548-1-floridsleeves@gmail.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663388159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WgZnIVGt2ffHBTocHrvNXs8aEnkqPMf6RLytlC2Fzu8=; b=AiSIHmyOa331bi2kVyBiDd21+tzK/XuKh2QcnqEf5Lw1t9JOzw81X/mmLxeGyc9YdHZO1H 60MsIyMY/OC9zIUvekH5A8jPzJ3eaDyoUj/vbipjnsjT8HsrmYUFqkRSZs8EWPTRmIww3O 22hDtWD2Lcc9qv22z1D3KHSZ7e8qcxM= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=ZEotB1sn; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf13.hostedemail.com: domain of lkp@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663388159; a=rsa-sha256; cv=none; b=GCF0vcO3PAiJYU3OOXjzzl4c2UcRenWLmF3PIHlPR1aBVs5MNUf+Dkr/1ABrIsNBJD8XyK Lgffk+HEwd33norhiA980lI+K8cwVb348oSxJKGy5y8El/W1v2qIAkp+L/dl8wUgZsf1KJ kzB38EwVJht7nvG6fmUDBCYpAlJXkjE= X-Stat-Signature: 3iqhf8kf7ijrw38cagi31tdigrcuzued X-Rspamd-Queue-Id: F3AD5200B0 Authentication-Results: imf13.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=ZEotB1sn; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf13.hostedemail.com: domain of lkp@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=lkp@intel.com X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1663388158-567266 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Li, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v6.0-rc5] [cannot apply to akpm-mm/mm-everything next-20220916] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Li-Zhong/mm-vmscan-check-the-return-value-of-migrate_pages/20220917-101433 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a335366bad1364a07f49df9da1fdfa6d411a5f39 config: hexagon-randconfig-r041-20220916 (https://download.01.org/0day-ci/archive/20220917/202209171239.jS3610fm-lkp@intel.com/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/0ea516d584bd904c43954e312ac42fced822dcf7 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Li-Zhong/mm-vmscan-check-the-return-value-of-migrate_pages/20220917-101433 git checkout 0ea516d584bd904c43954e312ac42fced822dcf7 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): >> mm/vmscan.c:1564:26: error: use of undeclared identifier 'pagelist'; did you mean 'pageout'? putback_movable_pages(&pagelist); ^~~~~~~~ pageout mm/vmscan.c:1215:18: note: 'pageout' declared here static pageout_t pageout(struct folio *folio, struct address_space *mapping, ^ 1 error generated. vim +1564 mm/vmscan.c 1539 1540 /* 1541 * Take pages on @demote_list and attempt to demote them to 1542 * another node. Pages which are not demoted are left on 1543 * @demote_pages. 1544 */ 1545 static unsigned int demote_page_list(struct list_head *demote_pages, 1546 struct pglist_data *pgdat) 1547 { 1548 int target_nid = next_demotion_node(pgdat->node_id); 1549 unsigned int nr_succeeded; 1550 int ret; 1551 1552 if (list_empty(demote_pages)) 1553 return 0; 1554 1555 if (target_nid == NUMA_NO_NODE) 1556 return 0; 1557 1558 /* Demotion ignores all cpuset and mempolicy settings */ 1559 ret = migrate_pages(demote_pages, alloc_demote_page, NULL, 1560 target_nid, MIGRATE_ASYNC, MR_DEMOTION, 1561 &nr_succeeded); 1562 1563 if (ret) > 1564 putback_movable_pages(&pagelist); 1565 1566 if (current_is_kswapd()) 1567 __count_vm_events(PGDEMOTE_KSWAPD, nr_succeeded); 1568 else 1569 __count_vm_events(PGDEMOTE_DIRECT, nr_succeeded); 1570 1571 return nr_succeeded; 1572 } 1573 -- 0-DAY CI Kernel Test Service https://01.org/lkp