From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A13FECAAD8 for ; Fri, 16 Sep 2022 20:12:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 052078D0002; Fri, 16 Sep 2022 16:12:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0013E8D0001; Fri, 16 Sep 2022 16:12:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E320C8D0002; Fri, 16 Sep 2022 16:12:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D556E8D0001 for ; Fri, 16 Sep 2022 16:12:52 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A4AAC1C779D for ; Fri, 16 Sep 2022 20:12:52 +0000 (UTC) X-FDA: 79919046984.07.5A82D6B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 4A65A400A1 for ; Fri, 16 Sep 2022 20:12:52 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6749562D88; Fri, 16 Sep 2022 20:12:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9ED91C433C1; Fri, 16 Sep 2022 20:12:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1663359170; bh=L9/u85Ob/hu3MpUlIrHb1tJLfMBDTRMqxcF8INzzKE0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JaYP3IROe/rIGIpR8rGtKnuj9vmuD85fQAlt3pf7sHACVpzNIdg3eljoYzZqLBCYy mu2k5ByJFVcpLkndnQbeR06PEGZAiL4LwYLYxy1JBNeWfD0javfA4KcEACNAi6vscW paoh+6oFjS1L+dBYXrAj00S6ZmKlIuXywejcN6S8= Date: Fri, 16 Sep 2022 13:12:49 -0700 From: Andrew Morton To: Xin Hao Cc: mike.kravetz@oracle.com, songmuchun@bytedance.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] mm/hugetlb: add is_resv_equal_free() func Message-Id: <20220916131249.68d59133cdb0366e0831592b@linux-foundation.org> In-Reply-To: <20220916064127.1904-1-xhao@linux.alibaba.com> References: <20220916064127.1904-1-xhao@linux.alibaba.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=JaYP3IRO; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663359172; a=rsa-sha256; cv=none; b=OTRvjwXuxcaHTkNdv4expD4uKBE6qIP40XQWjutRcaeSVlRvL9QoDYuIJDIhbwCc4IJvh3 vxPAB6ywiMVTb5JQJgX8zuN8CIWE72MJ7CiyIzT26jZRFXG6p5FKGBeXvAI36pooHrmv91 ByCVvYhM0KxvT76kc9naHg2yhXOTM3Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663359172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cSUX2D9ahFpK3rlCNTRfSTrFvnU1bdhlQ7OqjybFQC8=; b=3kQDyF6ZIP3F2rjB0B2ESxaL7xZ+u67jtjE0g62r+Bu3r/3UEsX2jVxlX+LUyNXBqN2drx OUV3QPovdYuD4NBp/C6FmUqGjGO9ql5360ZUgO97at7E559puog8GoQDps+HHXbeYORkqE KL1GTOTsSY1TLqpHrmkA6fYuA8VZAj8= X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4A65A400A1 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=JaYP3IRO; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: pyyubee5nksysehg7qocy7qhxcm6dg3t X-HE-Tag: 1663359172-4335 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 16 Sep 2022 14:41:27 +0800 Xin Hao wrote: > In hugetlb.c file, there are several places to compare the values of > 'h->free_huge_pages' and 'h->resv_huge_pages', it looks a bit messy, so > there add a new is_resv_equal_free() func to do these. > > ... > > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1191,6 +1191,11 @@ static struct page *dequeue_huge_page_nodemask(struct hstate *h, gfp_t gfp_mask, > return NULL; > } > > +static inline bool is_resv_equal_free(struct hstate *h) I'm not sure that's a well chosen name. A better name would reflect the *meaning* of free_huge_pages being equal to resv_huge_pages. Maybe something like reserves_exhausted()? This would all be clearer if we'd bothered to document the fields of struct hstate :( > +{ > + return (h->free_huge_pages - h->resv_huge_pages == 0) ? true : false; return h->free_huge_pages == h->resv_huge_pages; > +}