From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 293A3ECAAD8 for ; Fri, 16 Sep 2022 08:42:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84F0C8D0002; Fri, 16 Sep 2022 04:42:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FF3F8D0001; Fri, 16 Sep 2022 04:42:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6ED458D0002; Fri, 16 Sep 2022 04:42:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5C3738D0001 for ; Fri, 16 Sep 2022 04:42:57 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2F1ACC0A39 for ; Fri, 16 Sep 2022 08:42:57 +0000 (UTC) X-FDA: 79917308394.14.D8E4A72 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf12.hostedemail.com (Postfix) with ESMTP id D27FA400C3 for ; Fri, 16 Sep 2022 08:42:56 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F14C7B8247E; Fri, 16 Sep 2022 08:42:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 353EAC433D6; Fri, 16 Sep 2022 08:42:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663317773; bh=q//Tw/cZDCMYfrc+5KH+QG9LHPSmCS0RQFK/fL7LNww=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ryst4ArblI3iQoFM68HXRdB+vQw60iT6hckhC56MNByf/qS+wMUSrBQc0UR4ABVwm BZCCs+aA1+jRcj37l2ScJeDnfpjZG6K/E8EXrZ5OZDbnoTNTpKxTi3w6YNttvkOQL0 BUJzZZRBeUMivkVGdCDfdzJby4B3pixeRPhqI7afVHMc4Bvi+Qt6Q9Nuxtl9Kte/rV 2+WV/KN4NnxD1/+aX9ARdJUTE/8L/jXNbXK4j7iKNk/k5SM4jhLkhnjw0ElxJNGwKV nBEm06yiG/G45zKqg6Vql2GHkUK/QruAT0kDHRIhgeTupJCBDljMRe82KbVZ8RiDmo 7SpYnJy/UJ3zg== From: SeongJae Park To: Xin Hao Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V1 1/2] mm/damon/sysfs: avoid call damon_target_has_pid() repeatedly Date: Fri, 16 Sep 2022 08:42:51 +0000 Message-Id: <20220916084251.105360-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220915142237.92529-1-xhao@linux.alibaba.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663317776; a=rsa-sha256; cv=none; b=4Zt3PimYkdBgx/dKfxnLX8fdoMftb6EdF2NaLN07iNN8N1q+N95+C1pMfbSNJaMn6F15AI tpomuALmRFMxBjIJzmsffnPNJHaKHSl93IxgiXrLoNyPD4jx5sEhGKnxIyvlQeTo2GIx/f usMNjt2ylHCHXwU2TrTsdU6wQ5QgsE8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ryst4Arb; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663317776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X7T0GlIFvVGL2PCOgcGVkWnQeCPfS/ev9ipgEME0jFY=; b=vMK3UzbsZ8qf+W/GE4OckIoebZsNXMWZpJ0CYRVwZ2votJkA2Jgk6ZtRp83eDCKNy6iaaG XqYYkOuyKMWFlCsgIbVhO5h01IK3EX6jUAgxwsQLBcoIWNLBgBJ+WgoJTobjetg71b/WLf uPoQqfLFzyGnerJrAxP9LQnZiV1E66o= X-Stat-Signature: r4miuz5e3ksfggmo7xkukn5j691fbbkd X-Rspamd-Queue-Id: D27FA400C3 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ryst4Arb; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1663317776-956968 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 15 Sep 2022 22:22:36 +0800 Xin Hao wrote: > In damon_sysfs_destroy_targets(), we call damon_target_has_pid() to > check whether the 'ctx' include a valid pid, but there no need to call > damon_target_has_pid() to check repeatedly, just need call it once. Good eyes, nice finding! > > Signed-off-by: Xin Hao > --- > mm/damon/sysfs.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c > index 1fa0023f136e..966ea7892ccf 100644 > --- a/mm/damon/sysfs.c > +++ b/mm/damon/sysfs.c > @@ -2143,9 +2143,13 @@ static int damon_sysfs_set_attrs(struct damon_ctx *ctx, > static void damon_sysfs_destroy_targets(struct damon_ctx *ctx) > { > struct damon_target *t, *next; > + bool has_pid = false; > + > + if (damon_target_has_pid(ctx)) > + has_pid = true; How about doing more simple and short like below? bool has_pid = damon_target_has_pid(ctx) Other than this, Reviewed-by: SeongJae Park Thanks, SJ > > damon_for_each_target_safe(t, next, ctx) { > - if (damon_target_has_pid(ctx)) > + if (has_pid) > put_pid(t->pid); > damon_destroy_target(t); > } > -- > 2.31.0