From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>, <david@redhat.com>,
<osalvador@suse.de>, <anshuman.khandual@arm.com>
Cc: <willy@infradead.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <linmiaohe@huawei.com>
Subject: [PATCH v2 12/16] mm/page_alloc: use helper macro SZ_1{K,M}
Date: Fri, 16 Sep 2022 15:22:53 +0800 [thread overview]
Message-ID: <20220916072257.9639-13-linmiaohe@huawei.com> (raw)
In-Reply-To: <20220916072257.9639-1-linmiaohe@huawei.com>
Use helper macro SZ_1K and SZ_1M to do the size conversion. Minor
readability improvement.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/page_alloc.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 6bdc98c7019f..67ec8a2e1db2 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -7048,7 +7048,7 @@ static int zone_batchsize(struct zone *zone)
* size is striking a balance between allocation latency
* and zone lock contention.
*/
- batch = min(zone_managed_pages(zone) >> 10, (1024 * 1024) / PAGE_SIZE);
+ batch = min(zone_managed_pages(zone) >> 10, SZ_1M / PAGE_SIZE);
batch /= 4; /* We effectively *= 4 below */
if (batch < 1)
batch = 1;
@@ -8523,8 +8523,8 @@ void __init mem_init_print_info(void)
#endif
")\n",
K(nr_free_pages()), K(physpages),
- codesize >> 10, datasize >> 10, rosize >> 10,
- (init_data_size + init_code_size) >> 10, bss_size >> 10,
+ codesize / SZ_1K, datasize / SZ_1K, rosize / SZ_1K,
+ (init_data_size + init_code_size) / SZ_1K, bss_size / SZ_1K,
K(physpages - totalram_pages() - totalcma_pages),
K(totalcma_pages)
#ifdef CONFIG_HIGHMEM
@@ -9049,8 +9049,8 @@ void *__init alloc_large_system_hash(const char *tablename,
numentries -= arch_reserved_kernel_pages();
/* It isn't necessary when PAGE_SIZE >= 1MB */
- if (PAGE_SHIFT < 20)
- numentries = round_up(numentries, (1<<20)/PAGE_SIZE);
+ if (PAGE_SIZE < SZ_1M)
+ numentries = round_up(numentries, SZ_1M / PAGE_SIZE);
#if __BITS_PER_LONG > 32
if (!high_limit) {
--
2.23.0
next prev parent reply other threads:[~2022-09-16 7:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 7:22 [PATCH v2 00/16] A few cleanup patches for mm Miaohe Lin
2022-09-16 7:22 ` [PATCH v2 01/16] mm/page_alloc: ensure kswapd doesn't accidentally go to sleep Miaohe Lin
2022-09-16 7:22 ` [PATCH v2 02/16] mm/page_alloc: make zone_pcp_update() static Miaohe Lin
2022-09-16 7:22 ` [PATCH v2 03/16] mm: remove obsolete macro NR_PCP_ORDER_MASK and NR_PCP_ORDER_WIDTH Miaohe Lin
2022-09-16 7:22 ` [PATCH v2 04/16] mm/page_alloc: remove obsolete comment in zone_statistics() Miaohe Lin
2022-09-16 7:22 ` [PATCH v2 05/16] mm/page_alloc: add __init annotations to init_mem_debugging_and_hardening() Miaohe Lin
2022-09-16 7:22 ` [PATCH v2 06/16] mm/page_alloc: fix freeing static percpu memory Miaohe Lin
2022-09-16 7:22 ` [PATCH v2 07/16] mm: remove obsolete pgdat_is_empty() Miaohe Lin
2022-09-16 7:22 ` [PATCH v2 08/16] mm/page_alloc: add missing is_migrate_isolate() check in set_page_guard() Miaohe Lin
2022-09-19 11:28 ` David Hildenbrand
2022-09-16 7:22 ` [PATCH v2 09/16] mm/page_alloc: use local variable zone_idx directly Miaohe Lin
2022-09-16 7:22 ` [PATCH v2 10/16] mm, memory_hotplug: remove obsolete generic_free_nodedata() Miaohe Lin
2022-09-16 7:22 ` [PATCH v2 11/16] mm/page_alloc: make boot_nodestats static Miaohe Lin
2022-09-16 7:22 ` Miaohe Lin [this message]
2022-09-19 11:30 ` [PATCH v2 12/16] mm/page_alloc: use helper macro SZ_1{K,M} David Hildenbrand
2022-09-16 7:22 ` [PATCH v2 13/16] mm/page_alloc: init local variable buddy_pfn Miaohe Lin
2022-09-16 7:22 ` [PATCH v2 14/16] mm/page_alloc: use costly_order in WARN_ON_ONCE_GFP() Miaohe Lin
2022-09-16 7:22 ` [PATCH v2 15/16] mm/page_alloc: remove obsolete gfpflags_normal_context() Miaohe Lin
2022-09-16 7:22 ` [PATCH v2 16/16] mm/page_alloc: fix obsolete comment in deferred_pfn_valid() Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220916072257.9639-13-linmiaohe@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox