From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E8C4ECAAA1 for ; Thu, 15 Sep 2022 22:26:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D34876B0072; Thu, 15 Sep 2022 18:26:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE4246B0073; Thu, 15 Sep 2022 18:26:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BABDB8D0001; Thu, 15 Sep 2022 18:26:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AC2846B0072 for ; Thu, 15 Sep 2022 18:26:21 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 77D001C312D for ; Thu, 15 Sep 2022 22:26:21 +0000 (UTC) X-FDA: 79915754562.17.AB533E0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 159B6A00B1 for ; Thu, 15 Sep 2022 22:26:20 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2047E62704; Thu, 15 Sep 2022 22:26:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49E62C433C1; Thu, 15 Sep 2022 22:26:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1663280779; bh=d4vL/tXKkJFtndx0mZJrG5LoXYIPxtE461UfMDX6pB0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oYcAaEhpBBcSkwoR4W8yxlv9F6KnYjjuuapBrXS7fSUGFAPZ4wvLogvzf76ucrCs/ /hSm99d239AXq9qRigYC7D70fYVmxsP4TuSvVC6QQVcRDAL8mRkNaBbfQkosjcmdOU CKH9QR6sJiFKHunw5ZSVaApBVOivmcssWRDuRj/Y= Date: Thu, 15 Sep 2022 15:26:18 -0700 From: Andrew Morton To: kernel test robot Cc: Xin Hao , sj@kernel.org, llvm@lists.linux.dev, kbuild-all@lists.01.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V1 2/2] mm/damon/core: remove duplicate check about THP Message-Id: <20220915152618.a050c7b55bf786c9e2c823ea@linux-foundation.org> In-Reply-To: <202209160528.6z2rUbjZ-lkp@intel.com> References: <20220915142237.92529-2-xhao@linux.alibaba.com> <202209160528.6z2rUbjZ-lkp@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663280781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XDpLoJjykEXSzC/tDYaQ3fox0O67M1B+W/lKoh1/jTs=; b=hcbRWgo1S7atwU3AWzuTTfjJzqmYRv2qL/Uyg7mv+9CCW9Z6h1l7AiZd8iL6GO7S8dl9m4 850jPoo1RM69WOjIQDooi5F8bz0zb8KPis9O+uSOZcGrxHIUJ0XeB93N1H6SQylkSMlbfW NzjN5oeXtEEh/ZQSXNpYq83sxxFtNhQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=oYcAaEhp; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663280781; a=rsa-sha256; cv=none; b=PEHfirFNg58FqgcXPkhdIL6euCGU8VvlhTd/S0RvCVdEK9QmqxEmN6d4+ip1GcbBy7LhcO 4Yn76rq2ciDCgXeM9HWN15lnMhpJemt9+PtKptBpn03vHdYv08kpEg9WJCKVtl9CC2pkhw zE3eG9ixDj8Hfa64cKcr7pzwLZQT9qk= X-Stat-Signature: cbruxqryrpw949tz64tieem874gjymnf X-Rspamd-Queue-Id: 159B6A00B1 X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=oYcAaEhp; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam06 X-HE-Tag: 1663280780-339894 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 16 Sep 2022 05:54:56 +0800 kernel test robot wrote: > Hi Xin, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on akpm-mm/mm-everything] > > url: https://github.com/intel-lab-lkp/linux/commits/Xin-Hao/mm-damon-sysfs-avoid-call-damon_target_has_pid-repeatedly/20220915-230635 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > config: hexagon-randconfig-r002-20220915 (https://download.01.org/0day-ci/archive/20220916/202209160528.6z2rUbjZ-lkp@intel.com/config) > compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/7902790b04d0eb74686b55218e8ead191ba5c003 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Xin-Hao/mm-damon-sysfs-avoid-call-damon_target_has_pid-repeatedly/20220915-230635 > git checkout 7902790b04d0eb74686b55218e8ead191ba5c003 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash mm/damon/ > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > >> mm/damon/vaddr.c:451:7: error: call to undeclared function 'pmd_young'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > if (pmd_young(*pmd) || !page_is_idle(page) || > ^ > mm/damon/vaddr.c:451:7: note: did you mean 'pte_young'? > arch/hexagon/include/asm/pgtable.h:273:19: note: 'pte_young' declared here > static inline int pte_young(pte_t pte) > ^ Thanks. I guess the arch needn't implement pmd_young() if it doesn't implement THP. I dropped the patch.