From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BD0BC6FA89 for ; Thu, 15 Sep 2022 15:06:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16CD68D000D; Thu, 15 Sep 2022 11:06:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 120288D0001; Thu, 15 Sep 2022 11:06:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F26308D000D; Thu, 15 Sep 2022 11:06:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E04918D0001 for ; Thu, 15 Sep 2022 11:06:26 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9D67C1A0244 for ; Thu, 15 Sep 2022 15:06:26 +0000 (UTC) X-FDA: 79914645972.22.5EFA369 Received: from mail-ed1-f74.google.com (mail-ed1-f74.google.com [209.85.208.74]) by imf13.hostedemail.com (Postfix) with ESMTP id 39ADE200AC for ; Thu, 15 Sep 2022 15:06:25 +0000 (UTC) Received: by mail-ed1-f74.google.com with SMTP id w20-20020a05640234d400b00450f24c8ca6so13152787edc.13 for ; Thu, 15 Sep 2022 08:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date; bh=Rbxz0iuc7RXxWgIfjeSrHOuiWEHvXH2VAJuclXEfLdg=; b=F6VwgljKSoHlmWj1nWyCtFBHI2b5B8DMZ6H1olBVWsiyfT2kbw7W/bawpY6tA8zayB THwH3bKPewMxmxrhbJdq+mZdumidYxMIcUtzSGYEkAasnxQOXeSE7IjjawVZVIn2zcXQ r1YsO97BGqmMH/3Gm3SPgEFLbDSNRdcBrXoh3uNQ2BkTLA6uRpOGDFXhN9pCl9ZI7NBZ xhhcFg1UVJA4C2HyIq9LT8Fw+KPyPlGxH/UCui6KY5gucTlsnsRb7V38I53MLrTmhqTr tJkPsqtR6gQh2kMAprFeLbJIRRB1FXqX6TCmSGetbahnUDYy2pQaPR875kzYJHfpMY4q Y0EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date; bh=Rbxz0iuc7RXxWgIfjeSrHOuiWEHvXH2VAJuclXEfLdg=; b=RgjeGALYiMk0jpbakE6cgR3K/554MClnMrAVNiEPTk18xhNjzKOVJwwuvjmXy7OnrP GJCIVneHSf6g5umPjNdRRM7u3mwxbsKDUAAdCVGYCx99FMDo6YSRY3gf++0HPDDUfZ1a x4rruhn13kImkSVY6wAGXGsaTwQbhTt0oe0bx439jTzFJmSJ8ALvLC1J47yYz2kCNERb 6oxNQlh6i19XyxzXGhLxc6zRz5EcypF/BKwdmq3yw+6zrJiw0lUOOMfLTX3OeA60jvEY npebq4UZjm5ycJGmWGWWr4DEJyQtkAayT90iJIc815OGNNmtfBIlmbGApUYGvWurwS4P mIuw== X-Gm-Message-State: ACrzQf3MVlIwvCUGiUeSbndXtz2d5CM6nr41szCxGdTWug/Nv67ShhEL +Ifsjc9dA200T7sPkWEu0xbYFFLIrT8= X-Google-Smtp-Source: AMsMyM6h5O71+6F4YlSosQQjOpItz2+q8/2EVZ42RobJy7VoqbBopgEvjyHEgtHeKPds8m8QA7fCze15fV4= X-Received: from glider.muc.corp.google.com ([2a00:79e0:9c:201:686d:27b5:495:85b7]) (user=glider job=sendgmr) by 2002:a05:6402:270f:b0:451:b5bd:95dd with SMTP id y15-20020a056402270f00b00451b5bd95ddmr251653edd.215.1663254384829; Thu, 15 Sep 2022 08:06:24 -0700 (PDT) Date: Thu, 15 Sep 2022 17:04:13 +0200 In-Reply-To: <20220915150417.722975-1-glider@google.com> Mime-Version: 1.0 References: <20220915150417.722975-1-glider@google.com> X-Mailer: git-send-email 2.37.2.789.g6183377224-goog Message-ID: <20220915150417.722975-40-glider@google.com> Subject: [PATCH v7 39/43] x86: kmsan: don't instrument stack walking functions From: Alexander Potapenko To: glider@google.com Cc: Alexander Viro , Alexei Starovoitov , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Biggers , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Marco Elver , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Stephen Rothwell , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663254386; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rbxz0iuc7RXxWgIfjeSrHOuiWEHvXH2VAJuclXEfLdg=; b=f2THehcEipXr9IN/NkypjygJN/7BmvZsNk1meoG60vjhIKhQRZel81Ppc7kWnKhTNRY06g wnvtl6mXMSG1XcBV3+e8HRP2r6BN0iaWZQqo7ZpQ4oxuG5g0OYCVvXUQ3WnoEL4tbuMnrN T8NayAskcBQZPFzpDrpinbE2PeQmivc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=F6VwgljK; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of 3cD8jYwYKCJsBGD89MBJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--glider.bounces.google.com designates 209.85.208.74 as permitted sender) smtp.mailfrom=3cD8jYwYKCJsBGD89MBJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--glider.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663254386; a=rsa-sha256; cv=none; b=L/pR5tNfPVpvfH7nhM5lQWuni8hbRjRJ9Ez0yRDUcowpVOmdnIypp1EfKWO5Gpb64JL4Lb 95Llklkh9Wo+IfPLTVa9JLJchVtfdwXaUsP8QwXdelH9LyyuGjDX2JD+CrBz4lXOB7Xqsn +7akRgE31gPddLAYs6LIkBcjALDXCAM= Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=F6VwgljK; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of 3cD8jYwYKCJsBGD89MBJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--glider.bounces.google.com designates 209.85.208.74 as permitted sender) smtp.mailfrom=3cD8jYwYKCJsBGD89MBJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--glider.bounces.google.com X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 39ADE200AC X-Stat-Signature: izpnnh91yujfwsdgsj9q98fbh6mhrz63 X-HE-Tag: 1663254385-577222 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Upon function exit, KMSAN marks local variables as uninitialized. Further function calls may result in the compiler creating the stack frame where these local variables resided. This results in frame pointers being marked as uninitialized data, which is normally correct, because they are not stack-allocated. However stack unwinding functions are supposed to read and dereference the frame pointers, in which case KMSAN might be reporting uses of uninitialized values. To work around that, we mark update_stack_state(), unwind_next_frame() and show_trace_log_lvl() with __no_kmsan_checks, preventing all KMSAN reports inside those functions and making them return initialized values. Signed-off-by: Alexander Potapenko --- Link: https://linux-review.googlesource.com/id/I6550563768fbb08aa60b2a96803675dcba93d802 --- arch/x86/kernel/dumpstack.c | 6 ++++++ arch/x86/kernel/unwind_frame.c | 11 +++++++++++ 2 files changed, 17 insertions(+) diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c index afae4dd774951..476eb504084e4 100644 --- a/arch/x86/kernel/dumpstack.c +++ b/arch/x86/kernel/dumpstack.c @@ -177,6 +177,12 @@ static void show_regs_if_on_stack(struct stack_info *info, struct pt_regs *regs, } } +/* + * This function reads pointers from the stack and dereferences them. The + * pointers may not have their KMSAN shadow set up properly, which may result + * in false positive reports. Disable instrumentation to avoid those. + */ +__no_kmsan_checks static void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs, unsigned long *stack, const char *log_lvl) { diff --git a/arch/x86/kernel/unwind_frame.c b/arch/x86/kernel/unwind_frame.c index 8e1c50c86e5db..d8ba93778ae32 100644 --- a/arch/x86/kernel/unwind_frame.c +++ b/arch/x86/kernel/unwind_frame.c @@ -183,6 +183,16 @@ static struct pt_regs *decode_frame_pointer(unsigned long *bp) } #endif +/* + * While walking the stack, KMSAN may stomp on stale locals from other + * functions that were marked as uninitialized upon function exit, and + * now hold the call frame information for the current function (e.g. the frame + * pointer). Because KMSAN does not specifically mark call frames as + * initialized, false positive reports are possible. To prevent such reports, + * we mark the functions scanning the stack (here and below) with + * __no_kmsan_checks. + */ +__no_kmsan_checks static bool update_stack_state(struct unwind_state *state, unsigned long *next_bp) { @@ -250,6 +260,7 @@ static bool update_stack_state(struct unwind_state *state, return true; } +__no_kmsan_checks bool unwind_next_frame(struct unwind_state *state) { struct pt_regs *regs; -- 2.37.2.789.g6183377224-goog