From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1CBCC32771 for ; Thu, 15 Sep 2022 21:07:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43D7F6B0071; Thu, 15 Sep 2022 17:07:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3ED756B0072; Thu, 15 Sep 2022 17:07:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28DCF8D0001; Thu, 15 Sep 2022 17:07:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 19D9C6B0071 for ; Thu, 15 Sep 2022 17:07:54 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E1F73AC3F9 for ; Thu, 15 Sep 2022 21:07:53 +0000 (UTC) X-FDA: 79915556826.12.E9BE42A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 4DA4C1400D0 for ; Thu, 15 Sep 2022 21:07:53 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F144A625FD; Thu, 15 Sep 2022 21:07:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45BE2C433D6; Thu, 15 Sep 2022 21:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1663276070; bh=ubg4i5YlfYJ6scG2ITwu9cE1IPvtdkwcRwNy86IfiVU=; h=Date:From:To:Subject:In-Reply-To:References:From; b=NULC6DLc5IlNv/tkUftQeolM+VBnoHSQr5R0d0rIDdb8Vr1NOlM66beQKYA5RMu51 5VH4cSyNptiu3LOju06TiIrdu00EzALj8SCBglJUvKHhIqG7wLUoYXxTyjJEL2d/Vb LJvM7HflPtQC8XOz7Til1rEfg87dKsSwj1xVO2V8= Date: Thu, 15 Sep 2022 14:07:48 -0700 From: Andrew Morton To: Alexander Potapenko , Alexander Viro , Alexei Starovoitov , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Biggers , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Marco Elver , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Stephen Rothwell , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 00/43] Add KernelMemorySanitizer infrastructure Message-Id: <20220915140748.843a2ebc2efb35f509b56ef4@linux-foundation.org> In-Reply-To: <20220915140551.2558e64c6a3d3a57d7588f5d@linux-foundation.org> References: <20220915150417.722975-1-glider@google.com> <20220915140551.2558e64c6a3d3a57d7588f5d@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663276073; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qEE1zojO2odxRBuHNu7vqOEYl8NElu7y58k2azJf/ZY=; b=L/gekKuRUg+I6YwW+M7lf9KRCNJTN/LORupkCWe69TKNuU44qzWKqKwXSS6aeLE/e2YPWR PN2Obay5kYTfVZmKpRMlT+VMg0OW6TFzKUqBpEvcEouM5fL3I9tMlwVUbQNyoW0VJ5701T Esn7TSvo4FexQ37krMOTRPFQq9IvNEo= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NULC6DLc; dmarc=none; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663276073; a=rsa-sha256; cv=none; b=fM4g5u2tDmm4XlyqlynOQ0NgcQEv5ihLnjN/D8TrGwrXoxtTHvE7CSWschY6ZRK8n7Birs tiPKowKIb8FcqYSKfCI4BVg8MXJFtouOgWtyVe42QUzCXldPeE5icSKS1jiHo5E/s1Ez3x wnM/h0uo5O/tIai94K5UPPdg1Ebe1Fk= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4DA4C1400D0 X-Rspam-User: X-Stat-Signature: 8f93o5t44df5dfqcd9ggndd7rouokkmz Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NULC6DLc; dmarc=none; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-HE-Tag: 1663276073-471573 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 15 Sep 2022 14:05:51 -0700 Andrew Morton wrote: > > For "kmsan: add KMSAN runtime core": > > ... > > @@ -219,23 +212,22 @@ depot_stack_handle_t kmsan_internal_chai > * Make sure we have enough spare bits in @id to hold the UAF bit and > * the chain depth. > */ > - BUILD_BUG_ON((1 << STACK_DEPOT_EXTRA_BITS) <= (MAX_CHAIN_DEPTH << 1)); > + BUILD_BUG_ON( > + (1 << STACK_DEPOT_EXTRA_BITS) <= (KMSAN_MAX_ORIGIN_DEPTH << 1)); > > extra_bits = stack_depot_get_extra_bits(id); > depth = kmsan_depth_from_eb(extra_bits); > uaf = kmsan_uaf_from_eb(extra_bits); > > - if (depth >= MAX_CHAIN_DEPTH) { > - static atomic_long_t kmsan_skipped_origins; > - long skipped = atomic_long_inc_return(&kmsan_skipped_origins); > - > - if (skipped % NUM_SKIPPED_TO_WARN == 0) { > - pr_warn("not chained %ld origins\n", skipped); > - dump_stack(); > - kmsan_print_origin(id); > - } Wouldn't it be neat if printk_ratelimited() returned true if it printed something. But you deleted this user of that neatness anyway ;)