From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70791ECAAD3 for ; Thu, 15 Sep 2022 13:45:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB9CA6B0074; Thu, 15 Sep 2022 09:45:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E69348D0003; Thu, 15 Sep 2022 09:45:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D58748D0002; Thu, 15 Sep 2022 09:45:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C70666B0074 for ; Thu, 15 Sep 2022 09:45:55 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A1D8B120DD3 for ; Thu, 15 Sep 2022 13:45:55 +0000 (UTC) X-FDA: 79914443070.22.56C218B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 12E511C00A4 for ; Thu, 15 Sep 2022 13:45:54 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3A1BE623E7; Thu, 15 Sep 2022 13:45:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EE49C433C1; Thu, 15 Sep 2022 13:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663249553; bh=zvTn9BWL/FcNXRvKgOxjhue2aM2e2uoqaWld7P/b3RE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oRA6W5Q0sRPZn6UzpoUEdY4q9113j7YXLElel6nUDhpaUq/jxErH35CXDRAqju9Ki CuCAtJriOhsk5GYS+BFDk66R0Arv27ZzPVDLwrUft2bG68sCq3AqGmAyTKPIqDEQYk KJpz4x2T4BRnD9X2qKF6FVj9I+SuOOmeEJAqcdiuHjx9y1FQ7UrSiz/i0K1fcKlLsk 57p/li2bFIvxT1j1bib6LwoG0M6pr6CyYZONohl14Iuya80R5ZaNvOxtTbXAXB8dg6 bwQnAMgDibpnu0zhuKgu0fcV/FoZkTmOkS8e4JNBBgAwgFK3cmuNaBUbj0H8YWpEBK /T4hRTMn5+ibg== From: SeongJae Park To: xiakaixu1987@gmail.com Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH] mm/damon: use 'struct damon_target *' instead of 'void *' in target_valid() Date: Thu, 15 Sep 2022 13:45:51 +0000 Message-Id: <20220915134551.99224-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1663241621-13293-1-git-send-email-kaixuxia@tencent.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oRA6W5Q0; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663249555; a=rsa-sha256; cv=none; b=bM9P9MsYiTi9O2T/70U6UHK3uMrxeS1woOIXYI/nUd9dqbmdgVGxqfX6I+gRkHfAH/oamN 1RO4E29ukOBvr34cvXLyuyttPA4o6nDjvO7Gi1fzF71Jkyb400Pn7GeHHD9U5gBh6tKu70 OPbKnmlmd59/xyD3aiL85l2g3njoa1Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663249555; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qTHk8zL8Rp3DkClmaBgltsEU0GW3yngjUf4YlW4JKZ8=; b=taVMKLsgGcyrgPw3ozw+/X0W+717kvBesX1fB/fawYKKcVqVg0D9eIB66EWLj3Z47T5uja 5z1xCHsbA1K2aDP5hjiK4RBmYQmyMJ+tKhE1QwmfVgIJUiQUsnxo9B4KHsYolFn2fWl3CZ fvbJiIQqAgAaJeTQPPGkXxd0P2UqXf8= X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 12E511C00A4 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oRA6W5Q0; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: p4h63qwdqyamtrbgzbjfwuutwnw6hq6t X-HE-Tag: 1663249554-853225 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kaixu, On Thu, 15 Sep 2022 19:33:41 +0800 xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > We could use 'struct damon_target *' directly instead of 'void *' in > target_valid() operation to make code simple. Nice finding. > > Signed-off-by: Kaixu Xia Reviewed-by: SeongJae Park Thanks, SJ > --- > include/linux/damon.h | 2 +- > mm/damon/vaddr.c | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/include/linux/damon.h b/include/linux/damon.h > index c5dc0c77c772..1dda8d0068e5 100644 > --- a/include/linux/damon.h > +++ b/include/linux/damon.h > @@ -346,7 +346,7 @@ struct damon_operations { > unsigned long (*apply_scheme)(struct damon_ctx *context, > struct damon_target *t, struct damon_region *r, > struct damos *scheme); > - bool (*target_valid)(void *target); > + bool (*target_valid)(struct damon_target *t); > void (*cleanup)(struct damon_ctx *context); > }; > > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > index 3f84584f9982..f53c2ff2bcc8 100644 > --- a/mm/damon/vaddr.c > +++ b/mm/damon/vaddr.c > @@ -593,9 +593,8 @@ static unsigned int damon_va_check_accesses(struct damon_ctx *ctx) > * Functions for the target validity check and cleanup > */ > > -static bool damon_va_target_valid(void *target) > +static bool damon_va_target_valid(struct damon_target *t) > { > - struct damon_target *t = target; > struct task_struct *task; > > task = damon_get_task_struct(t); > -- > 2.27.0 >