From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B00DBECAAA1 for ; Thu, 15 Sep 2022 13:07:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 052EF6B0074; Thu, 15 Sep 2022 09:07:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 003818D0002; Thu, 15 Sep 2022 09:07:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0DF98D0001; Thu, 15 Sep 2022 09:07:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D18DA6B0074 for ; Thu, 15 Sep 2022 09:07:08 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AA10C140A56 for ; Thu, 15 Sep 2022 13:07:08 +0000 (UTC) X-FDA: 79914345336.10.AE3A255 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf15.hostedemail.com (Postfix) with ESMTP id 06814A00B3 for ; Thu, 15 Sep 2022 13:07:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8A2531F45B; Thu, 15 Sep 2022 13:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1663247226; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ycv+ku412KioNw8zG2WTAV+1+K9VQcWQoBnH2pQy/tU=; b=LYLosnVXn+mkR1lFpUhvTxd3pj5TNdvpLX+rZbvbqzCnWGadUEfniNuiAocOm3p6hTIOKM Fd9QQ0h/jFXcXQTPaukqVZl6wmYy58Yw04039KG2r95VAktc9YWOz6HV1CIpzrkmVwI909 4uQnFA5THolqXYyT1IYO+tUnmwwDI5c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1663247226; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ycv+ku412KioNw8zG2WTAV+1+K9VQcWQoBnH2pQy/tU=; b=3FnjNRMLa9Ki7A2hz950UiczLBh36lkLHofQ3/8oZ3tYxbyte1n7jdf/FCd1a6XUty6MoC b2eq+zJpfoW61bBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 32FFA13A49; Thu, 15 Sep 2022 13:07:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id H2Z/C3ojI2OwVQAAMHmgww (envelope-from ); Thu, 15 Sep 2022 13:07:06 +0000 Date: Thu, 15 Sep 2022 15:01:38 +0200 From: David Sterba To: Christoph Hellwig Cc: Jens Axboe , Matthew Wilcox , Johannes Weiner , Suren Baghdasaryan , Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-mm@kvack.org Subject: Re: improve pagecache PSI annotations v2 Message-ID: <20220915130138.GO32411@suse.cz> Reply-To: dsterba@suse.cz References: <20220915094200.139713-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220915094200.139713-1-hch@lst.de> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LYLosnVX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3FnjNRML; spf=pass (imf15.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=dsterba@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663247228; a=rsa-sha256; cv=none; b=a9+Y1Bjl5fWvvn0h3mSjxrnkFNLd9WuMOe9vAZTrtezCKgM0hH8XqsVXSg0Lzm8dK85+JB +4TLrAXBK05IrjL27qWd2duyLtTZP+PxWAjAziRUmsFOptzsCYk5n3K08lNsjuR1apuktV m5RTqxezb+yLaCCyZxEsSZQ/iVyQlYg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663247228; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ycv+ku412KioNw8zG2WTAV+1+K9VQcWQoBnH2pQy/tU=; b=grCNxZtK6kXIQDlt7XV48optWiF8y41qollwoE2lKJarbVvkSFMhBN/AyJlbrNCrDKVIHr DK0XcL1ytr8wrJUDF9hZH0yEdbEn3tu85/Uhm7AqSybbt23PQLk2mkRpRMXRGaw/1/tr+B O7jDuMX4MxqVXZz/qt3H8jCBQi/ErBo= X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 06814A00B3 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LYLosnVX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3FnjNRML; spf=pass (imf15.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=dsterba@suse.cz; dmarc=none X-Stat-Signature: 1xoysbdehm9joc8n4ka67do48637cjga X-HE-Tag: 1663247227-902035 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 15, 2022 at 10:41:55AM +0100, Christoph Hellwig wrote: > > - spell a comment in the weird way preferred by btrfs maintainers What? A comment is a standalone sentence or a full paragraph, so it's formatted as such. I hope it's not weird to expect literacy either in the language of comments or the programming language. The same style can be found in many other kernel parts so please stop the nags at btrfs.