From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9050ECAAD3 for ; Thu, 15 Sep 2022 12:58:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BA5D8D0001; Thu, 15 Sep 2022 08:58:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 668D66B0075; Thu, 15 Sep 2022 08:58:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 530DA8D0001; Thu, 15 Sep 2022 08:58:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 444AB6B0074 for ; Thu, 15 Sep 2022 08:58:01 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2014480524 for ; Thu, 15 Sep 2022 12:58:01 +0000 (UTC) X-FDA: 79914322362.06.DF624EF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id C0A13800CD for ; Thu, 15 Sep 2022 12:58:00 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 31ECB62379; Thu, 15 Sep 2022 12:58:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CC6FC433C1; Thu, 15 Sep 2022 12:57:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663246679; bh=soVQFcFVYD22JcFsKPqxSh2D+yi5kfsMORSJ4osgWnw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bFvnsFypCQ+nKYq4C1tQX808TfU3RLcLyao8AFEUSgw4dWyXvmheoARG1kQ1SEdFm gWXydTaTVxy4oslYoZlNYbSUnr2RoJjJuDjUKg2jq245n1n1RTV27tiEGyxdH0gbAD +I+0uLbpeNi7+/rXd8pzVlw7nUmk+IrTijFVdcns/UBKFdbj5HDq4VZ8sxziR7zWRE Y1NZ0rg97lvYJx4d291EYdaBTsI7xcDuWhjdPmjis+v9hj3Ad2ys3AgeGWFHfGGedk uXDSLjcAD1+PusNI7ZxzCg3VD/r9YfYYH4LtwD19GEVjJIOHO5tq76GqfEjkOMYzDi vC4wmy79NIsYQ== From: SeongJae Park To: Yang Yingliang Cc: linux-mm@kvack.org, damon@lists.linux.dev, sj@kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH -next 2/2] mm/damon/lru_sort: change damon_lru_sort_wmarks to static Date: Thu, 15 Sep 2022 12:57:57 +0000 Message-Id: <20220915125757.58988-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220915021024.4177940-2-yangyingliang@huawei.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bFvnsFyp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663246680; a=rsa-sha256; cv=none; b=ZhkiFVTEzOqFCdrBWek6tDjicytQAAsDKMB7vtyNOAYjTId7BpZgpokZW7JsbroIyDHgaA 2fJDqD9wqbZVYnC2TyBvmEChA0BpErEE7JF0jopuYWbUEJ1Ke4LZbVI29XfZwThFEb2m/r kPiyNMEOcbAHhLsj9F33p91T/gahQAI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663246680; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CiTRC2FVrAqAonY1NlEqBryjL9kufXqrNCUBWllTABo=; b=4AJto0oMy1BwixRmwWT5DhsO9iSzLU8z1LbbpYGwt+6+VKNBQgPgLC1Ut+Jd2PlP9uQL5j 4C54wmp4szJNCNzOxUZmVWRJFfU8nfLpRiUxG4VDkk1vgwFlDxeVoob7EDJh3OgYPNb5rt B9Ud0qC7/7zvNEMypxbbRycA2txPgzs= Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bFvnsFyp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org X-Rspam-User: X-Rspamd-Queue-Id: C0A13800CD X-Rspamd-Server: rspam01 X-Stat-Signature: rknesq7z71qskncwghrzd4dfaexfrg5a X-HE-Tag: 1663246680-161795 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 15 Sep 2022 10:10:24 +0800 Yang Yingliang wrote: > damon_lru_sort_wmarks is only used in lru_sort.c now, change it to static. > > Fixes: 189aa3d58206 ("mm/damon/lru_sort: use watermarks parameters generator macro") > Signed-off-by: Yang Yingliang Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/lru_sort.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c > index 07a0908963fd..46e7c0738bc5 100644 > --- a/mm/damon/lru_sort.c > +++ b/mm/damon/lru_sort.c > @@ -77,7 +77,7 @@ static struct damos_quota damon_lru_sort_quota = { > }; > DEFINE_DAMON_MODULES_DAMOS_TIME_QUOTA(damon_lru_sort_quota); > > -struct damos_watermarks damon_lru_sort_wmarks = { > +static struct damos_watermarks damon_lru_sort_wmarks = { > .metric = DAMOS_WMARK_FREE_MEM_RATE, > .interval = 5000000, /* 5 seconds */ > .high = 200, /* 20 percent */ > -- > 2.25.1