From: SeongJae Park <sj@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-mm@kvack.org, damon@lists.linux.dev, sj@kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH -next 2/2] mm/damon/lru_sort: change damon_lru_sort_wmarks to static
Date: Thu, 15 Sep 2022 12:57:57 +0000 [thread overview]
Message-ID: <20220915125757.58988-1-sj@kernel.org> (raw)
In-Reply-To: <20220915021024.4177940-2-yangyingliang@huawei.com>
On Thu, 15 Sep 2022 10:10:24 +0800 Yang Yingliang <yangyingliang@huawei.com> wrote:
> damon_lru_sort_wmarks is only used in lru_sort.c now, change it to static.
>
> Fixes: 189aa3d58206 ("mm/damon/lru_sort: use watermarks parameters generator macro")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
> ---
> mm/damon/lru_sort.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c
> index 07a0908963fd..46e7c0738bc5 100644
> --- a/mm/damon/lru_sort.c
> +++ b/mm/damon/lru_sort.c
> @@ -77,7 +77,7 @@ static struct damos_quota damon_lru_sort_quota = {
> };
> DEFINE_DAMON_MODULES_DAMOS_TIME_QUOTA(damon_lru_sort_quota);
>
> -struct damos_watermarks damon_lru_sort_wmarks = {
> +static struct damos_watermarks damon_lru_sort_wmarks = {
> .metric = DAMOS_WMARK_FREE_MEM_RATE,
> .interval = 5000000, /* 5 seconds */
> .high = 200, /* 20 percent */
> --
> 2.25.1
next prev parent reply other threads:[~2022-09-15 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 2:10 [PATCH -next 1/2] mm/damon/reclaim: change damon_reclaim_wmarks " Yang Yingliang
2022-09-15 2:10 ` [PATCH -next 2/2] mm/damon/lru_sort: change damon_lru_sort_wmarks " Yang Yingliang
2022-09-15 12:57 ` SeongJae Park [this message]
2022-09-15 12:56 ` [PATCH -next 1/2] mm/damon/reclaim: change damon_reclaim_wmarks " SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220915125757.58988-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-mm@kvack.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox