* [PATCH -next 1/2] mm/damon/reclaim: change damon_reclaim_wmarks to static
@ 2022-09-15 2:10 Yang Yingliang
2022-09-15 2:10 ` [PATCH -next 2/2] mm/damon/lru_sort: change damon_lru_sort_wmarks " Yang Yingliang
2022-09-15 12:56 ` [PATCH -next 1/2] mm/damon/reclaim: change damon_reclaim_wmarks " SeongJae Park
0 siblings, 2 replies; 4+ messages in thread
From: Yang Yingliang @ 2022-09-15 2:10 UTC (permalink / raw)
To: linux-mm, damon; +Cc: sj, akpm
damon_reclaim_wmarks is only used in reclaim.c now, change it to static.
Fixes: 89dd02d8abd1 ("mm/damon/reclaim: use watermarks parameters generator macro")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
mm/damon/reclaim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c
index 1acf808e1624..039fa55e0ae9 100644
--- a/mm/damon/reclaim.c
+++ b/mm/damon/reclaim.c
@@ -64,7 +64,7 @@ static struct damos_quota damon_reclaim_quota = {
};
DEFINE_DAMON_MODULES_DAMOS_QUOTAS(damon_reclaim_quota);
-struct damos_watermarks damon_reclaim_wmarks = {
+static struct damos_watermarks damon_reclaim_wmarks = {
.metric = DAMOS_WMARK_FREE_MEM_RATE,
.interval = 5000000, /* 5 seconds */
.high = 500, /* 50 percent */
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH -next 2/2] mm/damon/lru_sort: change damon_lru_sort_wmarks to static
2022-09-15 2:10 [PATCH -next 1/2] mm/damon/reclaim: change damon_reclaim_wmarks to static Yang Yingliang
@ 2022-09-15 2:10 ` Yang Yingliang
2022-09-15 12:57 ` SeongJae Park
2022-09-15 12:56 ` [PATCH -next 1/2] mm/damon/reclaim: change damon_reclaim_wmarks " SeongJae Park
1 sibling, 1 reply; 4+ messages in thread
From: Yang Yingliang @ 2022-09-15 2:10 UTC (permalink / raw)
To: linux-mm, damon; +Cc: sj, akpm
damon_lru_sort_wmarks is only used in lru_sort.c now, change it to static.
Fixes: 189aa3d58206 ("mm/damon/lru_sort: use watermarks parameters generator macro")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
mm/damon/lru_sort.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c
index 07a0908963fd..46e7c0738bc5 100644
--- a/mm/damon/lru_sort.c
+++ b/mm/damon/lru_sort.c
@@ -77,7 +77,7 @@ static struct damos_quota damon_lru_sort_quota = {
};
DEFINE_DAMON_MODULES_DAMOS_TIME_QUOTA(damon_lru_sort_quota);
-struct damos_watermarks damon_lru_sort_wmarks = {
+static struct damos_watermarks damon_lru_sort_wmarks = {
.metric = DAMOS_WMARK_FREE_MEM_RATE,
.interval = 5000000, /* 5 seconds */
.high = 200, /* 20 percent */
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next 2/2] mm/damon/lru_sort: change damon_lru_sort_wmarks to static
2022-09-15 2:10 ` [PATCH -next 2/2] mm/damon/lru_sort: change damon_lru_sort_wmarks " Yang Yingliang
@ 2022-09-15 12:57 ` SeongJae Park
0 siblings, 0 replies; 4+ messages in thread
From: SeongJae Park @ 2022-09-15 12:57 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-mm, damon, sj, akpm
On Thu, 15 Sep 2022 10:10:24 +0800 Yang Yingliang <yangyingliang@huawei.com> wrote:
> damon_lru_sort_wmarks is only used in lru_sort.c now, change it to static.
>
> Fixes: 189aa3d58206 ("mm/damon/lru_sort: use watermarks parameters generator macro")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
> ---
> mm/damon/lru_sort.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c
> index 07a0908963fd..46e7c0738bc5 100644
> --- a/mm/damon/lru_sort.c
> +++ b/mm/damon/lru_sort.c
> @@ -77,7 +77,7 @@ static struct damos_quota damon_lru_sort_quota = {
> };
> DEFINE_DAMON_MODULES_DAMOS_TIME_QUOTA(damon_lru_sort_quota);
>
> -struct damos_watermarks damon_lru_sort_wmarks = {
> +static struct damos_watermarks damon_lru_sort_wmarks = {
> .metric = DAMOS_WMARK_FREE_MEM_RATE,
> .interval = 5000000, /* 5 seconds */
> .high = 200, /* 20 percent */
> --
> 2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next 1/2] mm/damon/reclaim: change damon_reclaim_wmarks to static
2022-09-15 2:10 [PATCH -next 1/2] mm/damon/reclaim: change damon_reclaim_wmarks to static Yang Yingliang
2022-09-15 2:10 ` [PATCH -next 2/2] mm/damon/lru_sort: change damon_lru_sort_wmarks " Yang Yingliang
@ 2022-09-15 12:56 ` SeongJae Park
1 sibling, 0 replies; 4+ messages in thread
From: SeongJae Park @ 2022-09-15 12:56 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-mm, damon, sj, akpm
Hi Yang,
On Thu, 15 Sep 2022 10:10:23 +0800 Yang Yingliang <yangyingliang@huawei.com> wrote:
> damon_reclaim_wmarks is only used in reclaim.c now, change it to static.
>
> Fixes: 89dd02d8abd1 ("mm/damon/reclaim: use watermarks parameters generator macro")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
> ---
> mm/damon/reclaim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c
> index 1acf808e1624..039fa55e0ae9 100644
> --- a/mm/damon/reclaim.c
> +++ b/mm/damon/reclaim.c
> @@ -64,7 +64,7 @@ static struct damos_quota damon_reclaim_quota = {
> };
> DEFINE_DAMON_MODULES_DAMOS_QUOTAS(damon_reclaim_quota);
>
> -struct damos_watermarks damon_reclaim_wmarks = {
> +static struct damos_watermarks damon_reclaim_wmarks = {
> .metric = DAMOS_WMARK_FREE_MEM_RATE,
> .interval = 5000000, /* 5 seconds */
> .high = 500, /* 50 percent */
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-15 12:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-15 2:10 [PATCH -next 1/2] mm/damon/reclaim: change damon_reclaim_wmarks to static Yang Yingliang
2022-09-15 2:10 ` [PATCH -next 2/2] mm/damon/lru_sort: change damon_lru_sort_wmarks " Yang Yingliang
2022-09-15 12:57 ` SeongJae Park
2022-09-15 12:56 ` [PATCH -next 1/2] mm/damon/reclaim: change damon_reclaim_wmarks " SeongJae Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox