From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31B72C6FA82 for ; Wed, 14 Sep 2022 21:19:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 951848D0001; Wed, 14 Sep 2022 17:19:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9018F6B0073; Wed, 14 Sep 2022 17:19:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C8BE8D0001; Wed, 14 Sep 2022 17:19:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6A8B46B0071 for ; Wed, 14 Sep 2022 17:19:23 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3B4E280CCA for ; Wed, 14 Sep 2022 21:19:23 +0000 (UTC) X-FDA: 79911957006.16.C7AB1AC Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf29.hostedemail.com (Postfix) with ESMTP id C05ED1200E6 for ; Wed, 14 Sep 2022 21:19:22 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 57A47B81CD5; Wed, 14 Sep 2022 21:19:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF0F6C433D6; Wed, 14 Sep 2022 21:19:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1663190360; bh=SE/1uEBMr3SKBdrsW9xCRtD5tFJ11wzPFGBH/vi9J78=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Lcjw3ZRwmBprq/ZUHbmDTESzH8APW6M71TpkOSLF6y9clCrNjhRRm0V95nDQfLp/g wLS3FXM7UCUDzLP4B5W/H32o1ZlSECFzgvbP3CTZ3NGaUqTtNIim/kl3biH1/WEWW3 ZhX8jxpOgSvIrCNav64BfdE7Dwd0ST05aso80xWA= Date: Wed, 14 Sep 2022 14:19:19 -0700 From: Andrew Morton To: "zhaoyang.huang" Cc: Zhaoyang Huang , , , Subject: Re: [PATCH] mm: No need to check pcp page when free it to buddy Message-Id: <20220914141919.9f2c3ac357696d2d829d8f69@linux-foundation.org> In-Reply-To: <1663152820-608-1-git-send-email-zhaoyang.huang@unisoc.com> References: <1663152820-608-1-git-send-email-zhaoyang.huang@unisoc.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663190362; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t4x39mFUBawC/+jcn+eO8weP7Lbe8YzjPeaiFM2BwDE=; b=kBSOsict/DwA0lyaa5ua/+YOPgpDvils84TiU8NaxUJ9EI3M9R+1g6aD/50RETkHYaTf0B 1M5BWl4cnhiacJSLj+YkGyTp5ttuKz6BRtvd7v1Vr7VUyeOZmklTYY0X0V7T9tvRNq4g3+ bc+CPfH/LD533kFo0JQgVkS0Uzx1kqE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Lcjw3ZRw; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663190362; a=rsa-sha256; cv=none; b=BJo0IbFwOZZLxkKeS1vE/aqhy3dpu7NipcS/PNZlWfUFuWqPyRXpLnXtZE2yA0bmLf8uJD 2iOADvOpavJrUR/uMZL/zN5X9DVq+un78/5D+sYsfr9gHCQhgnRVoKuFLf+VMeQwew+2bD MnP/JDZ6wL9WPgUPuIjDR292xMA6YD0= Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Lcjw3ZRw; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam08 X-Rspam-User: X-Stat-Signature: qrh68raqbhoxfxsz9uxa87c6ygnbhw4g X-Rspamd-Queue-Id: C05ED1200E6 X-HE-Tag: 1663190362-117982 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 14 Sep 2022 18:53:40 +0800 "zhaoyang.huang" wrote: > From: Zhaoyang Huang > > The pages on pcp list have been checked the validity from each entrance. It is > no need to check it again when free them back to buddy. > I'm not sure what "from each entrance" means. Please identify the codesite where this other check is occurring? > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e008a3d..131536e 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1445,7 +1445,7 @@ static bool free_pcp_prepare(struct page *page, unsigned int order) > > static bool bulkfree_pcp_prepare(struct page *page) > { > - return check_free_page(page); > + return false; > } > #endif /* CONFIG_DEBUG_VM */