From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A2BAECAAD3 for ; Wed, 14 Sep 2022 14:03:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 579A66B0071; Wed, 14 Sep 2022 10:03:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 528FA6B0073; Wed, 14 Sep 2022 10:03:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 418D18D0001; Wed, 14 Sep 2022 10:03:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 356076B0071 for ; Wed, 14 Sep 2022 10:03:31 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0521B40AD3 for ; Wed, 14 Sep 2022 14:03:30 +0000 (UTC) X-FDA: 79910858622.17.178124C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 9FF551C009B for ; Wed, 14 Sep 2022 14:03:29 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D7D1E61DB1; Wed, 14 Sep 2022 14:03:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD70FC433D6; Wed, 14 Sep 2022 14:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663164208; bh=nhVx0gn7AsjC6QInzn3fLYFpoPK1KO9cyf+fOkCT9HE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SvVLexy7CgJW1FDPPbCnSdrJR+Np8nJ32ilJenWAzRyWchi3rvEJ19jjIMz/eEAvH 7oybCy1aXMbhosyA0hUotVurSi6W6PjjfJMV8yR25kAyINIZRnBkMf4ZzB4GQC/GAh 5W3+Ma4UCgwuHGjhh73H28hwtw9q+dGvIInkxOPN/GvWsPXrq1WcX8udaH8FyD2UEd R6jFSTYD9LFmWApsBDkvMJecz4upILYqqGndBVe9mrb8ewqHWdK911o1RmWcZj1e/X JtRNQDj7Myi6PY6dHd5unxdH9UVBHMupu3SqUICv0H/ky9LIk88DYAaJhPS8gygWyG Lnd1yn8OZkzAQ== From: SeongJae Park To: Xin Hao Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/hugetlbfs: use macro SZ_1K to replace 1024 Date: Wed, 14 Sep 2022 14:03:26 +0000 Message-Id: <20220914140326.1121-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220914115723.38271-1-xhao@linux.alibaba.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SvVLexy7; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663164209; a=rsa-sha256; cv=none; b=30iU+3txk4ZW/NkQ6SVJM1iUNNQZy+/8U1vBO7X+SwOdWtZGmGirLEtwA26eDKyafI5U5U 7JgxQ38C9uRR0K2T+merFkaZOueSqu3mdg2VDst7gQ1qgqp2I3Pyzd7JiZArxKxq18aqFi dsL1MpQt2dq13BKUMOvC/DZDbu4Y31I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663164209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HemoWG9/WhozqhRnwwFx/4Xhh80ljLsRrc8HMwDl6Bg=; b=Gyxr4w28SneUd2lZ2g4ngUz9vf2y0twb90eN8Qcv9wHy7QGCXiyqttxJjCYX+zhfx32Zd4 TYXSAPC2qAdJSzxM+0unmaUv9K09wSnlft0rq0WUevgCTwuYUyuW1mQB0oCjStbB2OGrAS Ra+Nh/ObYF+7skqB0juQeL/j4b+citw= X-Stat-Signature: cy1nkxi7rdfgaq3q5qzsyeu8oha9phz3 X-Rspamd-Queue-Id: 9FF551C009B X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SvVLexy7; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam12 X-HE-Tag: 1663164209-393297 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 14 Sep 2022 19:57:23 +0800 Xin Hao wrote: > Using macro SZ_1K in hugetlbfs_show_options() has no any functional > changes, just makes code more readable. > > Signed-off-by: Xin Hao Reviewed-by: SeongJae Park Thanks, SJ > --- > fs/hugetlbfs/inode.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index f7a5b5124d8a..9b9784ffe8de 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -1023,10 +1023,10 @@ static int hugetlbfs_show_options(struct seq_file *m, struct dentry *root) > if (sbinfo->max_inodes != -1) > seq_printf(m, ",nr_inodes=%lu", sbinfo->max_inodes); > > - hpage_size /= 1024; > + hpage_size /= SZ_1K; > mod = 'K'; > - if (hpage_size >= 1024) { > - hpage_size /= 1024; > + if (hpage_size >= SZ_1K) { > + hpage_size /= SZ_1K; > mod = 'M'; > } > seq_printf(m, ",pagesize=%lu%c", hpage_size, mod); > -- > 2.31.0