From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36736ECAAD3 for ; Wed, 14 Sep 2022 09:52:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0F338D0002; Wed, 14 Sep 2022 05:52:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABEFF8D0001; Wed, 14 Sep 2022 05:52:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 986858D0002; Wed, 14 Sep 2022 05:52:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 875618D0001 for ; Wed, 14 Sep 2022 05:52:10 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5DE09A1162 for ; Wed, 14 Sep 2022 09:52:10 +0000 (UTC) X-FDA: 79910225220.13.07AC7D2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 05D6E800AB for ; Wed, 14 Sep 2022 09:52:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0A7586191D; Wed, 14 Sep 2022 09:52:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5DA3C433D7; Wed, 14 Sep 2022 09:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663149128; bh=ET7xbCmKy/wqjVqLOdaW4rsp6pDFPXzpeLtwj+QaumI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=esymQ/kJqQsK2cqJ9IZ7oY0Clu6YyLsT78uqOUlEhaCBDCgX6jFu9XKPrNZbryLiu 6gH+q1Ov9/ZtXtPZHp5CXJ8+gqf9OR2vxM2tGKcXBIv5MrUVfvPcPEd7EEeOtAzzhh VGkQH+tmS7nOCtRVn1ZIva/jZ1xxnVoHpaCsIzjTiTgwO7iMeUzZHFMYYABRplL7kY ltnM6yGDX236aK+iETeMDt4t6S949SL/zDISOkTUvkR4hUs+v332jQK1b3fGt9mKGr Tf5l+kJt69JuC/mWYDTZQIdPnopU0XjHgk39Chm+IRi5H1Bev35sWWFW2JRxAplCal fCBGBjgBXBQnQ== From: SeongJae Park To: Yajun Deng Cc: sj@kernel.org, akpm@linux-foundation.org, sieberf@amazon.com, shakeelb@google.com, foersleo@amazon.de, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon: fix missing damon_del_region() Date: Wed, 14 Sep 2022 09:52:06 +0000 Message-Id: <20220914095206.70459-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220914093636.1184590-1-yajun.deng@linux.dev> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663149130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6Snup3EKTntIr/zDGSPzXc2nbTGTERncqreU8/or5w0=; b=3EbS2mAhCxDFpvn1d5tcg/WQSwFICijwYIfqm7NIYN8DU2Y3Upbz1oAUwb1Fic4/ATx1Aq uiFwhNjJEQhEseGg0eJbZQPnWfL7r6JRmYwR1t5nMDxAktL/M1yy56s+A5wVFIk2Sv7lnI PYVMtx89LQnk8qcCkOrt6wtYsoznPpg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="esymQ/kJ"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663149130; a=rsa-sha256; cv=none; b=PG2fUAvSaZe7izRgKNcL5uuRKrhRChLyH35nFIZ4qFtCimcyILVaURV6IHicqI9l0A8eVv g9RD/mywwT8VQ4bFIiCtHTNjCImtCZ0zNnh6tjvfqryWmDbr9p8MgdWUqccUQmfdJmWwhC ipaEsNCr9eSdxU4IJe001LY+ZVWCoN4= Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="esymQ/kJ"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org X-Stat-Signature: jozicj5e6ft43o9fkbqrdsgh3fnwsu6t X-Rspamd-Queue-Id: 05D6E800AB X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1663149129-864549 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Yajun, On Wed, 14 Sep 2022 17:36:36 +0800 Yajun Deng wrote: > It should be called damon_del_region() before free each region, so use > damon_destroy_region() instead of damon_free_region(). What 'damon_del_region()' does is deleting the region from target's regions linked list so that nobody references it later after its freed. However, as each region is linked to one target, and as we will free the target here, the list will also be freed. Therefore, we don't need to worry about future references to the region. Anything I'm missing? Thanks, SJ > > Fixes: f23b8eee1871 (mm/damon/core: implement region-based sampling) > Signed-off-by: Yajun Deng > --- > mm/damon/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index 0b1eb945c68a..e62e7ebf4b12 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -361,7 +361,7 @@ void damon_free_target(struct damon_target *t) > struct damon_region *r, *next; > > damon_for_each_region_safe(r, next, t) > - damon_free_region(r); > + damon_destroy_region(r, t); > kfree(t); > } > > -- > 2.25.1