From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFEE1C54EE9 for ; Wed, 14 Sep 2022 01:21:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45B518D0001; Tue, 13 Sep 2022 21:21:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40A636B0073; Tue, 13 Sep 2022 21:21:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D1878D0001; Tue, 13 Sep 2022 21:21:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1B8CC6B0071 for ; Tue, 13 Sep 2022 21:21:51 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D911114045F for ; Wed, 14 Sep 2022 01:21:50 +0000 (UTC) X-FDA: 79908939180.06.7E749E4 Received: from mail.nfschina.com (unknown [124.16.136.209]) by imf13.hostedemail.com (Postfix) with ESMTP id 940FB2009E for ; Wed, 14 Sep 2022 01:21:49 +0000 (UTC) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id 8CD771E80D5E; Wed, 14 Sep 2022 09:19:34 +0800 (CST) X-Virus-Scanned: amavisd-new at test.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (mail.nfschina.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ifbq9yNsUG8n; Wed, 14 Sep 2022 09:19:32 +0800 (CST) Received: from localhost.localdomain.localdomain (unknown [219.141.250.2]) (Authenticated sender: xupengfei@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id B06711E80D58; Wed, 14 Sep 2022 09:19:31 +0800 (CST) From: XU pengfei To: mike.kravetz@oracle.com, songmuchun@bytedance.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, XU pengfei Subject: [PATCH 1/1] mm/hugetlb: Remove unnecessary 'NULL' values from Pointer Date: Wed, 14 Sep 2022 09:21:14 +0800 Message-Id: <20220914012113.6271-1-xupengfei@nfschina.com> X-Mailer: git-send-email 2.18.2 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663118510; a=rsa-sha256; cv=none; b=LlTrIWAnfskt0V2jhid5pWHj0tkohC6tymmrNd8CyOhvNV7peglJsut4+pdD+7iqEBE/9F BYQYmykr3YTnM01LCBIZUKKPoSxwC7b2hqpMWuo72Iw5SZ08itvQLjHpjpPKjd0KbxwW8x grhd/5waECQLqjJeeqGJyrPS2RV6KMQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=none; spf=none (imf13.hostedemail.com: domain of xupengfei@nfschina.com has no SPF policy when checking 124.16.136.209) smtp.mailfrom=xupengfei@nfschina.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663118510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=s+NpRRd30KZbhoU8Kq+ChKPrJ+iu3zBasORTuwmzU6Y=; b=Gm0DAzmsrfc3Tm1JtYPYmAC5U5g2alAcWz0PVuLfFZSolkuBRkwrJU8YRClKr6D0zaDcZt LnAdt8BOOUcAAUx1wYwbUYWmyTVeb8vZECK82bZ0Eyi/m6BK6hY/Hx3SLpOkYj8lNm3+j4 7QTc01eU4msmuY1LMpv98NEBXafitvM= X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=none (imf13.hostedemail.com: domain of xupengfei@nfschina.com has no SPF policy when checking 124.16.136.209) smtp.mailfrom=xupengfei@nfschina.com X-Rspamd-Server: rspam11 X-Stat-Signature: 6zt5gfaos68dc3jyf6543up7w1g9bfwd X-Rspamd-Queue-Id: 940FB2009E X-HE-Tag: 1663118509-382125 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Pointer variables allocate memory first, and then judge. There is no need to initialize the assignment. Signed-off-by: XU pengfei --- mm/hugetlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index e070b8593b37..a05f22b1ab1e 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -257,7 +257,7 @@ static inline struct hugepage_subpool *subpool_vma(struct vm_area_struct *vma) static struct file_region * get_file_region_entry_from_cache(struct resv_map *resv, long from, long to) { - struct file_region *nrg = NULL; + struct file_region *nrg; VM_BUG_ON(resv->region_cache_count <= 0); @@ -339,7 +339,7 @@ static bool has_same_uncharge_info(struct file_region *rg, static void coalesce_file_region(struct resv_map *resv, struct file_region *rg) { - struct file_region *nrg = NULL, *prg = NULL; + struct file_region *nrg, *prg; prg = list_prev_entry(rg, link); if (&prg->link != &resv->regions && prg->to == rg->from && -- 2.18.2