From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B134BC6FA83 for ; Mon, 12 Sep 2022 19:28:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A23494000E; Mon, 12 Sep 2022 15:28:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4511D80007; Mon, 12 Sep 2022 15:28:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F1F594000F; Mon, 12 Sep 2022 15:28:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 204ED94000E for ; Mon, 12 Sep 2022 15:28:25 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F2E471A0539 for ; Mon, 12 Sep 2022 19:28:24 +0000 (UTC) X-FDA: 79904419728.28.ABFE2A3 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf05.hostedemail.com (Postfix) with ESMTP id 94F861000A5 for ; Mon, 12 Sep 2022 19:28:24 +0000 (UTC) Received: from pps.filterd (m0148461.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28CHvInA002614 for ; Mon, 12 Sep 2022 12:28:23 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=facebook; bh=ChjfSENQchEUBM4cPfbpSt1QO05k//yXuIWwWjuVJaY=; b=pakKpLO8FmSLNVjyONwmzsdGLp6w8Oudhf6n+b+BgYnfg8b90pWxLv3VfkmjBcFKxQ+B qMGy566NT/Qco6I7r5FApmAPpc+uU+pblE+sjHP64Bi9VDaWoZLuvbDsEQ71cZCFn9GG Jz89GMOfT1CUkdhjSiYSVKlp99qgoUJKddw= Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3jgqpv4n85-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 12 Sep 2022 12:28:23 -0700 Received: from twshared13579.04.prn5.facebook.com (2620:10d:c085:108::4) by mail.thefacebook.com (2620:10d:c085:21d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 12 Sep 2022 12:28:22 -0700 Received: by dev1180.prn1.facebook.com (Postfix, from userid 425415) id 311CF208523E; Mon, 12 Sep 2022 12:27:54 -0700 (PDT) From: Stefan Roesch To: , , , CC: , , , Subject: [PATCH v3 12/12] btrfs: enable nowait async buffered writes Date: Mon, 12 Sep 2022 12:27:52 -0700 Message-ID: <20220912192752.3785061-13-shr@fb.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220912192752.3785061-1-shr@fb.com> References: <20220912192752.3785061-1-shr@fb.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-GUID: o95C-2mS11zcqIKxeLF_PPwxQwRRxWWo X-Proofpoint-ORIG-GUID: o95C-2mS11zcqIKxeLF_PPwxQwRRxWWo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-12_12,2022-09-12_02,2022-06-22_01 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663010904; a=rsa-sha256; cv=none; b=fo9iNKSQ7cqnjtFbeDQFYP4/NiiJOVO18i313lGMrK4pfZZDi/lMA2yLhJKvRl8oEiEac5 riPJWC3ZBQdI0jEA+k2JelpEtPECEmmSQnBvwF93yXJRtAm+/Qm8LgFxXwXHogHXIbLd5y /sohF4aSrIehMy5wIRn+kLEfgegPYiw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=fb.com header.s=facebook header.b=pakKpLO8; dmarc=pass (policy=reject) header.from=fb.com; spf=pass (imf05.hostedemail.com: domain of "prvs=025416ff2e=shr@fb.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=025416ff2e=shr@fb.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663010904; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ChjfSENQchEUBM4cPfbpSt1QO05k//yXuIWwWjuVJaY=; b=5M8x7S8VEleUk1E1GySGWCHNVsDZHYviuHZMlvTc+KbQ5rR9MNAkT5MkxqDmg0Te0Wmop7 BEmmvMxYIurc5mPwaLMU6SkcMRXUONR0My2KUj8aK5YSnoHXE8QCot9GTHvCt1T7BLZ7Em X+YJrgU0ITDqq2cSI1H1rXOCps01tSQ= X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 94F861000A5 X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=fb.com header.s=facebook header.b=pakKpLO8; dmarc=pass (policy=reject) header.from=fb.com; spf=pass (imf05.hostedemail.com: domain of "prvs=025416ff2e=shr@fb.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=025416ff2e=shr@fb.com" X-Stat-Signature: 4gygjeu3zmbrwhq6jhr7cy5sk56rjkk3 X-HE-Tag: 1663010904-643461 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Enable nowait async buffered writes in btrfs_do_write_iter() and btrfs_file_open(). In this version encoded buffered writes have the optimization not enabled. Encoded writes are enabled by using an ioctl. io-uring currently do not support ioctl's. This might be enabled in the future. Performance results: For fio the following results have been obtained with a queue depth of 1 and 4k block size (runtime 600 secs): sequential writes: without patch with patch libaio psync iops: 55k 134k 117K 148K bw: 221MB/s 538MB/s 469MB/s 592M= B/s clat: 15286ns 82ns 994ns 6340n= s For an io depth of 1, the new patch improves throughput by over two times (compared to the exiting behavior, where buffered writes are processed by= an io-worker process) and also the latency is considerably reduced. To achie= ve the same or better performance with the exisiting code an io depth of 4 is re= quired. Increasing the iodepth further does not lead to improvements. The tests have been run like this: ./fio --name=3Dseq-writers --ioengine=3Dpsync --iodepth=3D1 --rw=3Dwrite = \ --bs=3D4k --direct=3D0 --size=3D100000m --time_based --runtime=3D600 = \ --numjobs=3D1 --filename=3D... ./fio --name=3Dseq-writers --ioengine=3Dio_uring --iodepth=3D1 --rw=3Dwri= te \ --bs=3D4k --direct=3D0 --size=3D100000m --time_based --runtime=3D600 = \ --numjobs=3D1 --filename=3D... ./fio --name=3Dseq-writers --ioengine=3Dlibaio --iodepth=3D1 --rw=3Dwrite= \ --bs=3D4k --direct=3D0 --size=3D100000m --time_based --runtime=3D600 = \ --numjobs=3D1 --filename=3D... Testing: This patch has been tested with xfstests, fsx, fio. xfstests shows no n= ew diffs compared to running without the patch series. Signed-off-by: Stefan Roesch --- fs/btrfs/file.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 4dc6484ff229..16052903fa82 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c @@ -2107,13 +2107,13 @@ ssize_t btrfs_do_write_iter(struct kiocb *iocb, s= truct iov_iter *from, if (BTRFS_FS_ERROR(inode->root->fs_info)) return -EROFS; =20 - if ((iocb->ki_flags & IOCB_NOWAIT) && !(iocb->ki_flags & IOCB_DIRECT)) - return -EOPNOTSUPP; - if (sync) atomic_inc(&inode->sync_writers); =20 if (encoded) { + if (iocb->ki_flags & IOCB_NOWAIT) + return -EOPNOTSUPP; + num_written =3D btrfs_encoded_write(iocb, from, encoded); num_sync =3D encoded->len; } else if (iocb->ki_flags & IOCB_DIRECT) { @@ -3755,7 +3755,7 @@ static int btrfs_file_open(struct inode *inode, str= uct file *filp) { int ret; =20 - filp->f_mode |=3D FMODE_NOWAIT | FMODE_BUF_RASYNC; + filp->f_mode |=3D FMODE_NOWAIT | FMODE_BUF_RASYNC | FMODE_BUF_WASYNC; =20 ret =3D fsverity_file_open(inode, filp); if (ret) --=20 2.30.2