From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79FA0ECAAD5 for ; Mon, 12 Sep 2022 08:34:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5E4A8D0003; Mon, 12 Sep 2022 04:34:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0E3E8D0001; Mon, 12 Sep 2022 04:34:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD5C78D0003; Mon, 12 Sep 2022 04:34:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A053B8D0001 for ; Mon, 12 Sep 2022 04:34:01 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 739EA1207FD for ; Mon, 12 Sep 2022 08:34:01 +0000 (UTC) X-FDA: 79902770682.09.46C0A47 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf05.hostedemail.com (Postfix) with ESMTP id 891961000A2 for ; Mon, 12 Sep 2022 08:34:00 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 3E45768C7B; Mon, 12 Sep 2022 10:33:54 +0200 (CEST) Date: Mon, 12 Sep 2022 10:33:53 +0200 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Jens Axboe , Johannes Weiner , Suren Baghdasaryan , Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-mm@kvack.org Subject: Re: [PATCH 1/5] mm: add PSI accounting around ->read_folio and ->readahead calls Message-ID: <20220912083353.GA11318@lst.de> References: <20220910065058.3303831-1-hch@lst.de> <20220910065058.3303831-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662971640; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HwBofHi127G+fs9rJapzAYkICzV0aL2FTnSNTkBf6TI=; b=mKuff5lUxSYaDAm22Km7MIq+WM7iXB+4VT+vzxZPZY1h6lZ/2KS+Dag3o68yazUdez6210 6FQwil1uZDNTmXFSI58Bd/H/FUQzKW++ABgS6uaxf2ZpBhVkYmDhkGwGGWLBKL87/Ltusq w0xILkAOxYzfb82fWbOU/6AR5t7YlQE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=none (imf05.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662971640; a=rsa-sha256; cv=none; b=uBlPJBQYV5TNquHh3zmmxsVrN2/+56XvqInnIwhRUVg1neAW4Mfx9Pw1vlwO06ibeoPiPW RlGIInd1T9fvEE0B8k1B3ebS3/J3BAcAr4bYA4+2jCUaBeMGrfwcf4O5UvpR+/98ZLYU4J CX80aYCfMn0vBoiPmCZo0Sdd3aF1i5w= X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=none; spf=none (imf05.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspamd-Server: rspam06 X-Stat-Signature: 463tj4nn4caszfhxas4grgr5kzmm366a X-Rspamd-Queue-Id: 891961000A2 X-HE-Tag: 1662971640-828797 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Sep 10, 2022 at 07:26:35PM +0100, Matthew Wilcox wrote: > I don't have time to look at this properly right now (about to catch a > bus to the plane), but I think this should be |=, not =? Yes.