From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD9CCECAAA1 for ; Fri, 9 Sep 2022 23:00:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F6158D0003; Fri, 9 Sep 2022 19:00:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A5BC8D0002; Fri, 9 Sep 2022 19:00:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06DCD8D0003; Fri, 9 Sep 2022 19:00:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E960A8D0002 for ; Fri, 9 Sep 2022 19:00:31 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BBBD5140824 for ; Fri, 9 Sep 2022 23:00:31 +0000 (UTC) X-FDA: 79894067862.25.A06E62A Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf27.hostedemail.com (Postfix) with ESMTP id 45DA1400DA for ; Fri, 9 Sep 2022 23:00:30 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D5093CE24DB; Fri, 9 Sep 2022 23:00:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D264DC433D6; Fri, 9 Sep 2022 23:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662764424; bh=f/7dJ5txgGxEVcbNQbggz7c0bBv4vFnX6giz7/h7ftA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s/vk82qK4O+vymiABD4L2SfJe9CfTJlUDAy5G7oIRlyj3Prygy5S27vbNAXVFhKJA oAbjjcTp5S0fatq2klxDqoBs0OX0vB0pY/nYc/KJx/i3WBcKSCeaNhnxPDgJDQngbU NzOM5kWmqpls5cHBHrOZMdANEfK8qittiqo28ob1UGYQyTbdY3hEe6DHPpAqkZbeeo HL0WJplG7wBxIah4XUlpMZO8Ru/uKeDFogzsZLnGCdNrbaDXYfai4nEM41p6IfpKhE E9mEi6PUNZbDedqcATGtGQNbo0LgeV/VmT9yWrde/T1JGZW9Vt85YQ2cRaXfPRc7Nm rhEbzYWiyZAjw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Xin Hao , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon/sysfs: change few functions execute order Date: Fri, 9 Sep 2022 23:00:22 +0000 Message-Id: <20220909230022.51436-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220909154434.5870e33657a11d53320861e7@linux-foundation.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662764430; a=rsa-sha256; cv=none; b=7VM7EU3raMTjrDH3NY9Kr4bsymgwB1ZgdwrZArP8O0u99q+pdhvbD7Bs/MOH2+zvNGPrSs a2yyiX4nauZ251Z/h7KGlEvTyvbWxhAsLpTu/aT0z3kXNlYXizarmdyAt5h0Au3rR5Rccm eoN+/CdAeFxAAUDs71u85STD8dv2Q1M= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="s/vk82qK"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662764430; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yKH5j0h0EXjk8r0iKI0Bys5aZmebvxHwDwZ7OcQ6s1c=; b=WvofG20lKoU4bO7VxfPdGI4JEu+cnfXcakDoTAC3p7EpEkQVLaLjdR9qkqxpn6zN0z+2TJ 0tewCTWCo5h2sLZgvAVGfp9a9vPq9RHGD/Gw4T94Dk2RVc7H0OdVX/HX1sp8u3gUuC826B 2uojv/ZxcnGbM53CXZibMKIBA48WqwI= X-Stat-Signature: zn33qpt8qff493sirtbwcmux3qjw3kw1 X-Rspamd-Queue-Id: 45DA1400DA Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="s/vk82qK"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org X-Rspam-User: X-Rspamd-Server: rspam03 X-HE-Tag: 1662764430-322541 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 9 Sep 2022 15:44:34 -0700 Andrew Morton wrote: > On Thu, 8 Sep 2022 22:16:53 +0000 SeongJae Park wrote: > > > Reviewed-by: SeongJae Park > > Cool. I rewrote the changelog significantly: > > From: Xin Hao > Subject: mm/damon/sysfs: change few functions execute order > Date: Thu, 8 Sep 2022 16:19:32 +0800 > > There's no need to run container_of() as early as we do. > > The compiler figures this out, but the resulting code is more readable. Looks very nice to me. Thank you, Andrew! Thanks, SJ [...]