linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>, Xin Hao <xhao@linux.alibaba.com>,
	damon@lists.linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/damon/sysfs: change few functions execute order
Date: Fri,  9 Sep 2022 23:00:22 +0000	[thread overview]
Message-ID: <20220909230022.51436-1-sj@kernel.org> (raw)
In-Reply-To: <20220909154434.5870e33657a11d53320861e7@linux-foundation.org>

On Fri, 9 Sep 2022 15:44:34 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:

> On Thu,  8 Sep 2022 22:16:53 +0000 SeongJae Park <sj@kernel.org> wrote:
> 
> > Reviewed-by: SeongJae Park <sj@kernel.org>
> 
> Cool.  I rewrote the changelog significantly:
> 
> From: Xin Hao <xhao@linux.alibaba.com>
> Subject: mm/damon/sysfs: change few functions execute order
> Date: Thu, 8 Sep 2022 16:19:32 +0800
> 
> There's no need to run container_of() as early as we do.
> 
> The compiler figures this out, but the resulting code is more readable.

Looks very nice to me.  Thank you, Andrew!


Thanks,
SJ

[...]


  reply	other threads:[~2022-09-09 23:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-08  8:19 Xin Hao
2022-09-08 18:49 ` SeongJae Park
2022-09-08 22:10   ` Andrew Morton
2022-09-08 22:16     ` SeongJae Park
2022-09-09 22:44       ` Andrew Morton
2022-09-09 23:00         ` SeongJae Park [this message]
2022-09-10  1:04         ` haoxin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220909230022.51436-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=xhao@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox