From: Andrew Morton <akpm@linux-foundation.org>
To: Liu Shixin <liushixin2@huawei.com>
Cc: "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: Re: [PATCH v3] mm/huge_memory: prevent THP_ZERO_PAGE_ALLOC increased twice
Date: Fri, 9 Sep 2022 15:25:41 -0700 [thread overview]
Message-ID: <20220909152541.dff88a98938258f09c46dcd0@linux-foundation.org> (raw)
In-Reply-To: <20220909021653.3371879-1-liushixin2@huawei.com>
On Fri, 9 Sep 2022 10:16:53 +0800 Liu Shixin <liushixin2@huawei.com> wrote:
> Since user who read THP_ZERO_PAGE_ALLOC may be more concerned about the
> huge zero pages that are really allocated using for thp and can indicated
> the times of calling huge_zero_page_shrinker. It is misleading to increase
> twice if two threads call get_huge_zero_page concurrently. Don't increase
> the value if the huge page is not really used.
>
I cant say I really understand the point about
huge_zero_page_shrinker(), so I propose this changelog:
: A user who reads THP_ZERO_PAGE_ALLOC may be more concerned about the huge
: zero pages that are really allocated for thp. It is misleading to
: increase THP_ZERO_PAGE_ALLOC twice if two threads call get_huge_zero_page
: concurrently. Don't increase the value if the huge page is not really
: used.
The patch makes sense to me. What do others think?
prev parent reply other threads:[~2022-09-09 22:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 2:16 Liu Shixin
2022-09-09 22:25 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220909152541.dff88a98938258f09c46dcd0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox