From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9132FECAAD3 for ; Fri, 9 Sep 2022 20:36:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 283BC8D0003; Fri, 9 Sep 2022 16:36:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 232B78D0002; Fri, 9 Sep 2022 16:36:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 121BC8D0003; Fri, 9 Sep 2022 16:36:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 036D68D0002 for ; Fri, 9 Sep 2022 16:36:04 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D6BB91A0399 for ; Fri, 9 Sep 2022 20:36:03 +0000 (UTC) X-FDA: 79893703806.22.53A1A33 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf29.hostedemail.com (Postfix) with ESMTP id 78AAF1200BC for ; Fri, 9 Sep 2022 20:36:03 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 17344B82521; Fri, 9 Sep 2022 20:36:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93C08C433D6; Fri, 9 Sep 2022 20:36:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1662755760; bh=Cnti9Y8GyDozUYB5ZKkg5wCa1xKYEhlok93I5a16qiA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ff3FaeRpyirCK3Zm15MUV6Jj9st/yK2qwzQXaOu8FTT5826q1LNHCCrSKs4r54XX9 VtY05XHByxoeS0OWTepNDHXTFpTEuC6orR66tQSfov3islbqgfAA4WxRvOCFQz6P80 i85ncBbWhsk5hww8zXrTQe6pmrPvUyYBPpSDb5mg= Date: Fri, 9 Sep 2022 13:35:59 -0700 From: Andrew Morton To: Christoph Hellwig Cc: konrad.wilk@oracle.com, liushixin2@huawei.com, linux-mm@kvack.org, Nathan Chancellor Subject: Re: [PATCH] frontswap: don't call ->init if no ops are registered Message-Id: <20220909133559.3f4591f901ed92270cf08fee@linux-foundation.org> In-Reply-To: <20220909130829.3262926-1-hch@lst.de> References: <20220909130829.3262926-1-hch@lst.de> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662755763; a=rsa-sha256; cv=none; b=Jg+hiGEa8tWJtKLxXvzUDNKHxqB/w7pbaAH/xhq/WBWciRxvl6pVjibOuNkbXXf9yH1Dsi xa16BBm6yKyb9CkMNwbJuToZDB06At4aPiwnLuSkZwL1QhcHsTqz1yvIcx2gYBJCHw3hSO VtGtzhcHhfzH0MEa4YkCM3pCdIjVQZM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ff3FaeRp; dmarc=none; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662755763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U3SnfeY42Fnb8VWQFaqJQW3X4ZmZmIMws/IxjfMtTjo=; b=YXOC90LHxssmOaf43I7iaU4SocJqD+sy8QYG6iJKa4RHvkvwLpngtLFij/M9EQ6KGcXCfg OHajrCbJcIJQOxF9w9KMFio3SFx46otEJbGSHkv7tnNot7sJN8OO9tH3X0QjhWNLnIiR7p Ajlfa/5rDpc9F5Gth8ZDDTiDySVG570= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 78AAF1200BC Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ff3FaeRp; dmarc=none; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: xye589z6psioqwskewsicw8mf6uqxtec X-Rspam-User: X-HE-Tag: 1662755763-924266 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 9 Sep 2022 15:08:29 +0200 Christoph Hellwig wrote: > This is the non-invaside fix the frontswap regression, instead of the > massively overreaching revert from Liu, Thanks. I dropped the v4 "Delay the initializaton of zswap" series. I'll push the result out later today. Liu, can you please prepare a new version of your "Delay the initializaton of zswap" series, based on the mm-unstable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm?