From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 046D3C54EE9 for ; Thu, 8 Sep 2022 22:16:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E08C8D0006; Thu, 8 Sep 2022 18:16:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 790208D0001; Thu, 8 Sep 2022 18:16:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6813E8D0006; Thu, 8 Sep 2022 18:16:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 599BF8D0001 for ; Thu, 8 Sep 2022 18:16:59 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 319B51202BE for ; Thu, 8 Sep 2022 22:16:59 +0000 (UTC) X-FDA: 79890329358.31.B651AF0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 2F96EC0074 for ; Thu, 8 Sep 2022 22:16:57 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7DEFC61998; Thu, 8 Sep 2022 22:16:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63755C433C1; Thu, 8 Sep 2022 22:16:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662675415; bh=JE10mbUSQvV4SLEVtxGEewRCL7LxHQ8Z4Hk4Ug6Gx40=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bqNr4u8E7dl2ZhOS8hXrXPNG6imPpAFM+Tm1VQ8hnxaegmOa2M82ra44QQRl7/JIa WmrPKGvDyepk0B6onw7WPRU3Dbpc2DFUyD2EeyhDrmbvLZ4kdq5CTsFhBp4p5gSNFd SRHwFAr9HSNX8Eb2fndf9HjwrLKHrW3jMHWbWu7DETrZcEp9+1CVPspNcV8xv3Hb6g A/rOrbpG+IyCjtG1F7pTuVdkEXSoNWON5b7Ns7+WkHmpMKKFtriaH3JehvE8D8kS+3 gAjoBjzWqZkdnO7y0lNbwA7zehcDhXhJ8dh2dDRUCQ4b82+/zBB2Ii4R1woupaxmx0 dB1JwodMRvxzw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Xin Hao , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon/sysfs: change few functions execute order Date: Thu, 8 Sep 2022 22:16:53 +0000 Message-Id: <20220908221653.131120-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220908151042.239189ddb1635c0f598c6fd2@linux-foundation.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662675417; a=rsa-sha256; cv=none; b=Mimpe7IZUsMlzeLGrkXlHZXZahi5+NaPHXUDzA+Qqvk6SsoBVehSV6AH64yh4JYA1FoOz/ 8u2I64hKd59Yn7JGMllZkMbANL/qnYxH1U2z62qQAy6JnbYr22q2+KOezDf9icog2tY0o/ Ori4s1CsSbB5SILjWLqEzwPIAMMw3FU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bqNr4u8E; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662675417; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gkmMtPqC7513d0tSBKGmUD4NI3HAlA7Tj0fAvSyDceg=; b=HaQ/fgEvtMqhRQIOHn9+eXYAeD9uDZZFSucNjhCAWwYIARWSSQ9WndV7vNrvA4lNadjzoc +LsrMwzOm0EUcVCKvPEpdbhRSlbZ9wbIPOE0MUgYJKBhUt0nlZB++II42/44CA7ypyGWvB l5vpaHU0SvXG9JzlbQ7PldzRAjtlU0U= X-Stat-Signature: wfmzqgk7uci5ogmyc81hptwfcj58dyom X-Rspam-User: X-Rspamd-Queue-Id: 2F96EC0074 X-Rspamd-Server: rspam07 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bqNr4u8E; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1662675417-222218 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 8 Sep 2022 15:10:42 -0700 Andrew Morton wrote: > On Thu, 8 Sep 2022 18:49:47 +0000 SeongJae Park wrote: > > > Hi Xin, > > > > On Thu, 8 Sep 2022 16:19:32 +0800 Xin Hao wrote: > > > > > These nr_{schemes,regions,contexts,kdamonds}_store() functions are both call > > > > checkpatch complains as below: > > > > WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) > > #10: > > These nr_{schemes,regions,contexts,kdamonds}_store() functions are both call > > I fix that sort of thing. A lot ;) Appreciate your efforts always. If you need any help from my side, please let me know at any time. > > > > kstrtoint() to get relative values from sysfs interface, if it return an > > > error, there get kobject instance would be meaningless through 'container_of'. > > > > I was thinking the compiler could do that kind of optimization on its own, so I > > preferred to make the code shorter. > > Yes, the compiler will do this. > > > This change makes the code slightly longer, while the benefit of the change is > > unclear. I'd like to keep it as is unless we get some clear benefit of this? > > I find it a readability improvement. Puts the initialization in a more > appropriate place and avoids those nasty tricks to prevent unreasonable > line lengths. Agreed. Reviewed-by: SeongJae Park Thanks, SJ