From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4784FC38145 for ; Thu, 8 Sep 2022 18:49:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DFF16B0073; Thu, 8 Sep 2022 14:49:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 966706B0074; Thu, 8 Sep 2022 14:49:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E0EF8D0002; Thu, 8 Sep 2022 14:49:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6AA0E6B0073 for ; Thu, 8 Sep 2022 14:49:54 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4432AABACE for ; Thu, 8 Sep 2022 18:49:54 +0000 (UTC) X-FDA: 79889807508.20.666E5B0 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf21.hostedemail.com (Postfix) with ESMTP id AA70F1C0087 for ; Thu, 8 Sep 2022 18:49:53 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DCE92B821A0; Thu, 8 Sep 2022 18:49:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12022C433D7; Thu, 8 Sep 2022 18:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662662990; bh=9blEcl+kQyexkHeFxKpL4hVCHMxyX6MRyBgDynt2ggA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LUYMF6ihxRMbLcvAo6bo2tuSSmkMIp+xGcGekfAMRsJYAgB2hx3pUoob0W9ZShep4 7xx/DZ/EZc5vgUVSoMNN7y1PT7Tri5U9UjSmREmB261CbfPx108eUd4pihulssseze yFRu7JUKS3AxNeF5JUMc+MSIyphZIyLh/kNTS2pWhCOkR6a8vGNrBfCiKR6OmnX27+ z7UcDie4z0fmoQOy8gw9D8x0XXdgOiCT17IVj3ePqmRnd1VsQ86XVtJFJbsY0nlrk+ f/8qHDKwjwVyfOW9H/YgqUTq1nffhfYpZeyojGYCB/v/DaIQYFELps/7O9uHmitbdD EdkJ9T5DOMQRA== From: SeongJae Park To: Xin Hao Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon/sysfs: change few functions execute order Date: Thu, 8 Sep 2022 18:49:47 +0000 Message-Id: <20220908184947.103206-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220908081932.77370-1-xhao@linux.alibaba.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662662993; a=rsa-sha256; cv=none; b=OBM7jOEkqtM7okc6sQr4nwE6yz+tIYC7cKUafAD/wvPay2usPflBF0A2aXSrLWhOdD1VJc VavsTY7GrYtQX1bsFJUD9oQcRqvywaqIeVntaCVC65jZ5TBAEtd12Loj3KtajursHpr0Ha gl7J7qv5HxTqoguGqHt9C2bd+FHciSs= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LUYMF6ih; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662662993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jqILK8ev/qpLWoB3txp9klsB+8AIPcpeStLWfPzD6Zo=; b=Y0uml7stXOy6XLck3zNkEhv7YoqcWa7A3f9nGqjM1efyLxsbhYwWyFJjW/65HFEgpszvk1 vvx2RIgYvyO7uaeR3thEzVWkMdqFJEhmj37iyVXhaZjp+zieanXvkzZDXd099Itz8ydZEF mQu1KnZkm6CKli0t6oz3m6Sk2tAOefI= X-Rspam-User: X-Stat-Signature: uwc7k571bdndfmu5f4wpy7qd3caxjtiq X-Rspamd-Queue-Id: AA70F1C0087 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LUYMF6ih; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org X-Rspamd-Server: rspam05 X-HE-Tag: 1662662993-316463 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Xin, On Thu, 8 Sep 2022 16:19:32 +0800 Xin Hao wrote: > These nr_{schemes,regions,contexts,kdamonds}_store() functions are both call checkpatch complains as below: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #10: These nr_{schemes,regions,contexts,kdamonds}_store() functions are both call > kstrtoint() to get relative values from sysfs interface, if it return an > error, there get kobject instance would be meaningless through 'container_of'. I was thinking the compiler could do that kind of optimization on its own, so I preferred to make the code shorter. This change makes the code slightly longer, while the benefit of the change is unclear. I'd like to keep it as is unless we get some clear benefit of this? Thanks, SJ > > Signed-off-by: Xin Hao > --- > mm/damon/sysfs.c | 24 ++++++++++++++---------- > 1 file changed, 14 insertions(+), 10 deletions(-) > > diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c > index 88f208ff235d..54fdfcdbb3e4 100644 > --- a/mm/damon/sysfs.c > +++ b/mm/damon/sysfs.c > @@ -1031,8 +1031,7 @@ static ssize_t nr_schemes_show(struct kobject *kobj, > static ssize_t nr_schemes_store(struct kobject *kobj, > struct kobj_attribute *attr, const char *buf, size_t count) > { > - struct damon_sysfs_schemes *schemes = container_of(kobj, > - struct damon_sysfs_schemes, kobj); > + struct damon_sysfs_schemes *schemes; > int nr, err = kstrtoint(buf, 0, &nr); > > if (err) > @@ -1040,6 +1039,8 @@ static ssize_t nr_schemes_store(struct kobject *kobj, > if (nr < 0) > return -EINVAL; > > + schemes = container_of(kobj, struct damon_sysfs_schemes, kobj); > + > if (!mutex_trylock(&damon_sysfs_lock)) > return -EBUSY; > err = damon_sysfs_schemes_add_dirs(schemes, nr); > @@ -1237,8 +1238,7 @@ static ssize_t nr_regions_show(struct kobject *kobj, > static ssize_t nr_regions_store(struct kobject *kobj, > struct kobj_attribute *attr, const char *buf, size_t count) > { > - struct damon_sysfs_regions *regions = container_of(kobj, > - struct damon_sysfs_regions, kobj); > + struct damon_sysfs_regions *regions; > int nr, err = kstrtoint(buf, 0, &nr); > > if (err) > @@ -1246,6 +1246,8 @@ static ssize_t nr_regions_store(struct kobject *kobj, > if (nr < 0) > return -EINVAL; > > + regions = container_of(kobj, struct damon_sysfs_regions, kobj); > + > if (!mutex_trylock(&damon_sysfs_lock)) > return -EBUSY; > err = damon_sysfs_regions_add_dirs(regions, nr); > @@ -1440,8 +1442,7 @@ static ssize_t nr_targets_show(struct kobject *kobj, > static ssize_t nr_targets_store(struct kobject *kobj, > struct kobj_attribute *attr, const char *buf, size_t count) > { > - struct damon_sysfs_targets *targets = container_of(kobj, > - struct damon_sysfs_targets, kobj); > + struct damon_sysfs_targets *targets; > int nr, err = kstrtoint(buf, 0, &nr); > > if (err) > @@ -1449,6 +1450,8 @@ static ssize_t nr_targets_store(struct kobject *kobj, > if (nr < 0) > return -EINVAL; > > + targets = container_of(kobj, struct damon_sysfs_targets, kobj); > + > if (!mutex_trylock(&damon_sysfs_lock)) > return -EBUSY; > err = damon_sysfs_targets_add_dirs(targets, nr); > @@ -1962,8 +1965,7 @@ static ssize_t nr_contexts_show(struct kobject *kobj, > static ssize_t nr_contexts_store(struct kobject *kobj, > struct kobj_attribute *attr, const char *buf, size_t count) > { > - struct damon_sysfs_contexts *contexts = container_of(kobj, > - struct damon_sysfs_contexts, kobj); > + struct damon_sysfs_contexts *contexts; > int nr, err; > > err = kstrtoint(buf, 0, &nr); > @@ -1973,6 +1975,7 @@ static ssize_t nr_contexts_store(struct kobject *kobj, > if (nr < 0 || 1 < nr) > return -EINVAL; > > + contexts = container_of(kobj, struct damon_sysfs_contexts, kobj); > if (!mutex_trylock(&damon_sysfs_lock)) > return -EBUSY; > err = damon_sysfs_contexts_add_dirs(contexts, nr); > @@ -2741,8 +2744,7 @@ static ssize_t nr_kdamonds_show(struct kobject *kobj, > static ssize_t nr_kdamonds_store(struct kobject *kobj, > struct kobj_attribute *attr, const char *buf, size_t count) > { > - struct damon_sysfs_kdamonds *kdamonds = container_of(kobj, > - struct damon_sysfs_kdamonds, kobj); > + struct damon_sysfs_kdamonds *kdamonds; > int nr, err; > > err = kstrtoint(buf, 0, &nr); > @@ -2751,6 +2753,8 @@ static ssize_t nr_kdamonds_store(struct kobject *kobj, > if (nr < 0) > return -EINVAL; > > + kdamonds = container_of(kobj, struct damon_sysfs_kdamonds, kobj); > + > if (!mutex_trylock(&damon_sysfs_lock)) > return -EBUSY; > err = damon_sysfs_kdamonds_add_dirs(kdamonds, nr); > -- > 2.31.0