From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D790C54EE9 for ; Thu, 8 Sep 2022 18:01:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F2BF8D0001; Thu, 8 Sep 2022 14:01:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97B9E6B0073; Thu, 8 Sep 2022 14:01:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81CE98D0001; Thu, 8 Sep 2022 14:01:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6FDB56B0072 for ; Thu, 8 Sep 2022 14:01:21 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 484F01A0342 for ; Thu, 8 Sep 2022 18:01:21 +0000 (UTC) X-FDA: 79889685162.05.1B4F634 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf31.hostedemail.com (Postfix) with ESMTP id DA77D2009D for ; Thu, 8 Sep 2022 18:01:20 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8C9BFB8219F; Thu, 8 Sep 2022 18:01:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9ED4C433D6; Thu, 8 Sep 2022 18:01:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662660078; bh=Eyd2f05euQSrEzSKY+ufNZEqbz628QYuj+cOfZCVgsI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N3ufNtX2TZLK5JUIePjDK/1DoHi233A3+qec1xZgYh2N7ixgnrTO4VcB4hnjvfFwj XV8+G/lxu0GdoLUSgUorkwnCUgQqdLOiJxRJz/NGKhA7td8zTjQOC7jgWTlHj+pJIw gyU/iwWIKsVY/uYiPEZSQ/JyJpu/YxNeS8m6RyOgRvj/u0sWBXdm9I4CeFg3aUJ+iO +V/nPDixo8kMEWsf6mEy2ag7d6SJKQxdVN9PpN29oOE5VHk1LCMtwa3Tu/Ypba4kZ6 BU7pOZe4oe1u9Rnn/ZlAFEs4FrpBKRk4aM3y4b7ixvteaIiKG3qhyyYYC1aU4ioySJ m1eYt6wAH+12Q== From: SeongJae Park To: Xin Hao Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] mm/damon: simplify damon_ctx check in damon_sysfs_before_terminate Date: Thu, 8 Sep 2022 18:01:15 +0000 Message-Id: <20220908180116.33879-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220908021912.70481-1-xhao@linux.alibaba.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662660081; a=rsa-sha256; cv=none; b=5UhjTolyb/PLkHhIO1PB+nXA6eJHl6hlOoSX741ecoxbooXU6amYJ7f33hCGPw4N1MAHsY I7OJxnEZaT2ihfIyqkeIeZWQQAa8eFvOCHvlZUrbBzSJcA9GLSIv9tUDswA39zdn8dOVHB znAG+Rkzq40aOWr48i7l9KqnrtxAnrI= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N3ufNtX2; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf31.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662660081; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cmefy7b78YIG5emItUt9gXKKCOfJHfnHJruqTMR4XK4=; b=Kn3dpMXgsrg1UwOi8tzO+4KrcE5LMXGz6NMhZ+fTCY+6deEGcLRZXFOyIBM5kTzb93uxhL g/ZWCXDlLX6yHDqTkHrFygFT2PCgy3sJ+e/dK7vM2/gISobVCtI4WuhsIXCz8SRBf5dmJB PWexdmB1prYyGB2hDPP1KuJ1UEKec80= X-Rspam-User: X-Stat-Signature: 95z3eher9p4qhijz8rfg3k1sxfieo5qr X-Rspamd-Queue-Id: DA77D2009D Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N3ufNtX2; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf31.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org X-Rspamd-Server: rspam05 X-HE-Tag: 1662660080-847645 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Just for a record. Apparently Andrew has already added this in mm: https://lore.kernel.org/mm-commits/20220907223146.C7CF4C433D6@smtp.kernel.org/ Thanks, SJ On Thu, 8 Sep 2022 10:19:12 +0800 Xin Hao wrote: > In damon_sysfs_before_terminate() func, it need to check whether > ctx->ops.id supports 'DAMON_OPS_VADDR' or 'DAMON_OPS_FVADDR', there we > can use damon_target_has_pid() instead. > > Signed-off-by: Xin Hao > Reviewed-by: SeongJae Park > --- > mm/damon/sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c > index 7488e27c87c3..88f208ff235d 100644 > --- a/mm/damon/sysfs.c > +++ b/mm/damon/sysfs.c > @@ -2309,7 +2309,7 @@ static void damon_sysfs_before_terminate(struct damon_ctx *ctx) > { > struct damon_target *t, *next; > > - if (ctx->ops.id != DAMON_OPS_VADDR && ctx->ops.id != DAMON_OPS_FVADDR) > + if (!damon_target_has_pid(ctx)) > return; > > mutex_lock(&ctx->kdamond_lock); > -- > 2.31.0