From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28F0BC6FA82 for ; Thu, 8 Sep 2022 22:37:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A59B38D0003; Thu, 8 Sep 2022 18:37:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A096D8D0002; Thu, 8 Sep 2022 18:37:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FA218D0003; Thu, 8 Sep 2022 18:37:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 810A48D0002 for ; Thu, 8 Sep 2022 18:37:36 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4673C160308 for ; Thu, 8 Sep 2022 22:37:36 +0000 (UTC) X-FDA: 79890381312.03.EE24978 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf10.hostedemail.com (Postfix) with ESMTP id D3135C0074 for ; Thu, 8 Sep 2022 22:37:35 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 102ADB82293; Thu, 8 Sep 2022 22:37:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79958C433D7; Thu, 8 Sep 2022 22:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1662676652; bh=RXI/S2LYORA9kdbqhda/3YzOj4NudTqOLXCZh8OTpgA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kEGJQpMHSP1rHh5cA53z/rhx151d3iEmV8c26u8Jrn1nf4Kgqkaa6XyFChHpEBi1o d43NY62xfwL1k6fVhmHe4a2c33akdSyIzFagezUlm27G68VxZa5J3sRBmijWQ2aOQb khq3koVe/u7B5k3QTDiG97mC9VF1/RwV+PrikHkA= Date: Thu, 8 Sep 2022 15:37:31 -0700 From: Andrew Morton To: Shakeel Butt Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Cgroups , Linux MM , LKML Subject: Re: [PATCH 3/3] memcg: reduce size of memcg vmstats structures Message-Id: <20220908153731.d6ec2095c9d1f42ff5e8ec5c@linux-foundation.org> In-Reply-To: References: <20220907043537.3457014-1-shakeelb@google.com> <20220907043537.3457014-4-shakeelb@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662676656; a=rsa-sha256; cv=none; b=UQGfpK1d242uySXq1HJ7dWusa8M3KclyoNFU1RSkt4aCpDrn+2Kf33sFDe4ehJk6h0dQHQ 2ETW25NFJwm7I4Nr3KnJdylTRFv87pwvJkdNdPjNFEjUwRiZVhOu4ZJ9oDHvRvxg6Ss99I aEgC1XFoAJYzozlf7FzV8BL68TRXK00= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=kEGJQpMH; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662676656; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jjIi22j077WmjWx1uhw6kP/NewKpNuGmB7jwDeB0KcY=; b=AAfRjA+HuLby0EDLRwfkxdwKAeKoaefZHIVDpDXtUvHe/EGFU9gCvswFRnXRCCEg2/rALP zKp05o7Bs33S9ljYNvw91gl8V+zDJIpl1pzHcLvVlwCZoCoCXgnMukAqYsBkN5A6zs02Zm gMOgiKPcYoFiwWtFoMFjr/Hxq2EC/5o= X-Rspamd-Queue-Id: D3135C0074 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=kEGJQpMH; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: m8gkugj1dwjs9hxjjg4po43w5x79xzau X-HE-Tag: 1662676655-494266 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 7 Sep 2022 19:35:10 -0700 Shakeel Butt wrote: > On Tue, Sep 6, 2022 at 9:36 PM Shakeel Butt wrote: > > > [...] > > > > static unsigned long memcg_events_local(struct mem_cgroup *memcg, int event) > > { > > long x = 0; > > int cpu; > > + int index = memcg_events_index(event); > > + > > + if (index < 0) > > + return 0; > > > > for_each_possible_cpu(cpu) > > x += per_cpu(memcg->vmstats_percpu->events[event], cpu); > > Andrew, can you please replace 'event' in the above line with 'index'? > I had this correct in the original single patch but messed up while > breaking up that patch into three patches for easier review. No probs. From: Andrew Morton Subject: memcg-reduce-size-of-memcg-vmstats-structures-fix Date: Thu Sep 8 03:35:53 PM PDT 2022 fix memcg_events_local() array index, per Shakeel Link: https://lkml.kernel.org/r/CALvZod70Mvxr+Nzb6k0yiU2RFYjTD=0NFhKK-Eyp+5ejd1PSFw@mail.gmail.com Cc: Johannes Weiner Cc: Michal Hocko Cc: Muchun Song Cc: Roman Gushchin Cc: Shakeel Butt Signed-off-by: Andrew Morton --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/memcontrol.c~memcg-reduce-size-of-memcg-vmstats-structures-fix +++ a/mm/memcontrol.c @@ -921,7 +921,7 @@ static unsigned long memcg_events_local( return 0; for_each_possible_cpu(cpu) - x += per_cpu(memcg->vmstats_percpu->events[event], cpu); + x += per_cpu(memcg->vmstats_percpu->events[index], cpu); return x; } _