From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CCCCC54EE9 for ; Thu, 8 Sep 2022 22:02:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD30D8D0003; Thu, 8 Sep 2022 18:02:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B82048D0001; Thu, 8 Sep 2022 18:02:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A71728D0003; Thu, 8 Sep 2022 18:02:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9955E8D0001 for ; Thu, 8 Sep 2022 18:02:51 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 690281A06CB for ; Thu, 8 Sep 2022 22:02:51 +0000 (UTC) X-FDA: 79890293742.02.FBD7EA4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id F395A40084 for ; Thu, 8 Sep 2022 22:02:50 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 51D5761E40; Thu, 8 Sep 2022 22:02:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5250DC433D6; Thu, 8 Sep 2022 22:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1662674569; bh=8sy1ATs3JDer4J6KBpLpL/36vh5+x6IuTH2whh/yMVE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=x1eZtPss8z2xDuQ68b7Q5wAXvxzGWI3qEDMWP24UxzJLRN0Ko2W1T66YWttxzQSug fl4/D5KUwLVvlUF4thcLin9nf2YLrJqrxEww2eV1LvdGqPuFVeNXBhmHAFqIVnbKnm uoyYf/5C6LmYn6auMZsETC++A5gpXT7EgxuY4U8w= Date: Thu, 8 Sep 2022 15:02:48 -0700 From: Andrew Morton To: Liu Shixin Cc: Jonathan Corbet , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , , , , , Kefeng Wang Subject: Re: [PATCH] mm/memcontrol: use kstrtobool for swapaccount param parsing Message-Id: <20220908150248.85fff32bf275844f0927a856@linux-foundation.org> In-Reply-To: <20220908083452.2844125-1-liushixin2@huawei.com> References: <20220908083452.2844125-1-liushixin2@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662674571; a=rsa-sha256; cv=none; b=JyHNSFM6xxS3TG/OeeMXKW/WLy/HTKT3BHpzl7WOHxZOiZ/clLfkHHxbrcvH4K3vcFvhnn 1LnwSSliGTDv7csHKt1eLtK214ZZWAB3YjX4HMRVhrj8zPZUlC4FC+AeOIZvQa4Etw7r5C ULbgpKzB2HsP1jMB6TPLJOYNcH2qCkM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=x1eZtPss; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662674571; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4gMwWxeuhRlYeNYCOe1unChyx8/6+Bhy4WfYdBCslfQ=; b=YzKz4OeLmoVfYWnSpnlqJdBlOL6l+4jq6YI5flQpEAfilKzrR+t8QoYMFYkdLgBPVD/MU6 ityDboNc7/ZDPYdynlflJ1rmBUi/cpT5zVPTcRaXZgi96uUEwe8WFJ58sakG6ZAnLmiEqO hg/51wlK4oiwbULnBEN0VtzgeqncLGk= X-Stat-Signature: ayz3hw5cpb6j4tojxgd63pwhstqhfizj X-Rspamd-Queue-Id: F395A40084 X-Rspamd-Server: rspam11 X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=x1eZtPss; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1662674570-15797 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 8 Sep 2022 16:34:52 +0800 Liu Shixin wrote: > --- a/mm/swap_cgroup.c > +++ b/mm/swap_cgroup.c > @@ -194,7 +194,7 @@ int swap_cgroup_swapon(int type, unsigned long max_pages) > return 0; > nomem: > pr_info("couldn't allocate enough memory for swap_cgroup\n"); > - pr_info("swap_cgroup can be disabled by swapaccount=0 boot option\n"); > + pr_info("swap_cgroup can be disabled by swapaccount=[oO][Ff]/N/n/0 boot option\n"); I'm not sure this really needed changing. "=0" was OK and the message now looks rather silly. But whatever.