From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6C43C38145 for ; Wed, 7 Sep 2022 20:59:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 224D06B0072; Wed, 7 Sep 2022 16:59:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D3D08D0001; Wed, 7 Sep 2022 16:59:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09C286B0074; Wed, 7 Sep 2022 16:59:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F12F96B0072 for ; Wed, 7 Sep 2022 16:59:16 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C7585160C6A for ; Wed, 7 Sep 2022 20:59:16 +0000 (UTC) X-FDA: 79886504712.20.FCC2167 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf19.hostedemail.com (Postfix) with ESMTP id 40A451A005A for ; Wed, 7 Sep 2022 20:59:16 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 00224B81EEC; Wed, 7 Sep 2022 20:59:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38F69C433C1; Wed, 7 Sep 2022 20:59:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662584353; bh=FniondtFbpoxyTfBIT/tD9EaOffiZzbj+1i6uXyMxKM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AMug+Taf20KbZ8zIj/PQfrkYE8FfrIMY8WMjII3yQUm0cPgAuy8hk+xQnzsiM52qV DXpqiSjYvWK1tzW8Y0q19Tn4gDBPbAodLlmF2dfNmnyXssKSOt5CuzcLe/ZBkqXfyX gcji/ukWAB/IstDYNQCtfr7j2+fzjdJPGhjJtguAeOYlE4cHfTR8TAP/jv414jx8xG 7zdxa/bSlZrTRuL0rBQJTCS3HrGItneKuIuHKO08hWAclQUacwdBwoldEJOEDnWOUB JT+5Y/GZfww+TsV3oUD13RME09kRA/jLjR0+YUy1Qn6j3tnGiwZqlpRLomUpZbJ8k+ vEZ7HQjbFXJLA== From: SeongJae Park To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xhao@linux.alibaba.com Subject: Re: [PATCH] mm/damon: Remove duplicate get_monitoring_region() definitions Date: Wed, 7 Sep 2022 20:59:11 +0000 Message-Id: <20220907205911.62483-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220907172712.61006-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AMug+Taf; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662584356; a=rsa-sha256; cv=none; b=HTAriXlhJiJwf6tCUfV9TLoTcQhbxD48olF6WYF9GW9W6HUnyjMU7vjJwMwdvk0j7kosqO QjHAmmpAA9WqXFrJY3ymMNGKOYHSOrpGuhCx6KAaI5kkPnlaq5N8OBO5VBcAvT/X8wyJ/4 yKcWLyeMTCIE1pZuYtM9IxrCkWe4pwk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662584356; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W8294Ib9KDqbK/42kf/e/9dOJorrt1Xs/psQk3LiJck=; b=IP3GYZfTA3X0nyHPDdCQf92HsREZI4ICgoEaUIqbSqA89Sl94xlHyq/L3Av3TV6c+Kgeew 5IwIZ7xch4Y4Md0QGwSH45UCulS65QM145EGRx4cAtuLCyrFTbtHECe69xFFrpKo/++X1Y b8Q/OxfjBMlqmBfgFo+6fGSNi+oAZz0= Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AMug+Taf; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Queue-Id: 40A451A005A X-Rspamd-Server: rspam10 X-Stat-Signature: z3jkmuqgnuxinasci3pnm4sdaq83msk3 X-HE-Tag: 1662584356-757020 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 7 Sep 2022 17:27:12 +0000 SeongJae Park wrote: [...] > > diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c > > index b1335de200e7..01938f33038d 100644 > > --- a/mm/damon/ops-common.c > > +++ b/mm/damon/ops-common.c > > @@ -172,3 +172,31 @@ int damon_hot_score(struct damon_ctx *c, struct damon_region *r, > > > > return hotness; > > } > > + > > +static inline int walk_system_ram(struct resource *res, void *arg) > > +{ > > + struct damon_addr_range *a = arg; > > + > > + if (a->end - a->start < resource_size(res)) { > > + a->start = res->start; > > + a->end = res->end; > > + } > > + return 0; > > +} > > + > > +/* > > + * Find biggest 'System RAM' resource and store its start and end address in > > + * @start and @end, respectively. If no System RAM is found, returns false. > > + */ > > +bool get_monitoring_region(unsigned long *start, unsigned long *end) > > +{ > > + struct damon_addr_range arg = {}; > > + > > + walk_system_ram_res(0, ULONG_MAX, &arg, walk_system_ram); > > + if (arg.end <= arg.start) > > + return false; > > + > > + *start = arg.start; > > + *end = arg.end; > > + return true; > > +} > > 'ops-common.c' is for code that common in monitoring operations > implementations. I'd prefer to have yet another source file for the DAMON > modules including reclaim and lru_sort, say, 'modules-common.c'. Or, putting it in damon/core.c might make more sense. Thanks, SJ [...]