From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FB40C38145 for ; Wed, 7 Sep 2022 17:42:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44BD08D0002; Wed, 7 Sep 2022 13:42:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FCCE6B0073; Wed, 7 Sep 2022 13:42:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E9F08D0002; Wed, 7 Sep 2022 13:42:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 212626B0072 for ; Wed, 7 Sep 2022 13:42:13 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DE517161225 for ; Wed, 7 Sep 2022 17:42:12 +0000 (UTC) X-FDA: 79886008104.16.DCE6C45 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf22.hostedemail.com (Postfix) with ESMTP id 834CFC008D for ; Wed, 7 Sep 2022 17:42:12 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2A887B81E0C; Wed, 7 Sep 2022 17:42:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42131C433C1; Wed, 7 Sep 2022 17:42:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662572529; bh=Fxy9JuorIOPwm9qgEKC5873CJe+ELikzyA/2KWjOoRc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KLYZmnbw38GsCpgRtC0AUxgr7KRmniYbNUydgRsLcmfNsRiphKFn8hAZ8mT2PbrrA 8VWC1vIRSK6wCCRNWC3HPwHc86aHPdx9DBNO/6timSsWeoSF1yej9TEbfny98qdrfV S2kzwmzOZs0QEJ3h6O31mjFrcPT6AmYOHcZ2akxHJgh/77u93gqokWwjMCFUY0rSMv ZYSuei1s/ZyRiS7FlcEY0KsOGfRcKZ09vLaRlwyy7C7HcY4YhsuCs3+BagDD4AeuMY DlYopfvHqzShTfddz4M7gIjZErHPup3XZfBL7LddKhsswawfA4rQMWfHSFGiLbxuMy ip2/VFVrdbNmQ== From: SeongJae Park To: xiakaixu1987@gmail.com Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH] mm/damon/vaddr: remove unnecessary switch case DAMOS_STAT Date: Wed, 7 Sep 2022 17:42:07 +0000 Message-Id: <20220907174207.61191-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1662568262-20925-1-git-send-email-kaixuxia@tencent.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662572532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yzeODPIeX0ffADUqFHLB6GqRbP0SAuqpZCYcxcXCJHs=; b=LxnTlG0q+LbLlE6rUMcsnyv3BNq+Of6t6IC6E6cm5IAdnNDnXfP3MTr6BU7cI7a1lCI/jg wQrHkWqLRVqf1PJwfr9CoEpiEAkf9I9rpOZniRbUjpELeUU119/uT89jq6aqh+NaHG3tTd CbFfHpAddsn6ypcVcoRhGik8YUCq+Qg= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KLYZmnbw; spf=pass (imf22.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662572532; a=rsa-sha256; cv=none; b=7KikQ2OoSYapUCybmogDN4kQtvFUFNA0IXzIeofoQvMPe3JcXuJJAJBQ9nkqEM5QM3J6yg nL4wtoQJeIiIFAfuL5JlnrSOcnl0Nj5zl68w9NrmmuVDuIMMLs3VdVthXZ/Vcy06pjD7ip rgZfsiZvvsCVAcZ9mV9F0uFSr9R89g4= X-Stat-Signature: 793j7ad38w4qcijqy8k9s8f6dk9yrdwf X-Rspamd-Queue-Id: 834CFC008D X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KLYZmnbw; spf=pass (imf22.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam09 X-HE-Tag: 1662572532-619507 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kaixu, On Thu, 8 Sep 2022 00:31:02 +0800 xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > The switch case DAMOS_STAT and switch case default have same > return value in damon_va_apply_scheme(), so we can combine them. Good point. I have a comment below, though. > > Signed-off-by: Kaixu Xia > --- > mm/damon/vaddr.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > index 3c7b9d6dca95..94ae8816a912 100644 > --- a/mm/damon/vaddr.c > +++ b/mm/damon/vaddr.c > @@ -643,8 +643,6 @@ static unsigned long damon_va_apply_scheme(struct damon_ctx *ctx, > case DAMOS_NOHUGEPAGE: > madv_action = MADV_NOHUGEPAGE; > break; > - case DAMOS_STAT: > - return 0; IMHO, keeping the 'case' makes the code easier to read, as we can find what is the expected flow for DAMOS_STAT here immediately, instead of asking readers to find what are the actions that not specified here and therefore fall though to 'default'. Also, my another intention here is to mark 'DAMOS_STAT' is supported by 'vaddr'. > default: > return 0; That is, 'default' case here is for DAMOS actions that not supported by 'vaddr'. So, I'd like to keep the code as is. Maybe we could add a comment saying 'default' case is for DAMOS actions that not yet supported by 'vaddr'. > } > -- > 2.27.0 Thanks, SJ