From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47A8BC54EE9 for ; Wed, 7 Sep 2022 16:57:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E2148D0001; Wed, 7 Sep 2022 12:57:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76AF06B0073; Wed, 7 Sep 2022 12:57:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60B628D0001; Wed, 7 Sep 2022 12:57:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4C6D36B0072 for ; Wed, 7 Sep 2022 12:57:33 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 16BDAAB458 for ; Wed, 7 Sep 2022 16:57:33 +0000 (UTC) X-FDA: 79885895586.13.D2D2523 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf25.hostedemail.com (Postfix) with ESMTP id 6933EA009A for ; Wed, 7 Sep 2022 16:57:32 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 97CB3B81E47; Wed, 7 Sep 2022 16:57:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8A21C433D7; Wed, 7 Sep 2022 16:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662569849; bh=zTO/JfNwKwxbPNU1PGY3F5bXy5SfDDKgvFHJFPd1TEM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ILOjycA43nB7oJr1Us0s8EOOx5f9vtBZsyQt/FuiKrWGfVI2LQnI2si7Nf/7PG7Vf opEOd+hUtUzDwlw4npYwrkyFd3MJ3rYcSbyT70zifnLIghl849odWL/53zZwZOufw0 3wrNYRdoDqbndbYwc8OYZxFekoIqxaWpjgi+IA04ZB8wKVQBeQfkVlleEMKGJ91yrl kj43j2v9rdVG/C0I0P8Fw2V3WBAyUqRBYptEwerMnTP0rG+oUB/LQ3Ta4h6dkAFscV qCkrnYjq67WvBUdtL0s9bG+q2g7NgvVXcT2Ev9Pwcxo+Nro+T62xnaXi2JkM1v7V5i Huxf4iafbOX+g== From: SeongJae Park To: Xin Hao Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon: Simply damon_ctx check in damon_sysfs_before_terminate Date: Wed, 7 Sep 2022 16:57:26 +0000 Message-Id: <20220907165726.52151-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220907084116.62053-1-xhao@linux.alibaba.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662569852; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DMGJLcycDkIh34LEaUJP1bfQMW93peNjTzRXnaiqUwI=; b=FfECJlaSOxniIVNdp8MxEB9VgR7FazyGwNzsds713vKwXAooHXCW1StaAKVg0Jw2zP7+Nr mzpCALhUWnGw4QgHJPIA2653JWH/P871eu8aEA6E/AlXqF+Ek5fW7sEYEaN6hWrsnUYjZm RVeipOvESUUWPsGvoCoIjnlrYADHtX4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ILOjycA4; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662569852; a=rsa-sha256; cv=none; b=OVN8k2TZwiS8CkdGxIs3nwG0NGWGzi3wv5knDhvEd/wQEQYIylNNq6khzm9RD4kS+KqykH RXcLT9ejPC9tQohs9YL6ZF4GEww/DQlwjNmTz0zb/t3XrlTdB2Sp1ExbU3CQsOf07VM20F VnA89rikzTePSzF0EsKUoQLQqe1hre4= X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ILOjycA4; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam08 X-Stat-Signature: 99phtq3qfo5iodykjya9rfcbsrduxste X-Rspamd-Queue-Id: 6933EA009A X-HE-Tag: 1662569852-300282 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Xin, Nit: I'd suggest to 's/Simply/simplify/' in the subject. On Wed, 7 Sep 2022 16:41:16 +0800 Xin Hao wrote: > In damon_sysfs_before_terminate() func, it need to check whether > ctx->ops.id supports 'DAMON_OPS_VADDR' or 'DAMON_OPS_FVADDR', there we > can use damon_target_has_pid() instead. > > Signed-off-by: Xin Hao Other than the above trivial nit, Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c > index 7488e27c87c3..88f208ff235d 100644 > --- a/mm/damon/sysfs.c > +++ b/mm/damon/sysfs.c > @@ -2309,7 +2309,7 @@ static void damon_sysfs_before_terminate(struct damon_ctx *ctx) > { > struct damon_target *t, *next; > > - if (ctx->ops.id != DAMON_OPS_VADDR && ctx->ops.id != DAMON_OPS_FVADDR) > + if (!damon_target_has_pid(ctx)) > return; > > mutex_lock(&ctx->kdamond_lock); > -- > 2.31.0