From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32DC8ECAAA1 for ; Tue, 6 Sep 2022 18:20:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C040A8D0001; Tue, 6 Sep 2022 14:20:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB4446B0073; Tue, 6 Sep 2022 14:20:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7B298D0001; Tue, 6 Sep 2022 14:20:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 989346B0072 for ; Tue, 6 Sep 2022 14:20:10 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 68E961A0F9A for ; Tue, 6 Sep 2022 18:20:10 +0000 (UTC) X-FDA: 79882474980.15.28518D8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 00DB11200AB for ; Tue, 6 Sep 2022 18:20:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 15EDC61627; Tue, 6 Sep 2022 18:20:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2692C433D6; Tue, 6 Sep 2022 18:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662488408; bh=GEJkql041XXCsjNgtcCyFYYz65fNAGYwfs5meFdVjWs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KBxn9Hm/BZ1H6OGeq5gyTeP5SB8glt+bMpRbFHQvBuKeJTYFnraod3Fsa1syirqGk 1Q1zyaVGYR8KZ0TPNq+f7xNnMgUAaDTocIJogGjT3HsnWTBXAiZl8hX36aAcFB6yXV s/zuxdvIShLJytiqyG7rYtt3IJgRpXoJe33ZIl5JWWJOVjzxE0vAMfIMbGgLDSDfoX rQiI/BKObHqA73TV86kC2MUuamKgBIL8XpB6uqEd/PmrlzslOkj0q94buhCm7yQzCo geVFa1I+rbuRpVhG45hs2UdFHrWD1k17zafVMfD87VeGLaXS8fd4FeIcomP9wUIH1t +iPVNd/SsxSNg== From: SeongJae Park To: xiakaixu1987@gmail.com Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH] mm/damon/core: iterate the regions list from current point in damon_set_regions() Date: Tue, 6 Sep 2022 18:20:06 +0000 Message-Id: <20220906182006.50955-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1662477527-13003-1-git-send-email-kaixuxia@tencent.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662488410; a=rsa-sha256; cv=none; b=gbvRyRGmzzCRGnCAyG50mnUR5f7AFtp+WUo3kWkGiuejbkvchWmwUwDf2xGZ4usAhdrMy1 MbE9j/5HW1iYGdX2NhsXLU1CqW8RHsW/VTux8axUCVMbxgBxSEUVaLVrTokCacc7yeyBbH ltOZ6Qseikid3MbIG8P1G0RmH5iqYIQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="KBxn9Hm/"; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662488410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t0bGhnR4nzh3S2s6TL6CYg7BlYWebzrFM9Ry5YNs2a0=; b=BL+0maGMQr0oGYHcsZ55iuNjtJT0NYrbBFEoW3K/ZlLfVIyOHsjeYUpnUadwdMOrFJdPNY tZUnQMUc5OWEufnZO9Yk20bw9fsN2tvOQTFIYhGg+SDGJVtYZJ5xPA5DIYisoo9ntPLYTw ioK6lzsQ6sxnVoW1a4/qDxE/ks0EXTA= X-Stat-Signature: 3m7i31oet8qsm58sdm83fcfqqm8g9boz X-Rspamd-Queue-Id: 00DB11200AB Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="KBxn9Hm/"; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1662488409-435086 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kaixu, On Tue, 6 Sep 2022 23:18:47 +0800 xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > We iterate the whole regions list every time to get the first/last regions > intersecting with the specific range in damon_set_regions(), in order to > add new region or resize existing regions to fit in the specific range. > Actually, it is unnecessary to iterate the new added regions and the > front regions that have been checked. Just iterate the regions list from > the current point using list_for_each_entry_from() every time to improve > performance. > The kunit tests passed: > [PASSED] damon_test_apply_three_regions1 > [PASSED] damon_test_apply_three_regions2 > [PASSED] damon_test_apply_three_regions3 > [PASSED] damon_test_apply_three_regions4 > > Signed-off-by: Kaixu Xia Reviewed-by: SeongJae Park Thanks, SJ [...]