From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DEA1ECAAD3 for ; Mon, 5 Sep 2022 19:32:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAB81801FE; Mon, 5 Sep 2022 15:32:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D33AF801E6; Mon, 5 Sep 2022 15:32:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAD45801FE; Mon, 5 Sep 2022 15:32:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A6854801E6 for ; Mon, 5 Sep 2022 15:32:03 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 75679A06C2 for ; Mon, 5 Sep 2022 19:32:03 +0000 (UTC) X-FDA: 79879027326.24.E0EE142 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf18.hostedemail.com (Postfix) with ESMTP id 181241C0060 for ; Mon, 5 Sep 2022 19:32:02 +0000 (UTC) Received: by mail-yb1-f202.google.com with SMTP id v5-20020a2583c5000000b006964324be8cso7074737ybm.14 for ; Mon, 05 Sep 2022 12:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date; bh=nzYPTXzWW9nmntWCV8Vh/LKoFqcXyIKvmgnu1hGqu7k=; b=WjbKtL1D/4BXosFYcBo3Si+QUfuKWnKSWJbeLnRZnaybjfLdGcEJjjFW57YuBXnd7j VG3d7Mmo3qrYy0ZyW1mYkiDPH1xODzNXv7eE2AL+LxXcuucTAmmD8nt80QxlxPYdTItP GF5/MRKziOzianOw+Uxq4CNNYNO2p3srplb3WOIVzrEHuBdy5569DMrcyeNyaIaz6ryv YofbNi4e2vtlS0wPOj8QD36kSGIZirDb7K45pWi1bHqv+cALIJ5RizNMyfHcuVKAbONz zgdCwUZq5aIx3WjrC0EddIwXSy9UHyfMOQgIbSLAJRqN5g2RspVR/JJVASoMFonflc2L EtTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date; bh=nzYPTXzWW9nmntWCV8Vh/LKoFqcXyIKvmgnu1hGqu7k=; b=y/iwCLw0g1+U4oAp30HuyV+90IlrYuJwi4Inz70CbpYIRtvhMCbM72IOTOlcu1g57w 83E/CSqkuy3Ls+OSnzhURIntAfyFUP4XBfMO1Phs3N3LGG72dZSW120Sm9uiFXlu96jl AxrPuxMWxugO+zPziekJAjRVHaWFMiMSjfepM7aWni8TvQ5ML6sfjb05vIuXdA9vPeCL ilG5I/NYZIUBvXrcNGWaN2AuAdScoZh5s6OmploO3Kint94AV05ycRUFcgk13aCZAwGl 7oVLxhmXOIZsHMXDIQGyuluwOu2Et0/WqLABkzWdLDc2FR8NVEeLkMe10KQPK16yOvp+ XTgw== X-Gm-Message-State: ACgBeo1JzUeg8jvg2COa+frtazdlzSiCkcykUi6SufOAddz15kRtKV3D nW1Rwh1N3Vp2uRTFxcg49rN5wFZE1M6Zeg== X-Google-Smtp-Source: AA6agR45LtLtFdonuDVQF86B/UUUAlIaw1OBFliTILqCjdA5n/Kgr/GmjivDnXK1JxcUbWbLC/ps6jCHTlNz9A== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a0d:d2c1:0:b0:33e:e1f4:4bb0 with SMTP id u184-20020a0dd2c1000000b0033ee1f44bb0mr38132884ywd.234.1662406322246; Mon, 05 Sep 2022 12:32:02 -0700 (PDT) Date: Mon, 5 Sep 2022 19:31:59 +0000 In-Reply-To: <20220905193516.846647-3-jiebin.sun@intel.com> Mime-Version: 1.0 References: <20220902152243.479592-1-jiebin.sun@intel.com> <20220905193516.846647-1-jiebin.sun@intel.com> <20220905193516.846647-3-jiebin.sun@intel.com> Message-ID: <20220905193159.eeu2xmqj6743kzxv@google.com> Subject: Re: [PATCH v2 1/2] percpu: Add percpu_counter_add_local From: Shakeel Butt To: Jiebin Sun Cc: akpm@linux-foundation.org, vasily.averin@linux.dev, dennis@kernel.org, tj@kernel.org, cl@linux.com, ebiederm@xmission.com, legion@kernel.org, manfred@colorfullife.com, alexander.mikhalitsyn@virtuozzo.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tim.c.chen@intel.com, feng.tang@intel.com, ying.huang@intel.com, tianyou.li@intel.com, wangyang.guo@intel.com Content-Type: text/plain; charset="us-ascii" ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=WjbKtL1D; spf=pass (imf18.hostedemail.com: domain of 3sk4WYwgKCMc5unxrryot11tyr.p1zyv07A-zzx8npx.14t@flex--shakeelb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3sk4WYwgKCMc5unxrryot11tyr.p1zyv07A-zzx8npx.14t@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662406323; a=rsa-sha256; cv=none; b=fMsk2trdrmd0uGCJ+sHwMf0JM0WSvV9zRBvKr6dP+81EcCZPKuREJeHBUu9fdFO3pyLlAG wLka/xIp18a19QHxN5tntd0eFPUIrUWzuXPLpE/SB4KWLEuII70xaS0zi8HppDUQ9LU0m/ q0f1De4OT4i2iOKuMtEiu3SRj4FUHto= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662406323; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nzYPTXzWW9nmntWCV8Vh/LKoFqcXyIKvmgnu1hGqu7k=; b=C6soVrsSEr7muNSgBzcm23lzgQ66+5btdm0J1AirWVs32H6VSVSbQPee9DqRCjCylEYClt LAk9wTBezqdMfzUhDxOHexjyn45x+8FNLgYjnE7KH6IlrtW6S1fzhnxnlyX5JFhVPQS/h3 NoB147uHgq7dEDndKiYY0LZJQyZ6g3o= Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=WjbKtL1D; spf=pass (imf18.hostedemail.com: domain of 3sk4WYwgKCMc5unxrryot11tyr.p1zyv07A-zzx8npx.14t@flex--shakeelb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3sk4WYwgKCMc5unxrryot11tyr.p1zyv07A-zzx8npx.14t@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Stat-Signature: mf4ucijqh1oo1thbi73tj9raqkox6a89 X-Rspamd-Queue-Id: 181241C0060 X-Rspamd-Server: rspam05 X-HE-Tag: 1662406322-164023 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 06, 2022 at 03:35:16AM +0800, Jiebin Sun wrote: > Add percpu_counter_add_local for only updating local counter > without aggregating to global counter. Please add why do we need this. Who should use this and who shouldn't. > > Signed-off-by: Jiebin Sun [...] > diff --git a/lib/percpu_counter.c b/lib/percpu_counter.c > index ed610b75dc32..d33cb750962a 100644 > --- a/lib/percpu_counter.c > +++ b/lib/percpu_counter.c > @@ -72,6 +72,12 @@ void percpu_counter_set(struct percpu_counter *fbc, s64 amount) > } > EXPORT_SYMBOL(percpu_counter_set); > Add a doc comment here on why someone want to use this? > +void percpu_counter_add_local(struct percpu_counter *fbc, s64 amount) > +{ > + this_cpu_add(*fbc->counters, amount); > +} > +EXPORT_SYMBOL(percpu_counter_add_local); > + > /* > * This function is both preempt and irq safe. The former is due to explicit > * preemption disable. The latter is guaranteed by the fact that the slow path > -- > 2.31.1 >